bugGNU Octave - Bugs: bug #41658, Multiple "utils.h" files...

 
 

bug #41658: Multiple "utils.h" files cause build failures on case-insensitive file systems

Submitted by:  Michael C. Grant <mcgrant>
Submitted on:  Fri 21 Feb 2014 02:54:08 PM UTC  
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Michael C. Grant Open/Closed:  Closed
Release:  dev Operating System:  Mac OS

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 21 Feb 2014 04:38:51 PM UTC, comment #2: 

Thanks for the patch, but I decided to fix it by renaming the file instead.

http://hg.savannah.gnu.org/hgweb/octave/rev/fb96b7f55242

John W. Eaton <jwe>
Project Administrator
Fri 21 Feb 2014 03:21:19 PM UTC, comment #1: 

Changeset provided.

(file #30632)

Michael C. Grant <mcgrant>
Fri 21 Feb 2014 02:54:08 PM UTC, original submission:  

I've started getting errors like this when compiling the gui-release branch:

src/main-window.cc:275:9: error: use of undeclared identifier 'valid_identifier'
  if (! valid_identifier (function_name.toStdString ()))

The cause is the presence of two files named "utils.h":

libinterp/corefcn/utils.h
libgui/graphics/Utils.h

This can be rectified temporarily by replacing

#include "utils.h"

with

#include "corefcn/utils.h"

but I suspect that a proper solution involves renaming the newly added Utils.h file.

Michael C. Grant <mcgrant>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #30632:  utilscs.diff added by mcgrant (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by mcgrant (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-02-21 jwe StatusNone => Fixed
        Open/ClosedOpen => Closed
    2014-02-21 mcgrant Attached File- => Added utilscs.diff, #30632

    Back to the top


    Powered by Savane 3.5