bugGNU Octave - Bugs: bug #41540, dbstatus doesn't correctly list...

 
 

bug #41540: dbstatus doesn't correctly list file name for class methods with breakpoints

Submitter:  Rik <rik5>
Submitted:  Mon 10 Feb 2014 05:50:41 PM UTC
   
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  lachlan
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Sun 14 Feb 2016 09:13:54 PM UTC, comment #6: 

I applied the patch here http://hg.savannah.gnu.org/hgweb/octave/rev/b248c28d9a7b.  I also followed it with some cleanup of debug.cc.  I think when Philip applied the original patch there might have been an expansion from tabs to spaces because many of the comments were incorrectly indented.  Cleanup patch is here http://hg.savannah.gnu.org/hgweb/octave/rev/4ee768b71a0e.

Fixed, closing report.

Rik <rik5>
Group administrator
Fri 12 Feb 2016 11:04:50 AM UTC, comment #5: 

The attached patch seems to give the correct behaviour.  I've added a BIST entry testing the four combinations of class/normal and sub-function/main-function.

(file #36322)

Lachlan Andrew <lachlan>
Fri 12 Feb 2016 06:27:57 AM UTC, comment #4: 

The canonicalized name probably differs if there is a relative entry on your path.  Without canonicalization, I was getting things like  /something/.build/../scripts/something

I'll look into what is causing  @ftp/dir>dir.

Lachlan Andrew <lachlan>
Fri 12 Feb 2016 06:21:40 AM UTC, comment #3: 

What is a test case where I would see the difference between the regular name and the canonicalized name?  I applied the patch and used the example in the original submission, but the output is the same as without the patch.

Incidentally, the output for @ftp/dir is @ftp/dir>dir.  This is a little odd because the hierarchy operator '>' is usually used only when the object to the right is a subfunction within the main file.  If there is only one function in a file then it is simpler to just list the file.  This is the case if you use dbstop with a simple function, for example, 'dbstop ls'.

Rik <rik5>
Group administrator
Mon 08 Feb 2016 06:02:45 AM UTC, comment #2: 

Oops.  I forgot to add the patch to return the canonicalized filename.

(file #36274)

Lachlan Andrew <lachlan>
Sat 30 Jan 2016 10:42:46 PM UTC, comment #1: 

This works, since Philip applied
http://hg.savannah.gnu.org/hgweb/octave/rev/94fc5f13d51b

If you want a canonicalized filename, apply the attached patch.

Can this bug be closed now?


Lachlan Andrew <lachlan>
Mon 10 Feb 2014 05:50:41 PM UTC, original submission:  

When there is more than one function file with the same name, such as dir.m and @ftp/dir.m, dbstatus incorrectly lists the wrong file as having the breakpoint.  The actual breakpoint is set correctly.

Example:


dbstop @ftp/dir
ans =  28
s = dbstatus
s =

  scalar structure containing the fields:

    name = dir
    file = /home/rik/wip/Projects_Mine/octave-dev/scripts/miscellaneous/dir.m
    line =  28


For methods which do not overlap with another function, no file is printed at all.  This is also wrong.


dbstop @ftp/mget
ans =  36
s = dbstatus
s =

  scalar structure containing the fields:

    name = mget
    file =
    line =  36



Rik <rik5>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #36322:  bug_41540_v2.cset added by lachlan (4KiB - application/octet-stream)
file #36274:  bug_41540.cset added by lachlan (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by lachlan (Posted a comment)
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-02-14 rik5 StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2016-02-12 lachlan Attached File- Added bug_41540_v2.cset, #36322
    2016-02-12 lachlan StatusFixed In Progress
    2016-02-08 lachlan Attached File- Added bug_41540.cset, #36274
        StatusNone Fixed
        Assigned toNone lachlan

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code