bugGNU Octave - Bugs: bug #41531, isequaln fails comparing object to...

 
 

bug #41531: isequaln fails comparing object to non-object

Submitted by:  Felipe G. Nievinski <fgnievinski>
Submitted on:  Sun 09 Feb 2014 07:37:18 PM UTC  
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  3.8.0 Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 12 Feb 2014 05:12:58 PM UTC, comment #3: 

I made a few modifications.  The Octave coding convention is to surround the conditional of an if statement in parentheses as for C/C++.  I also broke out of the for loop immediately with break rather than continue; Once we know one of the inputs is not an object it will be impossible for isequal to return true.  The changeset is here (http://hg.savannah.gnu.org/hgweb/octave/rev/ff7e7928f160) on the stable branch.

Rik <rik5>
Project Administrator
Mon 10 Feb 2014 03:02:54 PM UTC, comment #2: 

here you go

(file #30496)

Felipe G. Nievinski <fgnievinski>
Mon 10 Feb 2014 03:52:54 AM UTC, comment #1: 

Could you prepare a Mercurial changeset or a unified diff?  I can't apply the attached diff with patch because it doesn't have any context.

Rik <rik5>
Project Administrator
Sun 09 Feb 2014 07:37:18 PM UTC, original submission:  

patch attached

Felipe G. Nievinski <fgnievinski>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #30496:  isequal.patch added by fgnievinski (963B - application/octet-stream)
file #30493:  __isequal__.m.diff added by fgnievinski (314B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by fgnievinski (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-02-12 rik5 StatusNone => Fixed
        Open/ClosedOpen => Closed
    2014-02-10 fgnievinski Attached File- => Added isequal.patch, #30496
    2014-02-09 fgnievinski Attached File- => Added __isequal__.m.diff, #30493

    Back to the top


    Powered by Savane 3.5