bugGNU Octave - Bugs: bug #41516, GUI editor zoom in keybinding...

 
 

bug #41516: GUI editor zoom in keybinding should be set

Submitted by:  Felipe G. Nievinski <fgnievinski>
Submitted on:  Sat 08 Feb 2014 08:10:39 PM UTC  
 
Category: GUISeverity: 3 - Normal
Priority: 5 - NormalItem Group: Feature Request
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 15 Mar 2014 08:15:26 PM UTC, comment #12:

I have pushed changeset
http://hg.savannah.gnu.org/hgweb/octave/rev/26d15a57f45b
which adds zoom in and zoom out in the editor with updating the margin width where the linenumbers are shown.
The shortcuts are Ctrl+<keypad+>, Ctrl+<keypad-> and Ctrl+<keypad/>. Using Ctrl++ does not work because this is Ctrl+Shift+= on us-keyboards and not recognized as Ctrl++.

Torsten <ttl>
Project Member
Sat 22 Feb 2014 12:02:20 PM UTC, comment #11:

Could someone please test the attached patch (gui-release)?

It is identical to the changeset
http://hg.savannah.gnu.org/hgweb/octave/rev/f01ac1bb8a5d
which was backed out cause it was breaking the following shortcuts in the editor: Ctrl-C, Ctrl-X, Ctrl-V and Ctrl-Z (all the shortcuts that are defined by QScintilla and redefined by the octave editor).

Today, I wanted to fix the patch and now all shortcuts are working in addition the new ones for zooming the text.

(file #30637)

Torsten <ttl>
Project Member
Thu 13 Feb 2014 09:22:34 PM UTC, comment #10:

Reopened since the patch broke a few short cuts

Torsten <ttl>
Project Member
Thu 13 Feb 2014 08:49:16 PM UTC, comment #9:

Pushed the patch with changeset
http://hg.savannah.gnu.org/hgweb/octave/rev/f01ac1bb8a5d

Torsten <ttl>
Project Member
Tue 11 Feb 2014 05:30:26 AM UTC, comment #8:

A "View" menu with the zoom entries is already implemented by the patch.

Torsten <ttl>
Project Member
Mon 10 Feb 2014 09:35:07 PM UTC, comment #7:

thanks for keeping ctrl-0 for showing the command window;
ctrl-alt-0 should be okay; otherwise, I'd propose a menu item instead of a dedicated keyboard shortcut.

Felipe G. Nievinski <fgnievinski>
Mon 10 Feb 2014 08:45:10 PM UTC, comment #6:

Attached a patch that overrides the QsciScintilla-internal shortcuts with Ctrl-+, Ctrl-- (normal keys) and Ctrl-Alt-0 for zoom in, zoom out and normal size respectively. Ctrl-0, which is in general used for the normal size, is already in use for showing the console. Should we change this?

The advantage of not using the internal shortcuts is that the margin width is adapted when text size is changed.

(file #30502)

Torsten <ttl>
Project Member
Sat 08 Feb 2014 11:52:45 PM UTC, comment #5:

On a different keyboard, I can indeed zoom in with Ctrl-<Keypad +> and zoom out with Ctrl-<Keypad ->.

Without the keypad, I can only zoom out with Ctrl--. Trying to zoom in with Ctrl-= or Ctrl-+ (Ctrl-Shift-=) only inserts = and + characters into the editor text pane for me.

Mike Miller <mtmiller>
Project Member
Sat 08 Feb 2014 11:43:18 PM UTC, comment #4:

Ctrl-<Keypad +> and Ctrl-+ (plus within normal keys) work both for me. On your notebook, don't you have an area in the right half of the keyboard (small symbols in the lower right of the keys) that mimics a keypad when Num-Lock is activated?

Torsten <ttl>
Project Member
Sat 08 Feb 2014 11:35:53 PM UTC, comment #3:

Ctrl-<Keypad +>? I'm on a laptop without a keypad keyboard at the moment. Ctrl-+ (== Ctrl-Shift-= on my US keyboard layout) does not zoom in for me.

Mike Miller <mtmiller>
Project Member
Sat 08 Feb 2014 11:32:18 PM UTC, comment #2:

Ctrl-+ is working for me as zoom in (ubuntu unity) but not the shortcut for restoring the size (Ctrl-keypad/).

Torsten <ttl>
Project Member
Sat 08 Feb 2014 10:44:55 PM UTC, comment #1:

Confirmed, but I think you mean zoom in (Ctrl-+) should be set, or both should be unset. Ctrl-- zooms out (makes the text smaller) but there is no way to zoom in (make text larger) or restore the default zoom level.

Mike Miller <mtmiller>
Project Member
Sat 08 Feb 2014 08:10:39 PM UTC, original submission:

or zoom-out should also be set
the former can be currently accessed via ctrl-minus (or ctrl-dash)
the latter would be accessible via ctrl-plus
SCI_ZOOMIN
SCI_ZOOMOut

Felipe G. Nievinski <fgnievinski>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #30637:  zoom.patch added by ttl (7kB - text/x-diff)
file #30502:  bug41516_01.patch added by ttl (7kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by ttl (Posted a comment)
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by fgnievinski (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 12 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 15 Mar 2014 08:15:26 PM UTCttlStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Sat 22 Feb 2014 12:02:20 PM UTCttlAttached File-=>Added zoom.patch, #30637
    Thu 13 Feb 2014 09:22:34 PM UTCttlStatusFixed=>In Progress
      Open/ClosedClosed=>Open
    Thu 13 Feb 2014 08:49:16 PM UTCttlStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Mon 10 Feb 2014 08:46:13 PM UTCttlStatusConfirmed=>Patch Submitted
    Mon 10 Feb 2014 08:45:10 PM UTCttlAttached File-=>Added bug41516_01.patch, #30502
    Sat 08 Feb 2014 10:44:55 PM UTCmtmillerItem GroupOther=>Feature Request
      StatusNone=>Confirmed
      Summaryeditor zoom-in keybinding should be unset=>GUI editor zoom in keybinding should be set

    Back to the top


    Powered by Savane 3.1-cleanup