bugGNU Octave - Bugs: bug #41476, listdlg() doesn't allow scrolling...

 
 

bug #41476: listdlg() doesn't allow scrolling in the window in CLI mode

Submitted by:  Colin Foster <cfoster>
Submitted on:  Thu 06 Feb 2014 12:04:54 AM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Feature Request
Status: FixedAssigned to: None
Originator Name: Colin FosterOpen/Closed: Closed
Release: 3.8.0Operating System: GNU/Linux

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 21 Mar 2014 04:09:12 AM UTC, comment #10:

I modified the changeset slightly. I replaced tabs with spaces and added "Colin Foster" to the list of Octave contributors that shows up in the manual. I also added a short explanation of what was done to each file in the changelog. The completed changeset was pushed to the gui-release branch here (http://hg.savannah.gnu.org/hgweb/octave/rev/56209bab4213).

Thanks for correcting this.

Rik <rik5>
Project Administrator
Mon 17 Mar 2014 04:17:49 PM UTC, comment #9:

@fgnievinski: I'm sorry! It seemed a trivial task indeed, but I did it as it was in the list. This one should be the only case of repetitions for the bugfixes I've submitted: I picked from the list just this one and 41796, where the only patch attached is mine (I've just checked).

Massimiliano Fasi <mfasi>
Mon 17 Mar 2014 03:45:32 PM UTC, comment #8:

@mfasi: we didn't anticipate bugs receiving duplicated fixes -- looks like we need to find more "easy bugs"! I'll remove this one from the list for now.

Felipe G. Nievinski <fgnievinski>
Mon 17 Mar 2014 02:45:16 PM UTC, comment #7:

It isn't different. It was supposed to be one of the Short Projects for GSoC students listed in that page. As far as I understood, it required just to modify the code, test the function and submit the changeset. Did I miss something?

Massimiliano Fasi <mfasi>
Mon 17 Mar 2014 01:40:57 PM UTC, comment #6:

@mfasi: how is your fix different from the one previously submitted by @cfoster, please?

Felipe G. Nievinski <fgnievinski>
Tue 04 Mar 2014 01:13:27 PM UTC, comment #5:

I have submitted a patch for this bug. As it is my first submission, can someone check whether I have made any mistake in the submission procedure?

Thank you.

Massimiliano Fasi <mfasi>
Tue 18 Feb 2014 11:46:18 PM UTC, comment #4:

I have attached the changes per the recommendation on the website. Please let me know if this is what you needed, as this is my first submission to this project.

Thank you.

Colin Foster <cfoster>
Sat 08 Feb 2014 11:25:58 PM UTC, comment #3:

Thanks for your bug report and finding a fix. Would you be able to provide this fix as a mercurial changeset so it can more easily be tested by others and applied to the repository? Preferably against the gui-release branch, I think that would be the most fitting for this fix.

Also updating the title to note that this is for CLI mode only, which uses the Java-based UI widgets. Qt widgets are used in the experimental GUI, and there a long list does scroll properly.

Mike Miller <mtmiller>
Project Member
Thu 06 Feb 2014 02:57:50 PM UTC, comment #2:

The last thing that I did was change the m_List.SetFont, setMinimumSize, setPreferredSize and setBorder all to scrollPane and everything seems to work as desired.

Colin Foster <cfoster>
Thu 06 Feb 2014 12:45:46 AM UTC, comment #1:

Fixed it!

diff octave-3.8.0.orig/scripts/java/org/octave/JDialogBox.java octave-3.8.0/scripts/java/org/octave/JDialogBox.java
553a554

> JScrollPane scrollPane = new JScrollPane();

554a556

> scrollPane.setViewportView(m_List);

571c573
< p.add (m_List, gbc);
---

> p.add (scrollPane, gbc);

Colin Foster <cfoster>
Thu 06 Feb 2014 12:04:54 AM UTC, original submission:

If I have a large list of names to be in the list dialog box
listdlg("ListString", {LargeList})
I am unable to scroll in this list, even though the data goes off the bottom of the page.

I'm sorry, I modified the file, but I think it was line 555 of JDialogBox.java

m_List = new JList (lst);

I tried
JScrollPane scrollPane = new JScrollPane();
m_List = new JList (lst);
scrollPane.setViewportView(m_List);

but that either didn't work or it didn't get implemented correctly.

I feel I was on the right path, just not quite there though.

Colin Foster <cfoster>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #30771:  listdlg.patch added by mfasi (1009B - text/x-patch - Patch to fix bug #41476 submitted)
file #30603:  changes2.diff added by cfoster (2kB - text/x-patch - The bug number has been added to the commit message.)
file #30602:  changes.diff added by cfoster (2kB - text/x-patch - Submitted update to fix allow dialog box scrolling capabilities.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by fgnievinski (Posted a comment)
  • -unavailable- added by mfasi (Updated the item)
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by cfoster (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 21 Mar 2014 04:09:12 AM UTCrik5StatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
    Tue 04 Mar 2014 12:56:16 PM UTCmfasiAttached File-=>Added listdlg.patch, #30771
    Wed 19 Feb 2014 12:25:21 AM UTCcfosterAttached File-=>Added changes2.diff, #30603
    Tue 18 Feb 2014 11:44:45 PM UTCcfosterAttached File-=>Added changes.diff, #30602
    Sat 08 Feb 2014 11:25:58 PM UTCmtmillerCategoryGUI=>Octave Function
      StatusNone=>Confirmed
      Summarylistdlg() doesn\'t allow scrolling in the window=>listdlg() doesn't allow scrolling in the window in CLI mode

    Back to the top


    Powered by Savane 3.1-cleanup