bugGNU Octave - Bugs: bug #41459, interp2 should ignore * method...

 
 

bug #41459: interp2 should ignore * method flag for faster interpolation

Submitted by:  Felipe G. Nievinski <fgnievinski>
Submitted on:  Tue 04 Feb 2014 07:52:35 PM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Matlab Compatibility
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 22 Mar 2014 09:31:54 PM UTC, comment #3:

I pushed a changeset that issues a warning if the '*' flag is used with interp2, interp3, and interpn (http://hg.savannah.gnu.org/hgweb/octave/rev/5cf9a02732b6).

Rik <rik5>
Project Administrator
Sun 23 Feb 2014 06:38:32 PM UTC, comment #2:

yes, all of them have it:

interp1(..., *METHOD)
interp2(..., *METHOD)
interp3(..., *METHOD)
interpn(..., *METHOD)

my patch reads:

Felipe G. Nievinski <fgnievinski>
Sun 23 Feb 2014 06:20:29 PM UTC, comment #1:

I see we do handle the "" modifier in the interp1 function already. So you're saying this should apply to interp2 as well? What about interp3 or interpn? I don't see any mention of the "" modifier on any of the Matlab help pages, is this an undocumented or legacy Matlab feature?

It would be good to patch all of them at once, and follow the pattern of interp1 even if we don't handle the flag for now to make it easier to compare all 4 functions. Something like this maybe? Completely untested:

Mike Miller <mtmiller>
Project Member
Tue 04 Feb 2014 07:52:35 PM UTC, original submission:

so that at least it runs code without modification.
patch attached.

Felipe G. Nievinski <fgnievinski>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #30458:  interp2.m.diff added by fgnievinski (202B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Updated the item)
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by fgnievinski (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 22 Mar 2014 09:31:54 PM UTCrik5StatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Fri 21 Mar 2014 01:39:31 AM UTCrik5StatusNeed Info=>Patch Submitted
    Sun 23 Feb 2014 06:20:29 PM UTCmtmillerCategoryNone=>Octave Function
      StatusNone=>Need Info
    Tue 04 Feb 2014 07:52:35 PM UTCfgnievinskiAttached File-=>Added interp2.m.diff, #30458

    Back to the top


    Powered by Savane 3.1-cleanup