bugGNU Octave - Bugs: bug #41298, pkg install: automatically extract...

 
 

bug #41298: pkg install: automatically extract %!tests and install both extracted and fixed test files

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Wed 22 Jan 2014 06:14:57 AM UTC  
 
Category: Configuration and Build SystemSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Feature Request
Status: Patch SubmittedAssigned to: None
Originator Name: Open/Closed: Open
Release: devOperating System: Any

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 01 Jul 2016 12:21:32 AM UTC, comment #3:

Oliver, I've made the changes that I suggested. However there were a few questions in my previous comment. If you have time, could you please reply to them?

(file #37638)

Lachlan Andrew <lachlan>
Project Member
Thu 30 Jun 2016 12:41:27 PM UTC, comment #2:

Oliver, I've had a quick look at the code, and have some initial comments. I'll try to review it properly soon.

Why do you not overwrite existing tests? ("if (exist (full_tst_file)), continue, endif") This may make it hard for someone who is trying to tweak the tests. Most make processes just overwrite existing files.

I like it when automatically generated files say both the source they were generated from and also the program that did the generation.

In the change to test.m, why do you add ".cc-tst" but not ".tst"?

The commit message should start with a summary line that doesn't start with "* <filename>", but summarises the change and mentions the bug number. This also applies to the patch for bug #41215.

Some trivial points are:
- the first hunk has indentation of four spaces instead of two.
- When {...} is used to denote a subscript, I think the coding standard says there shouldn't be a space before {.
- Why do you use "not ()" instead of "!"?

Lachlan Andrew <lachlan>
Project Member
Thu 19 Feb 2015 01:13:30 PM UTC, comment #1:

Please review the attached patch file. Another patch is posted in bug #41215.

(file #33131)

Oliver Heimlich <oheim>
Wed 22 Jan 2014 06:14:57 AM UTC, original submission:

When Forge packages are built and installed using the pkg command, %!tests in source files should be extracted and installed along with the rest of the package. Currently, only the compiled .oct files are copied into the package install location, so any %!tests that are in .c or .cc files are not available at runtime. These tests should be extracted into tst files.

Secondly, any additional tests that are not necessarily associated with a particular class or function could be maintained in .tst files. Taken together, both extracted tst files and maintained fixed .tst scripts should be installed into the package directory so they can be run any time, just like tests in m-files.

This brings the handling of tests in Forge packages more in line with what Octave now does with its own %!tests.

This feature request is based on Carlo's comments in bug #41215, which doesn't strictly depend on this being fixed first, but will certainly benefit from having more tests runnable after a package is installed.

Mike Miller <mtmiller>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #33131:  octave-bug-41298.patch added by oheim (3kB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by lachlan (Updated the item)
  • -unavailable- added by oheim (Updated the item)
  • -unavailable- added by svillemot
  • -unavailable- added by mtmiller (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 01 Jul 2016 12:21:32 AM UTClachlanAttached File-=>Added bug_41298_pkg_install_tests.v1.cset, #37638
    Wed 29 Jun 2016 12:00:05 AM UTClachlanStatusNone=>Patch Submitted
    Thu 19 Feb 2015 01:13:30 PM UTCoheimAttached File-=>Added octave-bug-41298.patch, #33131
    Wed 05 Feb 2014 10:45:59 AM UTCsvillemotCarbon-Copy-=>Added svillemot

    Back to the top


    Powered by Savane 3.1-cleanup