bugGNU Octave - Bugs: bug #40895, Being less strict about three test...

 
 

bug #40895: Being less strict about three test failures in conv2.cc ?

Submitted by:  Pascal Dupuis <cdemills>
Submitted on:  Sat 14 Dec 2013 11:56:13 AM UTC  
 
Category: LibrariesSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Inaccurate Result
Status: DuplicateAssigned to: None
Originator Name: Pascal DupuisOpen/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 14 Dec 2013 05:56:04 PM UTC, comment #1:

That's because of bug #39314. We should have exactly the same values, since the shape option should be equivalent to trim the output. A proper solution has been suggested on that bug, get an offset for the different shape options which would also get us rid of extra code and simplify the whole convn. As this has been discussed on that bug, I'll mark this as duplicate.

Carnë Draug <carandraug>
Project Member
Sat 14 Dec 2013 11:56:13 AM UTC, original submission:

Hello,

while looking at the known test failures, I found three occurences in conv2.cc. The comments state that there are two computation paths, with different ordering of multiplications and summation. Truncation errors accumulate in the order of tens of epsilon. I propose a patch to make the disregard this truncation error and remove this known failure.

Patch included

Regards

Pascal

Pascal Dupuis <cdemills>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #29919:  conv2.cc.diff added by cdemills (2kB - text/x-patch)

 

Digest:
   bug dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cdemills (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 14 Dec 2013 05:56:04 PM UTCcarandraugStatusNone=>Duplicate
      Open/ClosedOpen=>Closed
      Dependencies-=>Depends on bugs #39314
    Sat 14 Dec 2013 11:56:13 AM UTCcdemillsAttached File-=>Added conv2.cc.diff, #29919

    Back to the top


    Powered by Savane 3.1-cleanup