bugGNU Octave - Bugs: bug #40895, Being less strict about three test...

 
 

bug #40895: Being less strict about three test failures in conv2.cc ?

Submitter:  Pascal Dupuis <cdemills>
Submitted:  Sat 14 Dec 2013 11:56:13 AM UTC
 
Category:  Libraries Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Inaccurate Result
Status:  Duplicate Assigned to:  None
Originator Name:  Pascal Dupuis Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

Sat 14 Dec 2013 05:56:04 PM UTC, comment #1: 

That's because of bug #39314. We should have exactly the same values, since the shape option should be equivalent to trim the output. A proper solution has been suggested on that bug, get an offset for the different shape options which would also get us rid of extra code and simplify the whole convn. As this has been discussed on that bug, I'll mark this as duplicate.

Carnë Draug <carandraug>
Project Member
Sat 14 Dec 2013 11:56:13 AM UTC, original submission:  

Hello,

while looking at the known test failures, I found three occurences in conv2.cc. The comments state that there are two computation paths, with different ordering of multiplications and summation. Truncation errors accumulate in the order of tens of epsilon. I propose a patch to make the disregard this truncation error and remove this known failure.

Patch included

Regards

Pascal

Pascal Dupuis <cdemills>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #29919:  conv2.cc.diff added by cdemills (2KiB - text/x-patch)

 

Digest:
   bug dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by cdemills (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only project members can vote.

     

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-12-14 carandraug StatusNone Duplicate
        Open/ClosedOpen Closed
        Dependencies- Depends on bugs #39314
    2013-12-14 cdemills Attached File- Added conv2.cc.diff, #29919

    Back to the top

    Powered by Savane 3.10