bugGNU Octave - Bugs: bug #40514, Release Notes window is always...

 
 

bug #40514: Release Notes window is always opened too small

Submitter:  Rik <rik5>
Submitted:  Thu 07 Nov 2013 06:32:52 PM UTC
   
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Feature Request
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Sat 09 Nov 2013 05:39:13 PM UTC, comment #6: 

I checked in a changeset that works for me, based on your adjustSize call (http://hg.savannah.gnu.org/hgweb/octave/rev/e0495a8c1b5d).

Rik <rik5>
Group administrator
Fri 08 Nov 2013 03:44:48 AM UTC, comment #5: 

This gets it close:


browser->document()->adjustSize();
release_notes_window->resize (browser->document()->size().toSize());


John Donoghue <lostbard>
Group Member
Thu 07 Nov 2013 10:45:59 PM UTC, comment #4: 

I tried using release_note_window->sizeHint but that  gives the same small window as before.

Rik <rik5>
Group administrator
Thu 07 Nov 2013 09:54:18 PM UTC, comment #3: 

That should be:


release_notes_window->resize (release_notes_window->sizeHint ());


Otherwise it would be using the mainwindow size.

John Donoghue <lostbard>
Group Member
Thu 07 Nov 2013 09:26:17 PM UTC, comment #2: 

I pushed your changeset to have only one Release Notes window here (http://hg.savannah.gnu.org/hgweb/octave/rev/3851e5fde76d).  What about the size of the window?  I tried adding


release_notes_window->resize (sizeHint ());


but this produced a window that was too large horizontally.  This works okay for me, but I'm not sure it is best practice to hardcode these things.


release_notes_window->resize (615, 500);



Rik <rik5>
Group administrator
Thu 07 Nov 2013 08:08:31 PM UTC, comment #1: 

likewise, selecting the menu multiple times results in multiple release note windows.
Patch to fix the multiple windows is attached - I was going to push it when I got home.


(file #29565)

John Donoghue <lostbard>
Group Member
Thu 07 Nov 2013 06:32:52 PM UTC, original submission:  

If I use the menu entry News->Release Notes, the window is always opened in the lower right-hand corner of the screen and it is small.  I can, of course, resize it.  But this setting is also not remembered between Octave runs.  I think it would be best to just make the window larger when it is constructed.

Rik <rik5>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #29565:  single-release.patch added by lostbard (4KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by lostbard (Updated the item)
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-11-09 rik5 StatusNone Fixed
        Open/ClosedOpen Closed
    2013-11-07 lostbard Attached File- Added single-release.patch, #29565

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code