bugGNU Octave - Bugs: bug #40360, Incorrect test for unordered_map...

 
 

bug #40360: Incorrect test for unordered_map in configure.ac

Submitter:  None
Submitted:  Thu 24 Oct 2013 09:58:39 AM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Dan Gordon Originator Email:  -email is unavailable-
Open/Closed:  * Closed Release:  * 3.6.4
Operating System:  * Mac OS Fixed Release:  None
Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 24 Oct 2013 07:21:53 PM UTC, comment #2: 

Sorry, I should have checked the source code before I spoke. This fix is already present in the development sources.

http://hg.savannah.gnu.org/hgweb/octave/file/ef7e97c91006/m4/acinclude.m4#l2042

We should make a new Octave release next month, according to plan:

http://wiki.octave.org/Release_3.8

Jordi GutiƩrrez Hermoso <jordigh>
Group Member
Thu 24 Oct 2013 07:19:08 PM UTC, comment #1: 

Thanks, you are indeed correct. Would you be ok with being credited as "Dan Gordon <dexter.urbane@gmail.com>" for this fix?

Jordi GutiƩrrez Hermoso <jordigh>
Group Member
Thu 24 Oct 2013 09:58:39 AM UTC, original submission:  

I ran into problems building Octave using homebrew on mac osx 10.9. The problem boiled down to the fact that the test for unordered map in configure.ac omitted the template parameters, and thus the test failed for the wrong reason. Rather than describing the problem in detail, I'll submit the following patch for configure.ac, which should hopefully be self explanatory.

Thanks!


--- ../octave-3.6.4.ORIG/configure.ac        2013-10-24 20:16:51.000000000 +1100
+++ configure.ac        2013-10-24 20:43:28.000000000 +1100
@@ -1605,7 +1605,7 @@
     AC_LANG_PROGRAM([
       #include <unordered_map>
     ], [
-      std::unordered_map m;
+      std::unordered_map<char, char> m;
     ])], [], [unordered_map_requires_tr1_namespace=yes])
 elif test "$ac_cv_header_tr1_unordered_map" = "yes"; then
   unordered_map_requires_tr1_namespace=yes


Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jordigh (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-10-24 jordigh StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code