bugGNU Octave - Bugs: bug #40283, Linux - no window control buttons...

 
 

bug #40283: Linux - no window control buttons on undocked panes

Submitter:  Philip Nienhuis <philipnienhuis>
Submitted:  Wed 16 Oct 2013 06:08:00 PM UTC
   
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  Fixed Assigned to:  None
Originator Name:  Phiilp Nienhuis Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Fri 18 Oct 2013 06:49:22 PM UTC, comment #11: 

Yes, even with your patch, the undocked window does not have a title bar, the only the difference is, that you at least can move and resize it...
I think this is some kind of KDE bug.
I wonder what it takes to reproduce this to file a proper bug report to the KDE team...
Anyways, I like the patch, because at least the window now remembers where it came from.

Thorsten Liebig <thorsten>
Fri 18 Oct 2013 06:07:10 PM UTC, comment #10: 
Torsten Lilge <ttl>
Group Member
Fri 18 Oct 2013 05:38:06 PM UTC, comment #9: 

Philip, from what you and Thorsten have reported I guess that in KDE the floating widgets still have no "real" title bars like normal windows? Then, the dock-widget title bar when docked is the only title bar when floating, too? In Ubuntu, a real title bar from the window manager is added on top of this qt title bar when floating (attached a screenshot of the editor).

The two buttons are not from the window style but from qt.

I will push the patch and close this report.


Torsten Lilge <ttl>
Group Member
Fri 18 Oct 2013 04:41:46 PM UTC, comment #8: 

OK Torsten,

works fine for me in Windows and Linux.

But in Linux (Mageia 2, KDE, Air theme), either
- clicking the button to the left of the close button (doesn't match my desktop theme, so I wouldn't know what is stands for), or
- double-clicking the title bar,

docks/undocks the pane; double-clicking the main menu bar of a pane does nothing.

I'd say just push as it is better than it used to be; ironing out the rest can be done in 3.8.1 or 3.8.2 or whatever.

Philip Nienhuis <philipnienhuis>
Group Member
Thu 17 Oct 2013 07:25:03 PM UTC, comment #7: 

In Ubuntu the floating widgets do have a maximize button which behaves as expected. Double-clicking in the title bar maximizes too while doule-clicking in the additional "sub"title-bar of the widgets docks or undocks the widget.

Torsten Lilge <ttl>
Group Member
Thu 17 Oct 2013 07:05:20 PM UTC, comment #6: 

Well it does what it is supposed to do.
With the patch I can move and resize the undocked windows again.

What I don't like with this patch (in comparison) is that the Qt default undocked windows don't have a maximize button and behave kind of strange if maximized from the task-panel context menu...
That is, you can still move them, but they are still registered as maximized.. something is really broken with Qt and KDE... I can only hope they fix all this with KDE5 and Qt5...

Does anyone else see this with the patch applied? E.g. on Gnome?

Thorsten Liebig <thorsten>
Thu 17 Oct 2013 04:45:53 PM UTC, comment #5: 

You are right, a third of the patch is missing. Sorry!
Attached the correct patch.

(file #29392)

Torsten Lilge <ttl>
Group Member
Thu 17 Oct 2013 07:19:55 AM UTC, comment #4: 

Hi Torsten,

I'm unable to test your patch.
I get this error message:

../../octave/libgui/src/octave-dock-widget.cc:155:0: error: unterminated #if
../../octave/libgui/src/octave-dock-widget.cc: In member function 'void octave_dock_widget::make_window()':
../../octave/libgui/src/octave-dock-widget.cc:154:1: error: expected '}' at end of input


If I look at the patch, I can see a #if at the end but no #endif. It looks like something is missing..


Thorsten Liebig <thorsten>
Wed 16 Oct 2013 09:32:10 PM UTC, comment #3: 

Yes, the drawbacks on windows would remain but I agree that this is much more usable than the floating widgets on top of the main window.

Torsten Lilge <ttl>
Group Member
Wed 16 Oct 2013 09:05:58 PM UTC, comment #2: 

You mean, on Windows the re-docking keeps a few rough edges?
Maybe other (non-dev) Windows users will complain when 3.8 is released; but I think there is no time now to do any better.
I can live with it for now; for me it revolves around the editor, and I find octave's re-/undocking/restarting behavior quite acceptable (the docked editor's size & position is restored to the last undocked state, also when restarting Octave. That's just a matter of one mouse click).

The underlying bug (undocked panes always on top on Windows) was much more annoying (IMO at least).

Hopefully tomorrow I can try the patch on Windows. Other Linux users might beat me as far as Linux goes.

Thanks!

Philip Nienhuis <philipnienhuis>
Group Member
Wed 16 Oct 2013 07:04:50 PM UTC, comment #1: 

The actual method for floating dock widgets was only implemented to enable floating widgets in windows that do not always stay on top of the main window and that appear in the task switcher and task manager. The drawbacks of this solution are (on all systems): (un-)docking does not work by mouse dragging anymore (for qt, the widgets can't float) and re-docking does not restore the widget's old position. Considering this bug report I doubt if it is worth to keep this actual method.

I therefore have prepared a patch that re-implements the old method for Mac- and *ix-systems but leaves the actual method for windows systems (untested in windows yet).

(file #29390)

Torsten Lilge <ttl>
Group Member
Wed 16 Oct 2013 06:08:00 PM UTC, original submission:  

On my Linux box (mageia 2, KDE) undocked Octave GUI panes have no window control buttons (e.g., minimize, hide, move to other desktop, etc. In fact, compared to Windows, the entire title bar is missing.

As a consequence I cannot resize or move undocked panes. Only the editor pane can be moved around (but not resized), by dragging on the main menu bar ("File Edit Debug Run Help"), that's the only place susceptible for dragging the editor pane around.

See this discussion (the technical part starts with this post):

https://mailman.cae.wisc.edu/pipermail/octave-maintainers/2013-October/036810.html

Philip Nienhuis <philipnienhuis>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #29408:  editor.png added by ttl (13KiB - image/png)
file #29392:  floating_widgets_02.diff added by ttl (4KiB - text/x-diff)
file #29390:  floating_widgets.diff added by ttl (3KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ttl (Updated the item)
  • -email is unavailable- added by philipnienhuis (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-10-18 ttl StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2013-10-18 ttl Attached File- Added editor.png, #29408
    2013-10-17 ttl Attached File- Added floating_widgets_02.diff, #29392
    2013-10-16 philipnienhuis StatusNone Patch Submitted
    2013-10-16 ttl Attached File- Added floating_widgets.diff, #29390

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code