bugGNU Octave - Bugs: bug #39725, OpenBSD build failure with gnulib...

 
 

bug #39725: OpenBSD build failure with gnulib sys/time.h

Submitter:  Mike Miller <mtmiller>
Submitted:  Thu 08 Aug 2013 03:41:34 AM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  mtmiller
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * BSD
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 19 Aug 2013 12:19:25 PM UTC, comment #4: 

Ok, thanks for the tip. Done and pushed:

http://hg.savannah.gnu.org/hgweb/octave/rev/eb8bf49780fb

Building a dist tarball to test on OpenBSD VM again, this should now build cleanly.

Mike Miller <mtmiller>
Group Member
Tue 13 Aug 2013 01:25:32 PM UTC, comment #3: 


> If someone can update the gnulib-hg mirror for Octave (I don't think I can),


Yes you can. Just pull from here:

    http://hg.octave.org/gnulib

Jordi GutiƩrrez Hermoso <jordigh>
Group Member
Tue 13 Aug 2013 12:42:10 PM UTC, comment #2: 

This bug has been fixed upstream with this change:

http://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=dc6d2b5b3652b68d4c62a3875c6960a473b4eaea

I got a successful build of Octave on OpenBSD (and Debian) using gnulib at the following commit, which is a few changes later and the current HEAD revision:

http://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=3f5bf99e1290a6b46133385cc7c7515f96f4098b

If someone can update the gnulib-hg mirror for Octave (I don't think I can), we can update our pointer to use gnulib at the first commit listed above or newer.

Mike Miller <mtmiller>
Group Member
Fri 09 Aug 2013 03:12:20 PM UTC, comment #1: 
Mike Miller <mtmiller>
Group Member
Thu 08 Aug 2013 03:41:34 AM UTC, original submission:  

Two files fail to compile on OpenBSD 5.3 due to errors from the gnulib sys/time.h include file. This is almost certainly an upstream gnulib bug and I will report it there when I have a minimal example, but reporting here to track it for Octave as well.

liboctave/system/oct-time.cc:


In file included from ../libgnu/sys/select.h:86,
                 from /usr/include/sys/types.h:221,
                 from ../libgnu/sys/types.h:27,
                 from /usr/include/sys/time.h:38,
                 from ../libgnu/sys/time.h:38,
                 from ../../liboctave/system/oct-time.cc:31:
../libgnu/sys/time.h:419: error: '::gettimeofday' has not been declared
In file included from /usr/include/sys/types.h:221,
                 from ../libgnu/sys/types.h:27,
                 from /usr/include/sys/time.h:38,
                 from ../libgnu/sys/time.h:38,
                 from ../../liboctave/system/oct-time.cc:31:
../libgnu/sys/select.h:597: error: invalid conversion from 'int (*)(int, fd_set*, fd_set*, fd_set*, timeval*)' to 'int (*)(int, fd_set*, fd_set*, fd_set*, gnulib::timeval*)'
../../liboctave/system/oct-time.cc: In member function 'void octave_time::stamp()':
../../liboctave/system/oct-time.cc:88: error: cannot convert 'timeval*' to 'gnulib::timeval*' in argument passing




libinterp/corefcn/getrusage.cc:


In file included from ../libgnu/sys/select.h:86,
                 from /usr/include/sys/types.h:221,
                 from ../libgnu/sys/types.h:27,
                 from /usr/include/sys/time.h:38,
                 from ../libgnu/sys/time.h:38,
                 from ../../libinterp/corefcn/getrusage.cc:27:
../libgnu/sys/time.h:419: error: '::gettimeofday' has not been declared
In file included from /usr/include/sys/types.h:221,
                 from ../libgnu/sys/types.h:27,
                 from /usr/include/sys/time.h:38,
                 from ../libgnu/sys/time.h:38,
                 from ../../libinterp/corefcn/getrusage.cc:27:
../libgnu/sys/select.h:597: error: invalid conversion from 'int (*)(int, fd_set*, fd_set*, fd_set*, timeval*)' to 'int (*)(int, fd_set*, fd_set*, fd_set*, gnulib::timeval*)'




The attached patch is a hack that gets around both of these compilation failures and the rest of Octave compiles successfully.

Mike Miller <mtmiller>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jordigh (Posted a comment)
  • -email is unavailable- added by mtmiller (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-08-19 mtmiller StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2013-08-09 mtmiller StatusNone In Progress
        Assigned toNone mtmiller
    2013-08-08 mtmiller Attached File- Added octave-openbsd-sys-time.patch, #28791

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code