bugGNU Octave - Bugs: bug #39149, uixxx not working

 
 

bug #39149: uixxx not working

Submitter:  Doug Stewart <dastew>
Submitted:  Mon 03 Jun 2013 01:55:28 PM UTC
   
 
Category:  Plotting Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Doug Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Mon 20 Jan 2014 12:32:11 AM UTC, comment #10: 

There were a few OSX specific rendering problems with the FLTK toolkit.  We fixed the others, but I forgot about this one.  I just tried "demo uimenu 1", and it is now working for me.

Looks ok to close to me.

Ben Abbott <bpabbott>
Group Member
Sun 19 Jan 2014 07:22:51 PM UTC, comment #9: 

Is comment #8 (menubar obscured on MacOSX) the only remaining issue on this bug report?

I get a working "demo uimenu" on both Linux and WinXP with 3.8.0.

Mike Miller <mtmiller>
Group Member
Sat 27 Jul 2013 01:43:11 PM UTC, comment #8: 

On MacOSX, the menubar is now visible for a figure with not axes objects (see the attached MacOSX-no-axes.png).

When an axes object is added the menubar is obscured (see MacOSX-with-axes.png)


Ben Abbott <bpabbott>
Group Member
Thu 25 Jul 2013 04:04:49 PM UTC, comment #7: 
Ben Abbott <bpabbott>
Group Member
Thu 25 Jul 2013 11:25:24 AM UTC, comment #6: 

Yes, I think the patch is OK.

Michael Goffioul <goffioul>
Thu 25 Jul 2013 09:26:16 AM UTC, comment #5: 

Michael,

Is your proposed patch in comment #3 ok to push (i.e. is it a partial solution or might in conflict with the proper solution?)?

Ben

Ben Abbott <bpabbott>
Group Member
Tue 11 Jun 2013 07:52:52 PM UTC, comment #4: 

Though I've the impression that the remaining problem is an clash between the default menus and the custom-created menus (and the way FLTK menus are implemented).

One way to guess what's going on is:

demo uimenu
h = findall (gcf, 'type', 'uimenu')
get (h, 'fltk_label')


Michael Goffioul <goffioul>
Tue 11 Jun 2013 07:46:50 PM UTC, comment #3: 

This patch partially solve the problem. Now menus appear correctly, but the uidemo still doesn't work as expected: the custom-created "File" and "Edit" menus are empty.


diff -r 13b3b92ea99c libinterp/dldfcn/__init_fltk__.cc
--- a/libinterp/dldfcn/__init_fltk__.cc Fri May 24 15:41:52 2013 -0400
+++ b/libinterp/dldfcn/__init_fltk__.cc Tue Jun 11 15:43:48 2013 -0400
@@ -1845,7 +1845,18 @@
   bool is_valid (void) const { return true; }

   bool initialize (const graphics_object& go)
-    { return go.isa ("figure"); }
+    {
+      if (go.isa ("figure")
+          || go.isa ("uimenu"))
+        {
+          if (go.isa ("uimenu"))
+            update (go, uimenu::properties::ID_LABEL);
+
+          return true;
+        }
+
+      return false;
+    }

   void finalize (const graphics_object& go)
   {


Michael Goffioul <goffioul>
Tue 11 Jun 2013 07:16:08 PM UTC, comment #2: 

I "bisect"ed the problem to rev. 834f904a3dcb:
http://hg.savannah.gnu.org/hgweb/octave/rev/834f904a3dcb

"Add support for full asynchronous graphics toolkit running in a separate thread. Add uicontrol and uipanel implementation."

It will take some time until I can write a patch for this.
Regards, Andy

Andreas Weber <andy1978>
Group Member
Tue 04 Jun 2013 07:42:40 PM UTC, comment #1: 

I can confirm that this problem also exists in default (a71a784c7611+ tip) since some months: http://octave.1599824.n4.nabble.com/demo-uimenu-in-development-branch-td4652445.html

I've tried to debug this with graphics_toolkit fltk.
In _init_fltk_.cc add_entry, fltk_label = uimenup.get_fltk_label (); returns an empty string when adding entries but they aren't added 'cause the empty label. This is the reason why uimenu->items_to_show () returns 0 and hide_menubar (); is called.

I tried to figure out why the label is empty and stepped until graphics.cc set_value_or_default. There are poperties "label" and "fltk_label" in graphics.in.h and label is called even when the graphics_toolkit is fltk. I'll try to digg further into this if I have more time.

Regards, Andy

Andreas Weber <andy1978>
Group Member
Mon 03 Jun 2013 01:55:28 PM UTC, original submission:  

Demo uimenu does not work in 3.6.4 and default.


Doug Stewart <dastew>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #28671:  MacOSX-no-axes.png added by bpabbott (43KiB - image/png)
file #28672:  MacOSX-with-axes.png added by bpabbott (41KiB - image/png)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by bpabbott (Posted a comment)
  • -email is unavailable- added by andy1978 (Posted a comment)
  • -email is unavailable- added by dastew (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-01-20 mtmiller StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2014-01-19 mtmiller CategoryNone Plotting
    2013-07-27 bpabbott Attached File- Added MacOSX-no-axes.png, #28671
        Attached File- Added MacOSX-with-axes.png, #28672
    2013-07-25 bpabbott StatusNone Ready For Test
        Release3.6.4 dev
        Operating SystemGNU/Linux Any

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code