bugGNU Octave - Bugs: bug #38590, Feature request for editor go to...

 
 

bug #38590: Feature request for editor go to line

Submitter:  John Donoghue <lostbard>
Submitted:  Mon 25 Mar 2013 11:27:14 PM UTC
   
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Feature Request
Status:  Fixed Assigned to:  None
Originator Name:  John Donoghue Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 28 Mar 2013 04:43:41 PM UTC, comment #4: 

pushed with changeset
http://hg.savannah.gnu.org/hgweb/octave/rev/f482302d81c9

Thanks for the patch

Torsten Lilge <ttl>
Group Member
Wed 27 Mar 2013 12:40:35 AM UTC, comment #3: 

Updated patch attached

John Donoghue <lostbard>
Group Member
Tue 26 Mar 2013 05:02:21 PM UTC, comment #2: 

John, thanks for the patch. It looks good, but the patch file is incomplete: It starts with

@@ -41,6 +41,7 @@

and the three lines

diff ...
--- ...
+++ ...

at the beginning are missing.

I suggest to call the menu entry "Goto Line", what do you think?

Torsten Lilge <ttl>
Group Member
Tue 26 Mar 2013 12:31:15 PM UTC, comment #1: 

The patch looks good. Would it be too cumbersome for you to provide a commit message following these guidelines? Do "hg log -v" to get examples of the kind of commit messages that we write.

http://wiki.octave.org/Commit_message_guidelines

Jordi GutiƩrrez Hermoso <jordigh>
Group Member
Mon 25 Mar 2013 11:27:14 PM UTC, original submission:  

The editor has no easy way to go to a specific line except to scroll down to the required position.

A menu could easily be added to the editor to provide this ability.

John Donoghue <lostbard>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #27700:  gotoline.diff added by lostbard (5KiB - text/x-patch - Updated patch as "Goto Line" and added commit message)
file #27688:  38590_goto_line.patch added by lostbard (4KiB - text/x-patch - Goto line dialog/ editor menu option patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by jordigh (Posted a comment)
  • -email is unavailable- added by lostbard (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-03-28 ttl StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2013-03-27 lostbard Attached File- Added gotoline.diff, #27700
    2013-03-26 jordigh StatusNone Patch Submitted
    2013-03-25 lostbard Attached File- Added 38590_goto_line.patch, #27688

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code