bugGNU Octave - Bugs: bug #38074, maketform : transform matrices...

 
 

bug #38074: maketform : transform matrices inverted

Submitted by:  Pantxo Diribarne <pantxo>
Submitted on:  Sun 13 Jan 2013 07:59:09 PM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: Carnë Draug <carandraug>
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 14 Jan 2013 04:33:57 PM UTC, comment #3:

You're right. I have removed the superfluous call to tolower. I had also added one to maketform.

Carnë

Carnë Draug <carandraug>
Project MemberIn charge of this item.
Mon 14 Jan 2013 04:23:22 PM UTC, comment #2:

I have also seen this error when using npt>~30000 in projective transform test (the error was in svd function), and that is why I chose npt=10000 instead of 100000 as for the other tests. If the error you obtain is also in svd, you just have to put npt=1000 or so.

I wrote those tests on a fairly recent 64 bit linux box where the only one that occasionnally fails is the polynomial ord = 4.
Now on a 64bit MacBook Pro some other tests occasionnally fail. I will have to dig into this. Is mldivide supposed to behave differently from one platform to another?

About the "tolower" you added : it is unusefull as "ttype" is always lowercased at line 133. We should remove one of theim.

Pantxo Diribarne <pantxo>
Project Member
Mon 14 Jan 2013 02:55:33 PM UTC, comment #1:

I have applied your patch. Thank you.

Also made a small changes so that the functions are not case-sensitive about the function name (use tolower around the option name to start the switch block).

I tried to run the tests you wrote for cp2tform, to make sure my changes did not break anything but I get a memory exausted error or requested size too large (my system is 32bit). Would it be possible to write some smaller tests? If not, would it be possible to have different tests depending on the system?

Carnë Draug <carandraug>
Project MemberIn charge of this item.
Sun 13 Jan 2013 07:59:09 PM UTC, original submission:

In the developement veresion of image package, the following code should return 1 :

maketform actually stores A in T.tdata.Tinv. I have attached a changeset that fixes this behaviours and makes subsequent changes in cp2tform.m

Pantxo Diribarne <pantxo>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #27252:  maketf_diff.patch added by pantxo (3kB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pantxo (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 26 Oct 2013 09:29:11 AM UTCcarandraugOpen/ClosedOpen=>Closed
    Mon 14 Jan 2013 02:55:33 PM UTCcarandraugStatusNone=>Fixed
      Assigned toNone=>carandraug
    Sun 13 Jan 2013 07:59:09 PM UTCpantxoAttached File-=>Added maketf_diff.patch, #27252

    Back to the top


    Powered by Savane 3.1-cleanup