bugGNU Octave - Bugs: bug #37756, powerset: typo on error message...

 
 

bug #37756: powerset: typo on error message and doesn't return cell array when set is empty [with patch]

Submitted by:  Carnë Draug <carandraug>
Submitted on:  Thu 15 Nov 2012 11:08:24 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalItem Group: None
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 28 Nov 2012 07:17:02 PM UTC, comment #1:

Pulled and merged:

http://hg.savannah.gnu.org/hgweb/octave/graph/310db14aa605

Jordi Gutiérrez Hermoso <jordigh>
Project Administrator
Thu 15 Nov 2012 11:08:24 PM UTC, original submission:

powerset should always returns a cell array but returns an empty matrix if the input set is empty.

Also, the error message for checking the second argument is the word "rows" is also incorrect, and mentions "third" argument.

My patch fixes this two things, furthers the documentation (which at the moment is a single line without explanation of the rows option), adds 2 more tests (one for empty set and another for the use of the rows option) and one more input check that cell arrays can only be used with cell array of strings.

Please pull changeset 9671baab36c4 from https://bitbucket.org/carandraug/octave/

Carnë

Carnë Draug <carandraug>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jordigh (Updated the item)
  • -unavailable- added by carandraug (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 28 Nov 2012 07:17:02 PM UTCjordighStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Fri 16 Nov 2012 01:51:10 PM UTCjordighStatusNone=>Patch Submitted

    Back to the top


    Powered by Savane 3.1-cleanup