bugGNU Octave - Bugs: bug #35418, strread.m bugs (missing...

 
 

bug #35418: strread.m bugs (missing ";" / undue parse errors / code cleanup)

Submitter:  Philip Nienhuis <philipnienhuis>
Submitted:  Tue 31 Jan 2012 09:55:29 PM UTC
   
 
Category:  Interpreter Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  None
Originator Name:  Philip Nienhuis Open/Closed:  * Closed
Release:  * 3.6.0 Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 02 Feb 2012 06:47:43 PM UTC, comment #1: 

I applied your patch to the stable branch which will become 3.6.1 very shortly.

Rik <rik5>
Group administrator
Tue 31 Jan 2012 09:55:29 PM UTC, original submission:  

1. In some corner cases, strread.m echoed intermediate data due to a missing ";" at L.673.

2. I fixed a few instances where strread didn't adequately check array bounds in Ls. 442-506. This led to undue messages about "unable to parse file with given format string").

3. Those instances + a few more (7 in total) contained identical code => I moved this code elsewhere and replaced it by a boolean flag in the 7 instances.
Indentation in this area fixed as well.

All tests pass (also for textscan & textread)

Patch attached.
(Sorry no changeset, my Windows XP build system got fubarred lately, had to re-install and I'm still installing loads of SW.)

Suggested text for changeset:

  • fixed missing ";"
  • fixed array bound checking in lines 442-506
  • code cleanup


Philip Nienhuis <philipnienhuis>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #24945:  strread-3.6.0.diff added by philipnienhuis (4KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by philipnienhuis (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-02-02 rik5 StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2012-01-31 philipnienhuis Attached File- Added strread-3.6.0.diff, #24945

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code