bugGNU Octave - Bugs: bug #34389, demo ("loglog", 2) fails...

 
 

bug #34389: demo ("loglog", 2) fails for gnuplot toolkit

Submitter:  Rik <rik5>
Submitted:  Mon 26 Sep 2011 05:35:50 PM UTC
   
 
Category:  Plotting with OpenGL Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  bpabbott
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Tue 01 Nov 2011 09:33:46 PM UTC, comment #7: 

I pushed the proposed changeset.

http://hg.savannah.gnu.org/hgweb/octave/rev/bebd3ae908cb

and a second changeset to improve upon the semilog{x,y} demos.

http://hg.savannah.gnu.org/hgweb/octave/rev/d67c8bf52e20

Ben Abbott <bpabbott>
Group Member
Tue 01 Nov 2011 04:04:46 PM UTC, comment #6: 

Ben,
The changeset you posted works for me.  I'd go ahead and commit it.

This is just an aside.  To test your patch I ran the demos for loglog, semilogx, and semilogy.  It seems like tests for semilogy were cut and pasted from semilogx and the actual labeling of the graphs is incorrect.

Rik <rik5>
Group administrator
Tue 01 Nov 2011 12:22:38 PM UTC, comment #5: 

I've attached a changeset. I've made a few silly mistakes trying to get this right.  Can someone look this over for me to be sure I don't mess it up a 3rd time?

I"ve attached a changeset.

(file #24264)

Ben Abbott <bpabbott>
Group Member
Tue 01 Nov 2011 11:50:11 AM UTC, comment #4: 

I think FLTK is now behaving correctly. The 2nd demo for loglog is


 clf ();
 a = logspace (-5, 1, 10);
 b =-logspace (-5, 1, 10);

 subplot (1, 2, 1)
 loglog (a, b)
 xlabel ('loglog (a, b)')

 subplot (1, 2, 2)
 loglog (a, abs (b))
 set (gca, 'ydir', 'reverse')
 xlabel ('loglog (a, abs (b))')


For subplot (1,2,2) the ydir is "reverse". Thus, the values are min at the top (1e-5) and max at the bottom (1e1). For subplot (1,2,1) the min value is at the bottom (-1e1) and max at the top (-1e-5).

I've attached the result from ML R2011b.

(file #24263)

Ben Abbott <bpabbott>
Group Member
Tue 01 Nov 2011 04:26:27 AM UTC, comment #3: 

Is it really fixed for FLTK?  In previous version of Octave using gnuplot the first subplot on the left has the line running from the lower left to the upper right.

At least now the FLTK toolkit produces two subplots, but they are identical with the line being drawn from the upper left to the lower right.

Rik <rik5>
Group administrator
Mon 31 Oct 2011 11:55:37 PM UTC, comment #2: 

This is now working for opengl, but that fix has resulted in a regression for gnuplot (the y-axis ticks for the example below are reversed)


x = logspace (-5, 0, 10);
loglog (x, -x)


I'm changing the title.

Ben Abbott <bpabbott>
Group Member
Wed 28 Sep 2011 12:55:30 AM UTC, comment #1: 

The failure is due to negative values on a log scale.

ML requires all data be positive or negative. The gnuplot backend has recently been modified to support the ML behavior.

In addition, the handle-graphics properties have also been modified, and are ML compatible.

I haven't studied what is needed for FLTK, but I expect all that is left is to modify gl-render.cc


Ben Abbott <bpabbott>
Group Member
Mon 26 Sep 2011 05:35:50 PM UTC, original submission:  

The plot should have two side-by-side plots which is the case with gnuplot.  With FLTK, only the right-hand plot is shown.

This is with a recent development tip (changeset: 13228:e8c52b442a99)

Rik <rik5>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #24264:  changeset.patch added by bpabbott (1KiB - application/octet-stream)
file #24263:  matlab.pdf added by bpabbott (4KiB - application/pdf - demo loglog 2 using ML R2011b)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bpabbott (Posted a comment)
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-11-01 bpabbott StatusNone Fixed
        Assigned toNone bpabbott
        Open/ClosedOpen Closed
    2011-11-01 bpabbott Attached File- Added changeset.patch, #24264
    2011-11-01 bpabbott Attached File- Added matlab.pdf, #24263
    2011-10-31 bpabbott Summarydemo (&quot;loglog&quot;, 2) fails for FLTK toolkit demo ("loglog", 2) fails for gnuplot toolkit

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code