bugGNU Octave - Bugs: bug #33922, spqr (removed function) still...

 
 

bug #33922: spqr (removed function) still refered in source

Submitter:  Andreas Weber <andy1978>
Submitted:  Mon 01 Aug 2011 06:09:58 PM UTC
   
 
Category:  None Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Documentation
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 03 Aug 2011 12:43:03 AM UTC, comment #2: 

I pushed your patch in this changeset (http://hg.savannah.gnu.org/hgweb/octave/rev/12defc71072c).  I modified it slightly to put spaces after commas in the argument list for qr().  Thanks for finding, and fixing, this issue.

Rik <rik5>
Group administrator
Tue 02 Aug 2011 07:42:27 AM UTC, comment #1: 

I have added a patch for gr.cc

Thanks to Jordi and the IRC channel, this is my first commit of a patch. Andy

Andreas Weber <andy1978>
Group Member
Mon 01 Aug 2011 06:09:58 PM UTC, original submission:  

NEWS: ** Deprecated functions.
    The following functions were deprecated in Octave 3.2 and have been removed from Octave 3.6.
                                          
...
      israwcommand        spdet        spprod
      lchol               spdiag       spqr
...

but some functions still refer to sp* functions for example spqr:

src/DLD-FUNCTIONS/qr.cc-189-@example\n\
src/DLD-FUNCTIONS/qr.cc-190-@group\n\
src/DLD-FUNCTIONS/qr.cc:191:[@var{C},@var{R}] = spqr (@var{A},@var{B})\n\
src/DLD-FUNCTIONS/qr.cc-192-x = @var{R} \\ @var{C}\n\
src/DLD-FUNCTIONS/qr.cc-193-@end group\n\

doc/interpreter/octave.info-3-7814-     B' to be calculated as
doc/interpreter/octave.info-3-7815-
doc/interpreter/octave.info-3:7816:          [C,R] = spqr (A,B)
doc/interpreter/octave.info-3-7817-          x = R \ C

and therefore the generated documentation:
http://www.gnu.org/software/octave/doc/interpreter/Matrix-Factorizations.html

Andreas Weber <andy1978>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #23727:  spqr_fix.patch added by andy1978 (1KiB - text/x-patch - qr.cc: fixed reference to removed function spqr and added optional var B to docstring)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by andy1978 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-08-03 rik5 StatusNone Fixed
        Open/ClosedOpen Closed
    2011-08-02 andy1978 Attached File- Added spqr_fix.patch, #23727

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code