bugGNU Octave - Bugs: bug #32892, important bug in ols.m, 3.4.0 and...

 
 

bug #32892: important bug in ols.m, 3.4.0 and devel sources

Submitted by:  Michael Creel <mcreel>
Submitted on:  Wed 23 Mar 2011 01:51:34 PM UTC  
 
Category:  None Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  None
Originator Name:  Michael Creel Open/Closed:  Closed
Release:  3.4.0 Operating System:  GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Tue 29 Mar 2011 01:52:42 PM UTC, comment #7:

I've pushed your patch:

http://hg.savannah.gnu.org/hgweb/octave/rev/17997376291b

Jordi Gutiérrez Hermoso <jordigh>
Project Administrator
Tue 29 Mar 2011 06:04:10 AM UTC, comment #6:

Oops, sorry about that. I forgot to mention how to tell hg who you are.

I added the following to my blog post:

"If it’s your first time using Mercurial, you should create a filed named .hgrc on a Unix-like system or Mercurial.ini in Windows and put in there lines to identify you, like so:

[ui]
user = Your Real Name <some@email.com>

"

Thank you for your patience with all of this.

Jordi Gutiérrez Hermoso <jordigh>
Project Administrator
Mon 28 Mar 2011 10:47:40 AM UTC, comment #5:

Hi Jordi,
I tried out the method in your hg patch guide, but I could not do

hg ci -m "Commit message describing the change"

The error message is

abort: no username supplied (see "hg help config")

I'm not registered as a developer for the devel sources, perhaps that's the problem.

Michael Creel <mcreel>
Sun 27 Mar 2011 06:01:04 PM UTC, comment #4:

The howto seems pretty clear to me. About the patch, this just restores the behavior of the 3.2.4 version of ols.m, which was correct.

Michael Creel <mcreel>
Sun 27 Mar 2011 03:56:24 PM UTC, comment #3:

I've written a little howto here, and I would appreciate some comments on how to improve it:

http://jordi.inversethought.com/blog/how-to-write-a-patch-for-octave/

At a first glance, your patch looks correct. I'll study it and apply it to the development branch. It's up to the release manager, right now jwe, to transplant that patch to the stable release.

Jordi Gutiérrez Hermoso <jordigh>
Project Administrator
Sun 27 Mar 2011 02:35:53 PM UTC, comment #2:

Sorry, I don't know how to make a hg changeset, I only checked out the devel sources to see if the problem was present there too. A test that shows the need is to run [b s]=ols(rand(10,1), rand(10,2)) s will come out as a vector when it should be a scalar. The fix is very simple and obvious, and a changelog entry could read "fix erroneous degrees of freedom in ols.m"

I would hope that a fix for the stable release gets out before long.

Michael Creel <mcreel>
Thu 24 Mar 2011 05:38:23 AM UTC, comment #1:

Can you rewrite the patch as an hg changeset and include a ChangeLog entry? Plus provide some test cases that exemplify the need for the patch? Let me know if you need help with any of these bureaucratic tasks, but it's the last request that is most important.

Jordi Gutiérrez Hermoso <jordigh>
Project Administrator
Wed 23 Mar 2011 01:51:34 PM UTC, original submission:

In ols.m, the variable r is used with two meanings, the rank of a matrix, and the matrix of residuals. In line 116, it's used with both meanings, but it has the value of being the residuals. Thus, the second output value sigma is incorrect.

This affects both v3.4.0 and the development sources. A patch for the development version is attached.

Michael Creel <mcreel>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #22996:  olspatch added by mcreel (701B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jordigh (Posted a comment)
  • -email is unavailable- added by mcreel (Submitted the item)
  • -email is unavailable- added by mcreel
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-03-29 jordigh StatusPatch Submitted => Fixed
        Open/ClosedOpen => Closed
    2011-03-24 jordigh StatusNone => Patch Submitted
    2011-03-23 mcreel Attached File- => Added olspatch, #22996
        Carbon-Copy- => Added -email is unavailable-

    Back to the top


    Powered by Savane 3.4