bugGNU Octave - Bugs: bug #32282, On Linux Fedora 14 required eigs...

 
 

bug #32282: On Linux Fedora 14 required eigs declarations missing

Submitted by:  Michael Godfrey <godfrey>
Submitted on:  Fri 28 Jan 2011 09:14:24 PM UTC  
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  godfrey Open/Closed:  Closed
Release:  dev Operating System:  GNU/Linux

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Sat 29 Jan 2011 03:57:56 AM UTC, comment #6: 

I don't think there are duplicated declarations. Note the first arguments of the two that you show are different, one is Matrix and the other SparseMatrix.

You are right.  Sorry about that.

Michael Godfrey <godfrey>
Project Member
Sat 29 Jan 2011 03:06:46 AM UTC, comment #5: 

Thanks for the patch.  I noticed that problem earlier, just after I committed the set of ARPACK changes and created a patch, but then forgot to push it.  It's done now.

I don't think there are duplicated declarations.  Note the first arguments of the two that you show are different, one is Matrix and the other SparseMatrix.

John W. Eaton <jwe>
Project Administrator
Sat 29 Jan 2011 02:01:45 AM UTC, comment #4: 

Diff attached to correct endif

(file #22552)

Michael Godfrey <godfrey>
Project Member
Sat 29 Jan 2011 01:14:15 AM UTC, comment #3: 

The move of the #endif mentioned below produces a build
which runs make check without any errors.

However, I did also notice thar there are quite a few
duplicated declarations.  The first example is:

 extern octave_idx_type
EigsRealSymmetricMatrix (const Matrix& m, const std::string typ,
                         octave_idx_type k, octave_idx_type p,
                         octave_idx_type &info, Matrix &eig_vec,
                         ColumnVector &eig_val, const Matrix& b,
                         ColumnVector &permB, ColumnVector &resid,
                         std::ostream &os, double tol = DBL_EPSILON,
                         bool rvec = false, bool cholB = 0, int disp = 0,
                         int maxit = 300);

 extern octave_idx_type
EigsRealSymmetricMatrix (const SparseMatrix& m, const std::string typ,
                         octave_idx_type k, octave_idx_type p,
                         octave_idx_type &info, Matrix &eig_vec,
                         ColumnVector &eig_val, const SparseMatrix& b,
                         ColumnVector &permB, ColumnVector &resid,
                         std::ostream& os, double tol = DBL_EPSILON,
                         bool rvec = false, bool cholB = 0, int disp = 0,
                         int maxit = 300);
===============================================
Similar examples follow this.   Is there any reason not to clean this
up?

Michael Godfrey <godfrey>
Project Member
Sat 29 Jan 2011 12:51:34 AM UTC, comment #2: 

Should have mentioned that this is in eigs_base.cc

Michael

Michael Godfrey <godfrey>
Project Member
Sat 29 Jan 2011 12:50:32 AM UTC, comment #1: 

This appears to be due to a misplaced #endif:

I inserted #endif at line 205 and
removed the #endif at 768

and the build is now running.

The line numbers are approximate since
I did a bit of editing while finding the correct change,

Michael

Michael Godfrey <godfrey>
Project Member
Fri 28 Jan 2011 09:14:24 PM UTC, original submission:  

libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I.. -I../libgnu -I../libgnu -I../libcruft/misc -I../liboctave -I../liboctave -I. -I. -g -O2 -DHAVE_CONFIG_H -I/usr/include/freetype2 -Wall -W -Wshadow -Wold-style-cast -Wformat -Wpointer-arith -Wwrite-strings -Wcast-align -Wcast-qual -g -O2 -pthread -g -O2 -MT DLD-FUNCTIONS/DLD_FUNCTIONS_eigs_la-eigs.lo -MD -MP -MF DLD-FUNCTIONS/.deps/DLD_FUNCTIONS_eigs_la-eigs.Tpo -c DLD-FUNCTIONS/eigs.cc  -fPIC -DPIC -o DLD-FUNCTIONS/.libs/DLD_FUNCTIONS_eigs_la-eigs.o
In file included from DLD-FUNCTIONS/eigs.cc:32:0:
./variables.h:105:49: warning: use of old-style cast
./variables.h:105:105: warning: use of old-style cast
DLD-FUNCTIONS/eigs.cc: In function 'octave_value_list Feigs(const octave_value_list&, int)':
DLD-FUNCTIONS/eigs.cc:330:25: warning: use of old-style cast
DLD-FUNCTIONS/eigs.cc:581:96: error: 'EigsComplexNonSymmetricFunc' was not declared in this scope
DLD-FUNCTIONS/eigs.cc:588:25: error: 'EigsComplexNonSymmetricMatrixShift' was not declared in this scope
DLD-FUNCTIONS/eigs.cc:592:92: error: 'EigsComplexNonSymmetricMatrixShift' was not declared in this scope
DLD-FUNCTIONS/eigs.cc:599:92: error: 'EigsComplexNonSymmetricMatrix' was not declared in this scope
DLD-FUNCTIONS/eigs.cc:603:92: error: 'EigsComplexNonSymmetricMatrix' was not declared in this scope
DLD-FUNCTIONS/eigs.cc:624:96: error: 'EigsComplexNonSymmetricFunc' was not declared in this scope
DLD-FUNCTIONS/eigs.cc:631:92: error: 'EigsComplexNonSymmetricMatrixShift' was not declared in this scope
DLD-FUNCTIONS/eigs.cc:636:92: error: 'EigsComplexNonSymmetricMatrixShift' was not declared in this scope
DLD-FUNCTIONS/eigs.cc:659:25: error: 'EigsRealSymmetricFunc' was not declared in this scope
DLD-FUNCTIONS/eigs.cc:666:29: error: 'EigsRealSymmetricMatrixShift' was not declared in this scope
DLD-FUNCTIONS/eigs.cc:671:29: error: 'EigsRealSymmetricMatrixShift' was not declared in this scope
DLD-FUNCTIONS/eigs.cc:679:29: error: 'EigsRealSymmetricMatrix' was not declared in this scope
DLD-FUNCTIONS/eigs.cc:684:29: error: 'EigsRealSymmetricMatrix' was not declared in this scope
DLD-FUNCTIONS/eigs.cc:705:25: error: 'EigsRealNonSymmetricFunc' was not declared in this scope
DLD-FUNCTIONS/eigs.cc:712:29: error: 'EigsRealNonSymmetricMatrixShift' was not declared in this scope
DLD-FUNCTIONS/eigs.cc:717:29: error: 'EigsRealNonSymmetricMatrixShift' was not declared in this scope
DLD-FUNCTIONS/eigs.cc:725:29: error: 'EigsRealNonSymmetricMatrix' was not declared in this scope
DLD-FUNCTIONS/eigs.cc:730:29: error: 'EigsRealNonSymmetricMatrix' was not declared in this scope
make[3]: *** [DLD-FUNCTIONS/DLD_FUNCTIONS_eigs_la-eigs.lo] Error 1

Michael Godfrey <godfrey>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #22552:  eigs_base.diff added by godfrey (879B - application/octet-stream - diff to correct endif problem)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by godfrey (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-01-29 jwe StatusNone => Fixed
        Open/ClosedOpen => Closed
    2011-01-29 godfrey Attached File- => Added eigs_base.diff, #22552

    Back to the top


    Powered by Savane 3.5