bugGNU Octave - Bugs: bug #29841, Feature request: conv update

 
 

bug #29841: Feature request: conv update

Submitter:  spasmous <spasmous>
Submitted:  Sun 09 May 2010 09:01:46 PM UTC
   
 
Category:  None Severity:  1 - Wish
Priority:  1 - Later Item Group:  Feature Request
Status:  None Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * 3.3.51 Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 16 May 2011 05:15:04 PM UTC, comment #5: 

It was closed because there had been no action on the part of the original coder/proposer in 1 year.  Also, conv() now supports the shape arguments 'same' and 'full' which were the impetus for the original report.  Adding a 'circ' option might be nice, but it would be above and beyond Matlab compatibility and perhaps belongs in either a new function cconv() or an Octave-Forge package.

Rik <rik5>
Group administrator
Mon 16 May 2011 01:22:11 PM UTC, comment #4: 

Why was this closed?

Jordi Gutiérrez Hermoso <jordigh>
Group Member
Thu 13 May 2010 07:03:55 PM UTC, comment #3: 

The most up-to-date practices for Octave code are found in the section titled "Contributing Guidelines" in the pdf documentation. 

In short, we can always deal with context diffs, but it is easier if you can try out the Mercurial version control system and prepare patches with that tool.  However, I understand if you don't want to learn yet another source code control system.

Also, before you make changes I would benchmark the current code.  You don't want to slow things down while tweaking the code.
The following code is crude but does the job.

a = rand(10000,1);
b = rand(10000,1);
tic; c = conv(a,b); toc;

Rik <rik5>
Group administrator
Thu 13 May 2010 06:22:39 PM UTC, comment #2: 

Why would you want to remove the 'conv' function?

Søren Hauberg <hauberg>
Thu 13 May 2010 06:17:52 PM UTC, comment #1: 

Hi - I'd like to have a go at making the change myself. It will be my first patch. I'm going to follow the advice here, unless there is another recommended way for submitting changes.

http://www.gnu.org/software/octave/bugs.html

Three things I will propose:

1. Remove the conv.m function.
2. Make convn.cc accept 1D arguments.
3. Add 'circ' as a convolution type.

The last is a feature that is not in MATLAB but should be :)

spasmous <spasmous>
Sun 09 May 2010 09:01:46 PM UTC, original submission:  

In the latest MATLAB, conv now accepts a 3rd argument to specify the type of convolution, e.g. 'same', 'valid' and 'full'.

  octave:1> a=randn(5,1);
  octave:2> b=randn(7,1);
  octave:3> conv(a,b,'same')
  error: Invalid call to conv.  Correct usage is:
   -- Function File:  conv (A, B)


If I may make a feature request: please add circular convolution 'circ' as a type. The Mathworks don't seem motivated to include this, I guess because it overlaps with their toolbox function cconv. Thanks.

spasmous <spasmous>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jordigh (Posted a comment)
  • -email is unavailable- added by hauberg (Posted a comment)
  • -email is unavailable- added by rik5 (Updated the item)
  • -email is unavailable- added by jwe (Updated the item)
  • -email is unavailable- added by spasmous (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-05-16 rik5 StatusIn Progress None
        Open/ClosedOpen Closed
    2010-09-16 jwe Priority5 - Normal 1 - Later
    2010-05-13 rik5 StatusNone In Progress
    2010-05-11 rik5 Summaryconv update Feature request: conv update
    2010-05-10 jwe Severity3 - Normal 1 - Wish
        Item GroupNone Feature Request

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code