bugThe GNU Hurd - Bugs: bug #15806, hello translator: unquoted...


bug #15806: hello translator: unquoted contents option

Submitted by:  Ben Asselstine <benasselstine>
Submitted on:  Sun 19 Feb 2006 08:27:51 PM UTC  
Category: Hurd ServersSeverity: 3 - Normal
Priority: 5 - NormalItem Group: None
Status: FixedPrivacy: Public
Assigned to: NoneOriginator Name: Ben Asselstine
Open/Closed: ClosedReproducibility: Every Time
Size (loc): NonePlanned Release: None
Effort: 0.00
Wiki-like text discussion box: 

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Thu 04 Sep 2014 11:32:45 PM UTC, comment #2:

Fixed in 74fc3df9e4ecd84b971904d3e14e5a710d941836.

Justus Winter <teythoon>
Project Member
Sun 19 Feb 2006 11:38:48 PM UTC, comment #1:

How's this fix?

2006-02-19 Ben Asselstine <benasselstine@gmail.com>
* hello.c (escapestr): New static function.
(trivfs_append_args): quoting and escaping --contents

I'm escaping $, \ and ". Is this enough?

See attached patch.

Ben Asselstine <benasselstine>
Sun 19 Feb 2006 08:27:51 PM UTC, original submission:


In trans/hello.c:trivfs_append_args, the parameter to the "contents" command-line option is not quoted.

Here's an illustrative example:

$ settrans -ac yoyo /hurd/hello --contents="hello hurd

> "

$ cat yoyo
hello hurd
$ fsysopts yoyo
/hurd/hello --contents=hello hurd

$ settrans -g yoyo



Ben Asselstine <benasselstine>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #1902:  hello.diff added by benasselstine (1kB - text/x-patch - patch to quote and escape the --contents command-line parameter in the hello translator)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by teythoon (Posted a comment)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Please enter the title of George Orwell's famous dystopian book (it's a date):



    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 04 Sep 2014 11:32:45 PM UTCteythoonStatusNone=>Fixed
    Sun 19 Feb 2006 11:38:48 PM UTCbenasselstineAttached File-=>Added hello.diff, #3422
    Sun 19 Feb 2006 08:27:51 PM UTCbenasselstineCarbon-Copy-=>Added -unavailable-

    Back to the top

    Powered by Savane 3.1-cleanup