patchGNU Octave - Patches: patch #9606, [octave forge] (image) New...

 
 

patch #9606: [octave forge] (image) New function integralImage

Submitted by:  Avinoam Kalma <avinoam>
Submitted on:  Thu 22 Mar 2018 05:43:54 PM UTC  
 
Category:  Forge : new function Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  CarnĂ« Draug <carandraug> Open/Closed:  Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 25 Mar 2018 06:31:26 PM UTC, comment #2:

@Hartmut: thanks for reviewing.
I have fixed the 45 degrees issue, and also changed the
single quotes to double quotes.
I need help in vectorizing "rotated" section.

Attahced V2.

(file #43674)

Avinoam Kalma <avinoam>
Project Member
Sun 25 Mar 2018 02:55:53 PM UTC, comment #1:

Thanks for creating this new function, Avinoam.

I've had a quick glance over it. Some comments:

  • In the doc string: You could mention the 45 degrees value to clarify the "rotated" option.
  • The "upright" code version uses cumsum, but the "rotated" code path uses two nested for-loops. Could this somehow be vectorized (as already mentioned in the code comments) for speed?
  • The tests all pass. But I haven't checked if they are Matlab compatible.
  • I think the coding styles requires double quotes for strings.
Hartmut <hardy>
Thu 22 Mar 2018 05:43:54 PM UTC, original submission:

Please review

Avinoam Kalma <avinoam>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #43674:  integralImage_V2.m added by avinoam (5KiB - application/octet-stream)
file #43632:  integralImage.m added by avinoam (5KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by hardy (Posted a comment)
  • -email is unavailable- added by avinoam (Submitted the item)
  • -email is unavailable- added by avinoam
  • -email is unavailable- added by avinoam
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-03-07 mtmiller Summary[Octave-forge] (image) New function integralImage => [octave forge] (image) New function integralImage
    2018-03-25 avinoam Attached File- => Added integralImage_V2.m, #43674
    2018-03-22 avinoam Attached File- => Added integralImage.m, #43632
        Carbon-Copy- => Added carandraug
        Carbon-Copy- => Added hardy

    Back to the top


    Powered by Savane 3.4