patchGNU Octave - Patches: patch #9407, image package: new function...

 
 

patch #9407: image package: new function houghpeaks.m

Submitted by:  Hartmut <hardy>
Submitted on:  Tue 11 Jul 2017 08:15:00 PM UTC  
 
Category: Forge : new functionPriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 02 Aug 2017 06:12:11 PM UTC, comment #6:

I have fixed the coding style issues mentioned in comment #5 (and originally in comment #3):

https://bitbucket.org/hgimpel/octave-image/commits/742179f9637703d17d8cabfc3f22a05a3fead223

And I will also attach the new version of houghpeaks.m (V5) as a file.

Is this new function houghpeaks.m now ready for inclusion into the image package?

(file #41393)

Hartmut <hardy>
Tue 01 Aug 2017 08:12:48 PM UTC, comment #5:

> 3. Coding style: I have two questions:
>
> if isempty (threshold)
> or
> if (isempty (threshold))
>
> !isimage (H)
> or
> ! isimage (H)


It is:

These coding guidelines are inherited from Octave core.

Carnë Draug <carandraug>
Project Member
Tue 01 Aug 2017 07:57:39 PM UTC, comment #4:

Thanks for your review, Avinoam:

1. good

2. thanks

3. I will leave those coding style issues to Carne. The coding guideline of the image package (in the file HACKING) doesn't say anything about this.

4. Yes, hough.m is still slightly Matlab incompatible. But I double checked, and it turned out that the different results you have observed here, ARE mostly really due to houghpeaks.m and not due to hough.m! Further investigation (using a saved csv file with the Matlab H result of peaks.m to debug the Octave function) showed that Matlab deletes the (593,136) value of H, therefore it gives the third peak (at 310,46) instead of the second one that Octave gives. This lead to the conclusion that Matlab uses a slightly bigger nhood for the peak deletion as my current Octave implementation. I am pretty sure that my current Octave implementation is doing what the Matlab help page says (size H = 723,180 -> divided by 50 gives 14.46 and 3.6 -> next bigger odd integer is 15 and 5. But Matlab seems to use 17 and 5.) So I have created a new version of my houghpeaks.m that also increases the nhood by 1 for half of the possible size values. (So their documentation is wrong here, or it is a Matlab bug I would say.) Nevertheless this new version of houghpeaks.m is now more Matlab compatible. All test still pass, Avinoams example from comment #3 now also gives Matlab compatible results, and this is added as a new test. (Slight differences of +-1 in the peak positions are really due to hough.m and not to houghpeaks.m).

The result of this houghpeaks.m on Avinoams example in comment #3 now is:
P =

586 136
311 46
596 136
523 104
374 46

But if you use the Matlab result of hough(I) (e.g. via csv export) as input to this Octave function houghpeaks.m then the result is 100% Matlab compatible, now.

You can find my new version of houghpeaks.m here:

https://bitbucket.org/hgimpel/octave-image/commits/7f928414c980bdd7360f937f32bad265011f24b5

and also attached (as file V4) to this bug report.

(file #41385)

Hartmut <hardy>
Mon 31 Jul 2017 04:43:24 AM UTC, comment #3:

Sorry for my late response:

I have checked houghpeaks on Windows 7. A few points:

1. Testing:

2. Nice demo :-)

3. Coding style: I have two questions:

if isempty (threshold)
or
if (isempty (threshold))

!isimage (H)
or
! isimage (H)

4. Matlab Compatibility:

Octave
P =

586 136
594 136
311 46
523 104
374 46

Matlab

P =

585 136
310 46
595 136
522 104
373 46

The order is different, and there a shift of one pixel in Y.
The problem is probably from hough, and not from houghpeaks.

Thanks!

Avinoam Kalma <avinoam>
Project Member
Mon 17 Jul 2017 07:19:09 AM UTC, comment #2:

some minor style fixes -> houghpeaks_V3.m

https://bitbucket.org/hgimpel/octave-image/commits/455e5ad98f00c078e37ae1bd401403a8781f47ac

(file #41218)

Hartmut <hardy>
Wed 12 Jul 2017 07:41:31 PM UTC, comment #1:

I've fixed a small bug in this new function. You can find the new version here:

https://bitbucket.org/hgimpel/octave-image/commits/bf7a64f34c358ecd9c1f64e4d1351909d767de72

I will also attach this new version as file "houghpeaks_V2.m".

(file #41194)

Hartmut <hardy>
Tue 11 Jul 2017 08:15:00 PM UTC, original submission:

I have implemented the missing function "houghpeaks.m" for the image package.

This function finds peaks in the (linear) hough transfrom matrix, as returned by hough.m. The algorithm is taken from the book (Gonzalez,Woods,Eddins) that Matlab mentions on its help page of houghpeaks.

You can find the new file on my bitbucket repository:

https://bitbucket.org/hgimpel/octave-image/commits/4cdb27d091dbd33232ef5bc25750090054304266

The file is on the default branch there, in a new head, with the bookmark "new-houghpeaks" attached.

I will also add the function file (houghpeaks_V1.m) to this report.

I would be happy to hear comments or feedback on this.

Hartmut <hardy>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #41393:  houghpeaks_V5.m added by hardy (11KiB - text/x-objcsrc)
file #41385:  houghpeaks_V4.m added by hardy (11KiB - text/x-objcsrc)
file #41218:  houghpeaks_V3.m added by hardy (11KiB - text/x-objcsrc)
file #41194:  houghpeaks_V2.m added by hardy (11KiB - text/x-objcsrc)
file #41178:  houghpeaks_V1.m added by hardy (10KiB - text/x-objcsrc)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by avinoam (Posted a comment)
  • -unavailable- added by hardy (Submitted the item)
  • -unavailable- added by hardy (cc people who care about the image package)
  • -unavailable- added by hardy (cc people who care about the image package)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 02 Aug 2017 06:12:11 PM UTChardyAttached File-=>Added houghpeaks_V5.m, #41393
    Tue 01 Aug 2017 07:57:39 PM UTChardyAttached File-=>Added houghpeaks_V4.m, #41385
    Mon 17 Jul 2017 07:19:09 AM UTChardyAttached File-=>Added houghpeaks_V3.m, #41218
    Wed 12 Jul 2017 07:41:31 PM UTChardyAttached File-=>Added houghpeaks_V2.m, #41194
    Tue 11 Jul 2017 08:15:00 PM UTChardyAttached File-=>Added houghpeaks_V1.m, #41178
      Carbon-Copy-=>Added avinoam
      Carbon-Copy-=>Added carandraug

    Back to the top


    Powered by Savane 3.1-cleanup1