patchGNU Octave - Patches: patch #9011, Tests for corefcn/


patch #9011: Tests for corefcn/

Submitter:  Dag Lyberg <dagl>
Submitted:  Wed 25 May 2016 11:29:35 PM UTC
Category:  Core : other Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment (Rich Markup)

Comment Type & Canned Response:


Thu 13 Dec 2018 01:29:35 AM UTC, comment #5: 

I was able to use some of the BIST tests and I put them in this changeset

Rik <rik5>
Project Administrator
Tue 14 Jun 2016 11:47:19 PM UTC, comment #4: 

Nir, the tests work for "make check".  You just can run "test sparse" from the Octave command line.

Still, I had missed -- we don't want to duplicate what is done there.

Lachlan Andrew <lachlan>
Mon 13 Jun 2016 01:56:57 PM UTC, comment #3: 

 Do tests now work for built-in functions?

Currently it looks like such tests are instead placed in etc/tests/fixed/sparse.tst via tests/

Nir Krakauer <nir_krakauer>
Sun 12 Jun 2016 10:29:12 PM UTC, comment #2: 

Thanks for your reply Andrew.

It is sensible to add tests for complex values, NA, NaN, +Inf and -Inf for now. I am writing tests for comparison operators at the moment. I am thinking of writing tests for matrix and vector operators, and other operators after that.

Dag Lyberg <dagl>
Fri 10 Jun 2016 09:09:48 AM UTC, comment #1: 

These look like an excellent start (although you have

%!assert (issparse (sparse (1)), true)


You might want to add tests for sparse() with complex values, NA, NaN, +Inf and -Inf.

It would also be great to have tests of basic operations on sparse matrices: addition, subtraction, array multiply, matrix multiply, left-divide, right-divide, taking sub-matrices, transpose, Hermitian transpose.  These aren't explicitly tests for sparse(), but are sort of wrapped up in there.

Lachlan Andrew <lachlan>
Wed 25 May 2016 11:29:35 PM UTC, original submission:  

I have written a couple of tests for the functions sparse(), issparse() and spalloc(), located in corefcn/ There is a page for this:

I want feedback on the suitability of these tests if I need to rewrite them.

Dag Lyberg <dagl>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

Attached Files
file #37266:  sparse.patch added by dagl (5KiB - text/x-patch)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by nir_krakauer (Posted a comment)
  • -email is unavailable- added by lachlan (Posted a comment)
  • -email is unavailable- added by dagl (Submitted the item)
  • -email is unavailable- added by dagl

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.





    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-12-13 rik5 StatusNone Done
        Open/ClosedOpen Closed
    2016-07-07 lachlan CategoryNone Core : other
    2016-05-25 dagl Attached File- Added sparse.patch, #37266
        Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.9