patchGNU Octave - Patches: patch #9011, Tests for corefcn/sparse.cc

 
 

patch #9011: Tests for corefcn/sparse.cc

Submitted by:  Dag Lyberg <dagl>
Submitted on:  Wed 25 May 2016 11:29:35 PM UTC  
 
Category: Core : otherPriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 14 Jun 2016 11:47:19 PM UTC, comment #4:

Nir, the tests work for "make check". You just can run "test sparse" from the Octave command line.

Still, I had missed build-sparse-tests.sh -- we don't want to duplicate what is done there.

Lachlan Andrew <lachlan>
Project Member
Mon 13 Jun 2016 01:56:57 PM UTC, comment #3:

Do tests now work for built-in functions? https://savannah.gnu.org/bugs/?47424

Currently it looks like such tests are instead placed in etc/tests/fixed/sparse.tst via tests/build-sparse-tests.sh

Nir Krakauer <nir_krakauer>
Sun 12 Jun 2016 10:29:12 PM UTC, comment #2:

Thanks for your reply Andrew.

It is sensible to add tests for complex values, NA, NaN, +Inf and -Inf for now. I am writing tests for comparison operators at the moment. I am thinking of writing tests for matrix and vector operators, and other operators after that.

Dag Lyberg <dagl>
Fri 10 Jun 2016 09:09:48 AM UTC, comment #1:

These look like an excellent start (although you have

twice).

You might want to add tests for sparse() with complex values, NA, NaN, +Inf and -Inf.

It would also be great to have tests of basic operations on sparse matrices: addition, subtraction, array multiply, matrix multiply, left-divide, right-divide, taking sub-matrices, transpose, Hermitian transpose. These aren't explicitly tests for sparse(), but are sort of wrapped up in there.

Lachlan Andrew <lachlan>
Project Member
Wed 25 May 2016 11:29:35 PM UTC, original submission:

I have written a couple of tests for the functions sparse(), issparse() and spalloc(), located in corefcn/sparse.cc. There is a page for this: http://wiki.octave.org/Add_BIST_tests_for_octave_functions_written_in_C%2B%2B.

I want feedback on the suitability of these tests if I need to rewrite them.

Dag Lyberg <dagl>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #37266:  sparse.patch added by dagl (5KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by nir_krakauer (Posted a comment)
  • -unavailable- added by lachlan (Posted a comment)
  • -unavailable- added by dagl (Submitted the item)
  • -unavailable- added by dagl
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 07 Jul 2016 01:39:49 AM UTClachlanCategoryNone=>Core : other
    Wed 25 May 2016 11:29:35 PM UTCdaglAttached File-=>Added sparse.patch, #37266
      Carbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1