Wed 23 Mar 2016 12:36:43 AM UTC, comment #5:
Thanks for looking at this, jwe. Your comments are, as always, spot on.
I was intending this more for developers while testing functions. In particular, I wasn't in the habit of running the textscan BIST because running "make check" takes forever and produces voluminous output, and I couldn't just test textscan.
That developer focus is also the reason for putting the make logic in was to allow tests to be tweaked without rerunning make (and without making changes to the .cc-tst file that may not get copied back to the .cc file). I tried just putting "make ....cc-tst" in, and it converted a seemingly instantaneous test into a multi-second wait.
Perhaps all of this suggests that there should be a separate script for testing the development version that doesn't get shipped, and a simpler extension to test.m that only checks OCTAVE_DIR/etc/tests.
Many tests test multiple functions, like the tests for dbstatus also testing dbstop. These could be tagged with a comma-separated list of functions, but it isn't clear what -tst files should be created. We wouldn't want "make check" to run the same test multiple times. One option would be for test itself to parse the -tst file (trivial if only we could assume awk was present...), and only run the tests for the nominated command. That would also not require any changes to the build system.
I'm happy to make all of the changes you suggest except for changing the Makefile. I'm happy to attempt that, but it would need careful vetting...
|