bugPSPP - Bugs: bug #62675, atlocal.in uses 'which'...

 
 

bug #62675: atlocal.in uses 'which' unnecessarily

Submitter:  Sam James <thesamesam>
Submitted:  Sun 26 Jun 2022 06:26:24 AM UTC
   
 
Category:  Compilation/Portability Severity:  5 - Average
Status:  Fixed Assigned to:  None
Open/Closed:  Closed Release:  None
Effort:  0.00
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 26 Jun 2022 07:17:14 AM UTC, comment #2: 

Wow, thanks for fixing that so quickly. Much appreciated!

Sam James <thesamesam>
Sun 26 Jun 2022 07:12:27 AM UTC, comment #1: 

Thanks for your hint. I changed that as you proposed with commit:

https://git.savannah.gnu.org/cgit/pspp.git/commit/?id=f0ac9253e8b84691cec17fc80422993949a91cc1

Regards

Friedrich

Friedrich Beckmann <beckmanf>
Group Member
Sun 26 Jun 2022 06:26:24 AM UTC, original submission:  

When `which` isn't installed:
```
make  check-local
make[3]: Entering directory '/var/tmp/portage/sci-mathematics/pspp-1.6.1/work/pspp-1.6.1'
XTERM_LOCALE='' /bin/sh './tests/testsuite' -C tests AUTOTEST_PATH=tests/data:tests/language/lexer:tests/libpspp:tests/output:tests/math:src/ui/terminal:utilities RUNNER=''
./tests/testsuite: 1: ./atlocal: which: not found
## -------------------------- ##
## GNU PSPP 1.6.1 test suite. ##
## -------------------------- ##

calendar
```
Would it be possible to swap out `which` for `command -v`? `which` is an external command not required by POSIX and `command -v` should do the job OK.

Debian (and other distros, like Gentoo) are currently working to root out the base dependency of which as it's usually not actually needed.

Thanks a bunch!

Sam James <thesamesam>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by beckmanf (Posted a comment)
  • -email is unavailable- added by thesamesam (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-06-26 beckmanf CategoryNone Compilation/Portability
        StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code