bugGNU Octave - Bugs: bug #61855, [octave forge] (communications)...

 
 

bug #61855: [octave forge] (communications) error_state error

Submitter:  None
Submitted:  Wed 19 Jan 2022 03:10:51 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  None Assigned to:  None
Originator Name:  Originator Email:  -email is unavailable-
Open/Closed:  * Open Release:  * dev
Operating System:  * Any Fixed Release:  None
Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Mon 13 Mar 2023 06:10:55 PM UTC, comment #9: 

See also
https://savannah.gnu.org/bugs/index.php?63916

Does it mean those packages use non-public APIs?

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Mon 13 Mar 2023 04:42:04 PM UTC, comment #8: 

I was the person who reported comment #2. I found a workaround if it helps anyone:

1. Build Octave with all symbols exported, that is use "--disable-lib-visibility-flags" to configure.

2. pkg install -forge communications

It won't help you with precompiled binaries though.

Arun Giridhar <arungiridhar>
Group Member
Mon 13 Mar 2023 03:34:13 PM UTC, comment #7: 

Thanks for the report. Looks like we still need a fix for building gf.cc with Octave 8. The error message as reported below is

error: .../communications-1.2.4/x86_64-pc-linux-gnu-api-v57+/gf.oct: failed to load: .../communications-1.2.4/x86_64-pc-linux-gnu-api-v57+/gf.oct: undefined symbol: ZN18octave_base_matrixI7NDArrayE6assignERK17octave_value_listRKS0

Nir Krakauer <nir_krakauer>
Mon 13 Mar 2023 12:59:29 PM UTC, comment #6: 

I get the same error as reported in comment #2 when building for Octave 8.1.0. Is there any patch available for fixing it?

Petr Kopecky <kejpi>
Mon 12 Sep 2022 05:45:40 PM UTC, comment #5: 

Nir your install was for Octave 6.2

The OP install was for Octave v8
And comment #2 shows an error is shown for Octave v7


Most of the warnings come from the update the "." operator is no longer necessary. Attached is a start, did not touch golomb or rice.

For the commsimages (in /doc) there is no -*- texinfo -*-
Is this the warning?

Looks like both errors genqamdemod.cc and gf.cc were fixed.
Just need a new version of the package to be released.





(file #53682)

Anonymous
Sat 29 Jan 2022 07:56:01 PM UTC, comment #4: 

Not sure. For me a fresh install of Communications 1.2.4 in Octave 6.2 gives no errors, and the following warnings:

In file included from /usr/include/c++/11/bits/char_traits.h:39,
                 from /usr/include/c++/11/string:40,
                 from /usr/include/octave-6.2.0/octave/../octave/errwarn.h:31,
                 from oct-alt-includes.h:2,
                 from config.h:132,
                 from galois.cc:22:
In function ‘std::__copy_move<false, true, std::random_access_iterator_tag>::__copy_m<long>(long const*, long const*, long*)long*’,
    inlined from ‘std::__copy_move_a2<false, long*, long*>(long*, long*, long*)long*’ at /usr/include/c++/11/bits/stl_algobase.h:495:30,
    inlined from ‘std::__copy_move_a1<false, long*, long*>(long*, long*, long*)long*’ at /usr/include/c++/11/bits/stl_algobase.h:522:42,
    inlined from ‘std::__copy_move_a<false, long*, long*>(long*, long*, long*)long*’ at /usr/include/c++/11/bits/stl_algobase.h:529:31,
    inlined from ‘std::copy<long*, long*>(long*, long*, long*)long*’ at /usr/include/c++/11/bits/stl_algobase.h:620:7,
    inlined from ‘std::__copy_n<long*, int, long*>(long*, int, long*, std::random_access_iterator_tag)long*’ at /usr/include/c++/11/bits/stl_algo.h:725:23,
    inlined from ‘std::copy_n<long*, int, long*>(long*, int, long*)long*’ at /usr/include/c++/11/bits/stl_algo.h:757:27,
    inlined from ‘std::copy_n<long*, int, long*>(long*, int, long*)long*’ at /usr/include/c++/11/bits/stl_algo.h:743:5,
    inlined from ‘dim_vector::clonerep()’ at /usr/include/octave-6.2.0/octave/../octave/dim-vector.h:132:17,
    inlined from ‘dim_vector::make_unique()’ at /usr/include/octave-6.2.0/octave/../octave/dim-vector.h:169:45,
    inlined from ‘dim_vector::make_unique()’ at /usr/include/octave-6.2.0/octave/../octave/dim-vector.h:165:8,
    inlined from ‘dim_vector::chop_trailing_singletons()’ at /usr/include/octave-6.2.0/octave/../octave/dim-vector.h:246:21,
    inlined from ‘Array<long>::Array(dim_vector const&)’ at /usr/include/octave-6.2.0/octave/../octave/Array.h:268:41,
    inlined from ‘base_lu<galois>::getp() const’ at base-lu.cc:127:30:
/usr/include/c++/11/bits/stl_algobase.h:431:30: warning: ‘memcpy’ reading between 24 and 17179869176 bytes from a region of size 16 [-Wstringop-overread]
  431 |             __builtin_memmove(__result, __first, sizeof(_Tp) * _Num);
      |             ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/octave-6.2.0/octave/../octave/lo-array-errwarn.h:31,
                 from /usr/include/octave-6.2.0/octave/../octave/errwarn.h:33,
                 from oct-alt-includes.h:2,
                 from config.h:132,
                 from galois.cc:22:
/usr/include/c++/11/bits/stl_algobase.h: In member function ‘base_lu<galois>::getp() const’:
/usr/include/octave-6.2.0/octave/../octave/dim-vector.h:116:56: note: at offset 16 into source object of size 32 allocated by ‘operator new[](unsigned long)’
  116 |     octave_idx_type *r = new octave_idx_type [ndims + 2];
      |                                                        ^
warning: doc_cache_create: unusable help text found in file 'commsimages'
warning: called from
    doc_cache_create>handle_function at line 98 column 5
    doc_cache_create>create_cache at line 118 column 36
    gen_doc_cache_in_dir>@<anonymous> at line 150 column 16
    doc_cache_create>gen_doc_cache_in_dir at line 151 column 9
    doc_cache_create at line 62 column 12
    install>generate_lookfor_cache at line 825 column 5
    install at line 237 column 7
    pkg at line 568 column 9


Any patches for these as well as the ones you found will be appreciated.

Nir Krakauer <nir_krakauer>
Mon 24 Jan 2022 11:15:33 PM UTC, comment #3: 

Does anyone know how to fix the undefined symbol error in comment #2? Are there specific flags to use?

Arun Giridhar <arungiridhar>
Group Member
Thu 20 Jan 2022 03:59:02 PM UTC, comment #2: 

This is related, but it's not about error_state so the bug should be retitled.

I saw that a new version 1.2.4 of the communications package is now available so I tried installing it. I get the following warnings and errors. I believe the warnings can be resolved over time by changing the deprecated operators, but the error is likely something to do with exporting symbols. Are there special flags I should use to get the package to build?


octave:1> pkg install -forge communications
warning: the '.-' operator was deprecated in version 7 and will not be allowed in a future version of Octave; please use '-' instead; near line 58 of file '.../communications-1.2.4/amdemod.m'
warning: called from
    doc_cache_create>create_cache at line 116 column 20
    gen_doc_cache_in_dir>@<anonymous> at line 150 column 16
    doc_cache_create>gen_doc_cache_in_dir at line 151 column 9
    doc_cache_create at line 62 column 12
    install>generate_lookfor_cache at line 840 column 5
    install at line 241 column 7
    pkg at line 603 column 9

warning: the '.-' operator was deprecated in version 7 and will not be allowed in a future version of Octave; please use '-' instead; near line 56 of file '.../communications-1.2.4/ammod.m'
warning: called from
    doc_cache_create>create_cache at line 116 column 20
    gen_doc_cache_in_dir>@<anonymous> at line 150 column 16
    doc_cache_create>gen_doc_cache_in_dir at line 151 column 9
    doc_cache_create at line 62 column 12
    install>generate_lookfor_cache at line 840 column 5
    install at line 241 column 7
    pkg at line 603 column 9

warning: the '.-' operator was deprecated in version 7 and will not be allowed in a future version of Octave; please use '-' instead; near line 56 of file '.../communications-1.2.4/fmmod.m'
warning: called from
    doc_cache_create>create_cache at line 116 column 20
    gen_doc_cache_in_dir>@<anonymous> at line 150 column 16
    doc_cache_create>gen_doc_cache_in_dir at line 151 column 9
    doc_cache_create at line 62 column 12
    install>generate_lookfor_cache at line 840 column 5
    install at line 241 column 7
    pkg at line 603 column 9

warning: the '.+' operator was deprecated in version 7 and will not be allowed in a future version of Octave; please use '+' instead; near line 59 of file '.../communications-1.2.4/fmmod.m'
warning: called from
    doc_cache_create>create_cache at line 116 column 20
    gen_doc_cache_in_dir>@<anonymous> at line 150 column 16
    doc_cache_create>gen_doc_cache_in_dir at line 151 column 9
    doc_cache_create at line 62 column 12
    install>generate_lookfor_cache at line 840 column 5
    install at line 241 column 7
    pkg at line 603 column 9

warning: the '**' operator was deprecated in version 7 and will not be allowed in a future version of Octave; please use '^' instead; near line 64 of file '.../communications-1.2.4/golombdeco.m'
warning: called from
    doc_cache_create>create_cache at line 116 column 20
    gen_doc_cache_in_dir>@<anonymous> at line 150 column 16
    doc_cache_create>gen_doc_cache_in_dir at line 151 column 9
    doc_cache_create at line 62 column 12
    install>generate_lookfor_cache at line 840 column 5
    install at line 241 column 7
    pkg at line 603 column 9

warning: the '**' operator was deprecated in version 7 and will not be allowed in a future version of Octave; please use '^' instead; near line 72 of file '.../communications-1.2.4/golombenco.m'
warning: called from
    doc_cache_create>create_cache at line 116 column 20
    gen_doc_cache_in_dir>@<anonymous> at line 150 column 16
    doc_cache_create>gen_doc_cache_in_dir at line 151 column 9
    doc_cache_create at line 62 column 12
    install>generate_lookfor_cache at line 840 column 5
    install at line 241 column 7
    pkg at line 603 column 9

warning: the '**' operator was deprecated in version 7 and will not be allowed in a future version of Octave; please use '^' instead; near line 62 of file '.../communications-1.2.4/ricedeco.m'
warning: called from
    doc_cache_create>create_cache at line 116 column 20
    gen_doc_cache_in_dir>@<anonymous> at line 150 column 16
    doc_cache_create>gen_doc_cache_in_dir at line 151 column 9
    doc_cache_create at line 62 column 12
    install>generate_lookfor_cache at line 840 column 5
    install at line 241 column 7
    pkg at line 603 column 9

warning: the '**' operator was deprecated in version 7 and will not be allowed in a future version of Octave; please use '^' instead; near line 74 of file '.../communications-1.2.4/riceenco.m'
warning: called from
    doc_cache_create>create_cache at line 116 column 20
    gen_doc_cache_in_dir>@<anonymous> at line 150 column 16
    doc_cache_create>gen_doc_cache_in_dir at line 151 column 9
    doc_cache_create at line 62 column 12
    install>generate_lookfor_cache at line 840 column 5
    install at line 241 column 7
    pkg at line 603 column 9

warning: the '**' operator was deprecated in version 7 and will not be allowed in a future version of Octave; please use '^' instead; near line 86 of file '.../communications-1.2.4/riceenco.m'
warning: called from
    doc_cache_create>create_cache at line 116 column 20
    gen_doc_cache_in_dir>@<anonymous> at line 150 column 16
    doc_cache_create>gen_doc_cache_in_dir at line 151 column 9
    doc_cache_create at line 62 column 12
    install>generate_lookfor_cache at line 840 column 5
    install at line 241 column 7
    pkg at line 603 column 9

warning: the '**' operator was deprecated in version 7 and will not be allowed in a future version of Octave; please use '^' instead; near line 88 of file '.../communications-1.2.4/riceenco.m'
warning: called from
    doc_cache_create>create_cache at line 116 column 20
    gen_doc_cache_in_dir>@<anonymous> at line 150 column 16
    doc_cache_create>gen_doc_cache_in_dir at line 151 column 9
    doc_cache_create at line 62 column 12
    install>generate_lookfor_cache at line 840 column 5
    install at line 241 column 7
    pkg at line 603 column 9

warning: doc_cache_create: unusable help text found in file 'commsimages'
warning: called from
    doc_cache_create>handle_function at line 98 column 5
    doc_cache_create>create_cache at line 118 column 36
    gen_doc_cache_in_dir>@<anonymous> at line 150 column 16
    doc_cache_create>gen_doc_cache_in_dir at line 151 column 9
    doc_cache_create at line 62 column 12
    install>generate_lookfor_cache at line 840 column 5
    install at line 241 column 7
    pkg at line 603 column 9

error: .../communications-1.2.4/x86_64-pc-linux-gnu-api-v57+/gf.oct: failed to load: .../communications-1.2.4/x86_64-pc-linux-gnu-api-v57+/gf.oct: undefined symbol: _ZN18octave_base_matrixI7NDArrayE6assignERK17octave_value_listRKS0_
error: called from
    doc_cache_create>create_cache at line 116 column 20
    gen_doc_cache_in_dir>@<anonymous> at line 150 column 16
    doc_cache_create>gen_doc_cache_in_dir at line 151 column 9
    doc_cache_create at line 62 column 12
    install>generate_lookfor_cache at line 840 column 5
    install at line 241 column 7
    pkg at line 603 column 9


Arun Giridhar <arungiridhar>
Group Member
Wed 19 Jan 2022 05:18:19 PM UTC, comment #1: 

I think this has been reported as bug #61566.

It's probably time for a new package release with the fix.

Nir Krakauer <nir_krakauer>
Wed 19 Jan 2022 03:10:51 PM UTC, original submission:  

Hello Octave,

Fresh install of Octave 8 from hg sources. This happens for the communications toolbox, something about error_state not found:


octave:1> pkg install -forge communications
genqamdemod.cc:82:12: error: use of undeclared identifier 'error_state'
      if (!error_state)
           ^
1 error generated.
make: *** [Makefile:47: genqamdemod.oct] Error 1
make: *** Waiting for unfinished jobs....
make: Entering directory '/tmp/oct-ADkZZi/communications-1.2.3/src'
/usr/local/bin/mkoctfile-8.0.0 -DGALOIS_DISP_PRIVATES -DHAVE_CONFIG_H __errcore__.cc -o __errcore__.oct
/usr/local/bin/mkoctfile-8.0.0 -DGALOIS_DISP_PRIVATES -DHAVE_CONFIG_H __gfweight__.cc -o __gfweight__.oct
/usr/local/bin/mkoctfile-8.0.0 -DGALOIS_DISP_PRIVATES -DHAVE_CONFIG_H cyclgen.cc -o cyclgen.oct
/usr/local/bin/mkoctfile-8.0.0 -DGALOIS_DISP_PRIVATES -DHAVE_CONFIG_H cyclpoly.cc -o cyclpoly.oct
/usr/local/bin/mkoctfile-8.0.0 -DGALOIS_DISP_PRIVATES -DHAVE_CONFIG_H genqamdemod.cc -o genqamdemod.oct
/usr/local/bin/mkoctfile-8.0.0 -DGALOIS_DISP_PRIVATES -DHAVE_CONFIG_H -c galois-def.cc -o galois-def.o
make: Leaving directory '/tmp/oct-ADkZZi/communications-1.2.3/src'

error: pkg: error running 'make' for the communications package
error: called from
    configure_make at line 106 column 9
    install at line 202 column 7
    pkg at line 603 column 9


Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #53682:  comm_diffs.txt added by None (4KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dasergatskov (Posted a comment)
  • -email is unavailable- added by kejpi (Posted a comment)
  • -email is unavailable- added by arungiridhar (Posted a comment)
  • -email is unavailable- added by nir_krakauer (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-09-12 None Attached File- Added comm_diffs.txt, #53682

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code