bugGNU Octave - Bugs: bug #61566, [octave forge] (communications)...

 
 

bug #61566: [octave forge] (communications) Fix compilation with Octave 8

Submitter:  Markus Mützel <mmuetzel>
Submitted:  Fri 26 Nov 2021 04:25:19 PM UTC
   
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 30 Nov 2021 06:20:24 PM UTC, comment #5: 

Closing as fixed.

Markus Mützel <mmuetzel>
Group administrator
Tue 30 Nov 2021 05:55:25 PM UTC, comment #4: 

You can close it. We should do a new release of Communications right before Octave 7 comes out.

Nir Krakauer <nir_krakauer>
Tue 30 Nov 2021 05:50:51 PM UTC, comment #3: 

Thanks.

Should I close this report? Or do you prefer to keep it open until the next release of the communications package?

Markus Mützel <mmuetzel>
Group administrator
Tue 30 Nov 2021 05:47:33 PM UTC, comment #2: 
Nir Krakauer <nir_krakauer>
Fri 26 Nov 2021 04:28:19 PM UTC, comment #1: 

A possible patch is attached.

(file #52350)

Markus Mützel <mmuetzel>
Group administrator
Fri 26 Nov 2021 04:25:19 PM UTC, original submission:  

Quoting jwe from bug #61551:

> The global 'error_state' variable has been useless for quite some time now.  It's been removed on the default branch (what will become version 8.1 in about a year).  Since about 6 years ago, it has never had a value other than 0 in Octave code and is no longer useful for checking whether an error has occurred because exceptions are thrown, so checking the state of a variable after an error occurs is not useful except inside a 'catch' clause that handles 'octave::execution_exception'.
> All uses of this variable should be removed from the video package and any other packages that still use it.  You should have been seeing a warning at compile time about it being deprecated since before version 6 was released (it was marked as deprecated in May 2019).


This also applies to the communications package.
I'll attach a possible patch as soon as I'll have a bug number.

Markus Mützel <mmuetzel>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #52350:  of-communications-2-error_state.patch added by mmuetzel (9KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by nir_krakauer (Posted a comment)
  • -email is unavailable- added by mmuetzel (Submitted the item)
  • -email is unavailable- added by mmuetzel
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-11-30 mmuetzel StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2021-11-26 mmuetzel Attached File- Added of-communications-2-error_state.patch, #52350
        StatusNone Patch Submitted
    2021-11-26 mmuetzel Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.12.
    Corresponding source code