bugGNU Octave - Bugs: bug #61583, [octave forge] (tisean) Remove...

 
 

bug #61583: [octave forge] (tisean) Remove usage of "error_state"

Submitted by:  Markus Mützel <mmuetzel>
Submitted on:  Mon 29 Nov 2021 01:07:09 PM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Ready For Test Assigned to:  John Donoghue <lostbard>
Originator Name:  Open/Closed:  Open
Release:  dev Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 08 Jan 2022 03:35:10 PM UTC, comment #3: 
John Donoghue <lostbard>
Project MemberIn charge of this item.
Mon 29 Nov 2021 01:09:02 PM UTC, comment #2: 

Re-upload with correct bug number.

(file #52381)

Markus Mützel <mmuetzel>
Project Member
Mon 29 Nov 2021 01:07:59 PM UTC, comment #1: 

Attaching a possible patch.

(file #52380)

Markus Mützel <mmuetzel>
Project Member
Mon 29 Nov 2021 01:07:09 PM UTC, original submission:  

Quoting jwe from bug #61551:

> The global 'error_state' variable has been useless for quite some time now.  It's been removed on the default branch (what will become version 8.1 in about a year).  Since about 6 years ago, it has never had a value other than 0 in Octave code and is no longer useful for checking whether an error has occurred because exceptions are thrown, so checking the state of a variable after an error occurs is not useful except inside a 'catch' clause that handles 'octave::execution_exception'.
> All uses of this variable should be removed from the video package and any other packages that still use it.  You should have been seeing a warning at compile time about it being deprecated since before version 6 was released (it was marked as deprecated in May 2019).


This also applies to the tisean package.
I'll attach a possible patch as soon as I'll have a bug number.

Markus Mützel <mmuetzel>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #52381:  of-tisean-error_state.patch added by mmuetzel (137KiB - application/octet-stream)
file #52380:  of-tisean-error_state.patch added by mmuetzel (137KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by mmuetzel (Submitted the item)
  • -email is unavailable- added by mmuetzel
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-01-08 lostbard StatusPatch Submitted => Ready For Test
        Assigned toNone => lostbard
    2021-11-29 mmuetzel Attached File- => Added of-tisean-error_state.patch, #52381
    2021-11-29 mmuetzel Attached File- => Added of-tisean-error_state.patch, #52380
        StatusNone => Patch Submitted
    2021-11-29 mmuetzel Carbon-Copy- => Added lostbard

    Back to the top


    Powered by Savane 3.7