bugGNU Octave - Bugs: bug #59953, [octave forge] (image) imtransform...

 
 

bug #59953: [octave forge] (image) imtransform xdata can't handle descending order

Submitted by:  None
Submitted on:  Wed 27 Jan 2021 09:30:55 AM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Matlab Compatibility
Status:  Patch Submitted Assigned to:  None
Originator Name:  Originator Email:  -email is unavailable-
Open/Closed:  Open Release:  other
Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Wed 06 Oct 2021 04:44:04 AM UTC, comment #7: 

Ping: please review the attached fix.
Thanks

Avinoam Kalma <avinoam>
Project Member
Mon 30 Aug 2021 05:12:29 AM UTC, comment #6: 

udata and vdata should be in ascending order.
Attached revised fix.
Please review

(file #51834, file #51835)

Avinoam Kalma <avinoam>
Project Member
Sun 29 Aug 2021 08:50:47 PM UTC, comment #5: 

Thanks, you are right. I will change the documentation.
I will check also what happened when udata,vdata are in descending order.

Avinoam Kalma <avinoam>
Project Member
Sun 29 Aug 2021 08:17:10 PM UTC, comment #4: 

output appears to now be correct vs matlab.  should the help text for xdata and ydata be updated to indicate the change from expected [min max]?  the matlab help indicates that it refers to [1st_row/col last_row/col] instead, implying the flip.

Nicholas Jankowski <nrjank>
Project Member
Sun 29 Aug 2021 06:57:20 PM UTC, comment #3: 

Please review the attached patch, which should fix this bug.
Attached: a new version of imtransform.m and a diff file

(file #51828, file #51829)

Avinoam Kalma <avinoam>
Project Member
Sun 31 Jan 2021 09:27:27 PM UTC, comment #2: 

Dear Anonymous, thank you for letting us know about this bug you found in Octave's image package.

Our image package is maintained by (very) few volunteers who donate their spare time to keep it up and running as well as improving it. I hope that one of us can have a closer look at this issue in the near future. But much to my regret, it often takes an unpleasantly long time before this happens.

If you are familiar with writing and debugging m-files, like our imtransform.m, then you could really help us to fix the bug you found by investigating yourself and trying to pin-point where and how our m-code should be improved. We would be really grateful for any contribution of yours to make the image package even better.

Hartmut <hardy>
Thu 28 Jan 2021 07:27:34 PM UTC, comment #1: 

adding people to cc

Hartmut <hardy>
Wed 27 Jan 2021 09:30:55 AM UTC, original submission:  

im = [1 2;3 4];
tmat = [eye(2); 0 0];
T = maketform ('affine', tmat);
im2 = imtransform (im, T, 'xdata', [3 1], 'ydata', [1 3]);

This code would result in [0 2 1; 0 4 3; 0 0 0] in Matlab but a 3x0 matrix in Octave.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #51834:  imtransform_V2.diff added by avinoam (5KiB - application/octet-stream)
file #51835:  imtransform_V2.m added by avinoam (17KiB - application/octet-stream)
file #51828:  imtransform.m added by avinoam (16KiB - application/octet-stream)
file #51829:  imtransform.diff added by avinoam (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by nrjank (Posted a comment)
  • -email is unavailable- added by avinoam
  • -email is unavailable- added by avinoam (Updated the item)
  • -email is unavailable- added by siko1056 (Updated the item)
  • -email is unavailable- added by hardy (Posted a comment)
  • -email is unavailable- added by hardy
  • -email is unavailable- added by hardy
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 12 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-08-30 avinoam Attached File- => Added imtransform_V2.diff, #51834
        Attached File- => Added imtransform_V2.m, #51835
        StatusConfirmed => Patch Submitted
    2021-08-29 avinoam Attached File- => Added imtransform.m, #51828
        Attached File- => Added imtransform.diff, #51829
        Operating SystemGNU/Linux => Any
        Carbon-Copy- => Added pantxo
    2021-01-31 avinoam StatusNone => Confirmed
        Release5.2.0 => other
    2021-01-31 siko1056 Summaryimage package: imtransform xdata can't handle descending order => [octave forge] (image) imtransform xdata can't handle descending order
    2021-01-28 hardy Carbon-Copy- => Added avinoam
        Carbon-Copy- => Added carandraug

    Back to the top


    Powered by Savane 3.7