bugGNU Octave - Bugs: bug #59652, [octave forge] (image) Increase...

 
 

bug #59652: [octave forge] (image) Increase tolerance of BIST in cp2tform

Submitter:  Rafael Laboissière <rlaboiss>
Submitted:  Thu 10 Dec 2020 04:27:55 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Unexpected Error or Warning
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * other Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 17 Dec 2020 07:46:02 PM UTC, comment #4: 

closing as fixed

Avinoam Kalma <avinoam>
Group Member
Mon 14 Dec 2020 07:27:09 PM UTC, comment #3: 

Thanks for the clarification! (My hg interpreted the attached patch file differently...)

I have now pushed this change to the image repo under your name: http://hg.code.sf.net/p/octave/image/rev/f142342c0629

This issue can now be closed as FIXED, I think.

Hartmut <hardy>
Mon 14 Dec 2020 04:16:59 AM UTC, comment #2: 

Neither. My patch fixes this BIST:


%!test
%! npt = 100000;
%! [crw, cap] = coords (npt);
%! ttype = 'affine';
%! T = cp2tform (crw, cap, ttype);
%! crw2 = tforminv (T, cap);
%! finalerr = norm (crw - crw2)/npt;
%! assert (finalerr < eps, "norm = %3.2e ( > eps)", finalerr)


which starts at line 298 of file inst/cp2tform.m (version 2.12.0 of the image package).

Rafael Laboissière <rlaboiss>
Sun 13 Dec 2020 09:19:39 PM UTC, comment #1: 

Thanks for this patch, Rafael.

I was on the way of pushing it to the repo, when I noticed a discrepancy, maybe you can comment shortly on this: You wrote that the test invoking the 'affine' argument failed for you. But your patch loosens the error tolerances for a test with 'polynomial' argument instead. Is this a typo in your text of in your patch?

Hartmut <hardy>
Thu 10 Dec 2020 04:27:55 PM UTC, original submission:  

The BIST in cp2tform invoving the 'affine' value for argument ttype fails on the s309x architecture of Debian GNU/Linux system [*], with the error message:

     !!!!! test failed
     norm = 2.63e-16 ( > eps)]

In the patch attached to this bug report, the tolerance is changed to 2*eps instead of eps.


Rafael Laboissière <rlaboiss>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by avinoam (Posted a comment)
  • -email is unavailable- added by hardy (Posted a comment)
  • -email is unavailable- added by hardy
  • -email is unavailable- added by hardy
  • -email is unavailable- added by rlaboiss (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-12-17 avinoam StatusNone Fixed
        Open/ClosedOpen Closed
    2020-12-13 hardy Carbon-Copy- Added avinoam
        Carbon-Copy- Added carandraug
    2020-12-10 rlaboiss Attached File- Added increase-tolerance-cp2tform-bist.patch, #50433

    Back to the top

    Powered by Savane 3.13-bb6a.
    Corresponding source code