bugGNU Octave - Bugs: bug #57822, [octave forge] (image) test...

 
 

bug #57822: [octave forge] (image) test failures on macOS - imadjust, immse, mean2

Submitter:  Andrew Janke <apjanke>
Submitted:  Sat 15 Feb 2020 04:45:03 AM UTC
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  In Progress Assigned to:  None
Originator Name:  Open/Closed:  * Open
Release:  * 5.2.0 Operating System:  * Mac OS
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

( Jump to the original submission )

Sun 29 Aug 2021 06:59:27 PM UTC, comment #8: 

another ping: OP: Could you please check the maximal error?

Avinoam Kalma <avinoam>
Project Member
Sun 26 Jul 2020 08:45:54 PM UTC, comment #7: 

ping: OP: Could you please check the maximal error?

Avinoam Kalma <avinoam>
Project Member
Fri 29 May 2020 08:36:55 AM UTC, comment #6: 

... and of course, the test that fails

Avinoam Kalma <avinoam>
Project Member
Fri 29 May 2020 08:25:25 AM UTC, comment #5: 

Thanks,

Could you please check the maximal error, as in

ASSERT errors for:  assert (imadjust (img, in, out, gamma),adj)

  Location  |  Observed  |  Expected  |  Reason
(3,1,2,2,1)    0.34036      0.34036      Abs err 5.5511e-17 exceeds tol 0 by 6e-17
(2,2,2,2,1)    0.38731      0.38731      Abs err 5.5511e-17 exceeds tol 0 by 6e-17
(4,2,2,2,1)    0.15268      0.15268      Abs err 2.7756e-17 exceeds tol 0 by 3e-17
(2,3,2,2,1)    0.22302      0.22302      Abs err 2.7756e-17 exceeds tol 0 by 3e-17
(4,4,2,2,1)    0.50159      0.50159      Abs err 1.1102e-16 exceeds tol 0 by 1e-16

Avinoam Kalma <avinoam>
Project Member
Fri 29 May 2020 07:49:29 AM UTC, comment #4: 

Hmm. I'm afraid it's still failing for me.

I checked out the most recent octave-image repo and installed the "image-2.13.0+" library (from changeset 1382:af78d1f1ec4c, which I think is the commit you're referencing here) and re-ran the tests. Still one failure for imadjust:

>> pkg load image
>> runtests2 -pkg image
[...]

  /Users/janke/Library/Application Support/Octave.app/4.4.1/pkg/image-2.13.0+/imadjust.m  PASS     35/36
                                                                FAIL      1
[...]
Summary:

  GNU Octave Version: 4.4.1 (hg id: 1f46d371968c + patches)
  Tests run on angharad.local (macOS) at 29-May-2020 03:45:20
  Test execution time: 00:00:48

  PASS                             1697
  FAIL                                1
  XFAIL (expected failure)           34

  Failed tests:
     /Users/janke/Library/Application Support/Octave.app/4.4.1/pkg/image-2.13.0+/imadjust.m

Anything else I can do to help diagnose?

Andrew Janke <apjanke>
Fri 22 May 2020 05:59:54 AM UTC, comment #3: 

Closing as fixed .
If there are problems, please reopen this report.

Avinoam Kalma <avinoam>
Project Member
Wed 04 Mar 2020 08:20:56 PM UTC, comment #2: 

I have pushed a small fix which adds tolerance of eps to the
failing test
(http://hg.code.sf.net/p/octave/image/rev/af78d1f1ec4c)
please check this

Avinoam Kalma <avinoam>
Project Member
Sat 15 Feb 2020 10:20:59 PM UTC, comment #1: 

imadjust error is a tolerance problem, as you wrote.

Could you please attach the error logs for immse and mean2?

Avinoam Kalma <avinoam>
Project Member
Sat 15 Feb 2020 04:45:03 AM UTC, original submission:  

I'm getting a couple test failures in the image package on macOS 10.14.6.

Under Octave 4.4.1:

Summary:

  GNU Octave Version: 4.4.1 (hg id: 1f46d371968c + patches)
  Tests run on angharad.local (macOS) at 14-Feb-2020 23:43:00
  Test execution time: 00:01:13

  PASS                             1694
  FAIL                                4
  XFAIL (expected failure)           34

  Failed tests:
     /Users/janke/Library/Application Support/Octave.app/4.4.1/pkg/image-2.12.0/imadjust.m
     /Users/janke/Library/Application Support/Octave.app/4.4.1/pkg/image-2.12.0/immse.m
     /Users/janke/Library/Application Support/Octave.app/4.4.1/pkg/image-2.12.0/mean2.m

Under Octave 5.2.0:

  GNU Octave Version: 5.2.0 (hg id: eb46a9f47164)
  Tests run on angharad.local (macOS) at 14-Feb-2020 23:39:09
  Test execution time: 00:01:05

  PASS                             1697
  FAIL                                1
  XFAIL (expected failure)           34

  Failed tests:
     /Users/janke/octave/image-2.12.0/imadjust.m


XFAIL items are known bugs or expected failures.

Please help improve Octave by contributing fixes for them.
octave:13> test imadjust
***** test
 img = rand (4, 4, 2, 3, 2);
 adj = zeros (4, 4, 2, 3, 2);
 in  = reshape ([ 3  5  7  9 11 13 15 17 19 21 23 25;
                 97 95 93 91 89 87 85 83 81 79 77 75] / 100, [2 2 3 2]);
 out = reshape ([ 5  7  9 11 14 15 17 19 21 23 25 27;
                 95 93 91 89 87 85 83 81 79 77 75 73] / 100, [2 2 3 2]);
 gamma = reshape (0.6:.1:1.7, [1 2 3 2]);
 for p = 1:2
   for q = 1:3
     for r = 1:2
       adj(:,:,p,q,r) = imadjust (img(:,:,p,q,r), in(:,p,q,r),
                                  out(:,p,q,r), gamma(1,p,q,r));
     endfor
   endfor
 endfor
 assert (imadjust (img, in, out, gamma), adj)
!!!!! test failed
ASSERT errors for:  assert (imadjust (img, in, out, gamma),adj)

  Location  |  Observed  |  Expected  |  Reason
(3,1,2,2,1)    0.34036      0.34036      Abs err 5.5511e-17 exceeds tol 0 by 6e-17
(2,2,2,2,1)    0.38731      0.38731      Abs err 5.5511e-17 exceeds tol 0 by 6e-17
(4,2,2,2,1)    0.15268      0.15268      Abs err 2.7756e-17 exceeds tol 0 by 3e-17
(2,3,2,2,1)    0.22302      0.22302      Abs err 2.7756e-17 exceeds tol 0 by 3e-17
(4,4,2,2,1)    0.50159      0.50159      Abs err 1.1102e-16 exceeds tol 0 by 1e-16

That last one looks like it's maybe just a tolerance error where it's testing for an exact instead of approximate result.

Andrew Janke <apjanke>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by avinoam (Posted a comment)
  • -email is unavailable- added by avinoam
  • -email is unavailable- added by avinoam
  • -email is unavailable- added by apjanke (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only project members can vote.

     

     

     

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-05-29 avinoam StatusFixed In Progress
        Open/ClosedClosed Open
    2020-05-22 avinoam StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2020-03-08 avinoam StatusNone Ready For Test
    2020-02-15 avinoam Carbon-Copy- Added carandraug
        Carbon-Copy- Added hardy
    2020-02-15 mtmiller Summary[image] test failures on macOS - imadjust, immse, mean2 [octave forge] (image) test failures on macOS - imadjust, immse, mean2

    Back to the top


    Powered by Savane 3.9