bugGNU Octave - Bugs: bug #57581, [octave forge] (image) failing...

 
 

bug #57581: [octave forge] (image) failing image demos in Octave 6

Submitter:  Hartmut <hardy>
Submitted:  Sat 11 Jan 2020 11:35:50 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Documentation
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Mon 13 Jan 2020 07:53:24 PM UTC, comment #6: 

Thanks,
closing.

Avinoam Kalma <avinoam>
Group Member
Mon 13 Jan 2020 07:47:27 PM UTC, comment #5: 

I've pushed the proposed change in the demo code (from comment #2) to the default branch of the image repo: http://hg.code.sf.net/p/octave/image/rev/70f8c25b1609

The remaing issues seem all to be caused by bug #57500.

So this bug report can be CLOSED now, I think.

Hartmut <hardy>
Sun 12 Jan 2020 08:18:55 PM UTC, comment #4: 

Thanks Hartmut for your prompt answer.

Unfortunately, I am not near my Ubuntu machine this week, so I cannot prepare a changeset.
I will be glad if you can do it. (Otherwise, I will do it on the weekend).

Avinoam Kalma <avinoam>
Group Member
Sun 12 Jan 2020 08:11:23 PM UTC, comment #3: 

Regarding deconvwnr.m:
No I have not tested this under Windows, only under linux so far. I get the error when I just do "demo deconvwnr" in Octave 6 with the dev image package (it's in the demo, not in a test). When executing the first demo code the normal way, then I see that the underlying error comes from imrotate/imperspectivewarp. So this is also the same as bug #57500.

So what is left from this bug report (after "substracting" bug #57500) is:

  • The warning in the demo of otsuthresh. The fix for this behavior is mentioned in your comment #2.
  • The warning during "test montage".(I also only see this warning when doing "make check", not when running the testsuite from within Octave.) This remains unclear to me, but also after looking at the code of the test cases in montage.m I do not see anything worth fixing.


So I suggest the following:

  • Could you push a simple patch for the behavior in "demo otsuthresh", as mentioned in your comment #2, Avinoam?
  • Then we could just close this bug report and continue with bug #57500.


Hartmut <hardy>
Sun 12 Jan 2020 07:50:25 PM UTC, comment #2: 

Thanks Hartmut.

For imperspectivewarp, this is bug #57500.

For otsuthresh, the solution is to copy line 91


%! warning ("off", "Octave:data-file-in-path", "local");


before line 125.

For mantage, I noticed the a same  problem with make check, but not with the test inside Octave.

I did not see the problem with deconvwnr under Windows.
@Hartmut: did you see this problem under Windows?

Avinoam Kalma <avinoam>
Group Member
Sat 11 Jan 2020 11:42:00 PM UTC, comment #1: 

Sorry, the demo of

  • otsuthresh


has a different problem (not the one mentioned in my comment #0). It only issues a warning about loading penny.mat.

And in addition there is a warning during "make check" of the current repo version of the image package that says that

  • test montage


leaks file descriptors. (I am not sure what that means.)

Hartmut <hardy>
Sat 11 Jan 2020 11:35:50 PM UTC, original submission:  

The following files of the image package have demos that fail in current dev Octave that will become Octave 6:

  • deconvwnr
  • otsuthresh
  • imperspectivewarp


This would lead to corrupted html documentation for a new release of the image package under Octave 6.

The error message reads: "element number 2 undefined in return list". So these failures could have their root cause in bug #57500 (imrotate) or something similar.

Hartmut <hardy>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by avinoam (Posted a comment)
  • -email is unavailable- added by hardy (Submitted the item)
  • -email is unavailable- added by hardy
  • -email is unavailable- added by hardy
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-01-13 avinoam StatusConfirmed Fixed
        Open/ClosedOpen Closed
    2020-01-12 avinoam StatusNone Confirmed
    2020-01-11 hardy Carbon-Copy- Added avinoam
        Carbon-Copy- Added carandraug

    Back to the top

    Powered by Savane 3.13-aa77.
    Corresponding source code