bugPSPP - Bugs: bug #55357, In Lubuntu, in PSPP v.1.2.0,...

 
 

bug #55357: In Lubuntu, in PSPP v.1.2.0, deleting variables, takes so much time

Submitted by:  elias tsolis <estatistics>
Submitted on:  Tue 01 Jan 2019 09:19:56 PM UTC  
 
Category:  Sheet Severity:  5 - Average
Status:  Fixed Assigned to:  None
Open/Closed:  Closed Release:  None
Effort:  0.00

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Fri 05 Jun 2020 06:45:45 AM UTC, comment #14: 

John figured out that deleting many variables like 300 in a dataset with many variables like 500 will also result in long gui wainting times. I pushed a fix for this

http://git.savannah.gnu.org/cgit/pspp.git/commit/?id=2bbf5d66eeeffdbcded913145f05b9a6046056fa

I think variable deletion is now o.k. - closing. I tested this with variables generated with grid.sps

  • delete one variable at the start / middle / end
  • delete a variable selection
  • moved variables via drag and drop, then delete
  • create split dataset, then delete
Friedrich Beckmann <beckmanf>
Project Member
Sun 31 May 2020 11:06:12 PM UTC, comment #13: 

Hi John,

I made another fix to the ssw available here:

https://github.com/fredowski/ssw/tree/fix-var-delete

which contains two patches for the variable delete stall problem. This goes together with

http://git.savannah.gnu.org/cgit/pspp.git/commit/?id=e870838d34e5e0133997434d27035054c605fb4f

which avoids the insertion of new variables via the datasheet which is a problem when it is not realized yet directly after startup.

I tested this on debian unstable with gtk3 3.24.18-1 and I can delete and insert variables in both views. I tested with grid.sps and scrolled back and forth including changed row and column width.

Friedrich

Friedrich Beckmann <beckmanf>
Project Member
Mon 11 May 2020 08:37:19 AM UTC, comment #12: 

Mmh: Deleting variables in the variable view also takes ages...

To reproduce:

1. Open grid.sps and create the 500 variables 1000 cases grid
2. Select variables var10 to var15
3. Right mouseclick menu -> Delete Variables

=> Stall

Friedrich Beckmann <beckmanf>
Project Member
Mon 11 May 2020 06:25:45 AM UTC, comment #11: 

I will have a look at the patch at the week-end.   In the meantime it would be great if you could do some other tests with the patch to make sure it hasn't had any undesireable side effects.

For example do the following still work properly:

  • Adding columns.
  • Resizing Columns.
  • Scrolling from first column to last column and back,   particularly when there are columns of unequal width.
  • Anything else you can think of which might have been affected by your patch.
John Darrington <jmd>
Project Administrator
Sun 10 May 2020 08:10:43 PM UTC, comment #10: 

I tried the ssw patch also on MacOS and there it works too.

Friedrich Beckmann <beckmanf>
Project Member
Sun 10 May 2020 02:36:59 PM UTC, comment #9: 

This patch fixes the problem for me on debian bullseye:

https://github.com/fredowski/ssw/tree/fix-var-delete

I think the root cause is that the computation of the average widget size does not
work when no widgets are allocated in the bin window.

Friedrich Beckmann <beckmanf>
Project Member
Sun 10 May 2020 07:46:52 AM UTC, comment #8: 

comment #7:

>  When I delete the settings file ~/.config/psppirerc and start with the default font, then the variable delete takes very long. When I change the font, e.g. fontsize 12, then the variable deletes fast.


Thanks for the hint.  I'll have a look to see if I can do anything about this problem.  Next week I'm away so won't be able to spend any time on it.

John Darrington <jmd>
Project Administrator
Sun 10 May 2020 05:27:29 AM UTC, comment #7: 

This problem is a problem of the spread-sheet-widget. In debian bullseye it is also related to the selected font. When I delete the settings file ~/.config/psppirerc and start with the default font, then the variable delete takes very long. When I change the font, e.g. fontsize 12, then the variable deletes fast.

Friedrich Beckmann <beckmanf>
Project Member
Fri 08 May 2020 05:39:53 AM UTC, comment #6: 

This is also in the debian bullseye unstable version with gnome 3.36.2 and wayland. That is the debian default.I takes more than 5 minutes to delete 10 variables.

Friedrich Beckmann <beckmanf>
Project Member
Thu 18 Apr 2019 03:01:07 PM UTC, comment #5: 

I had another look at this.  It seems to happen only with certain window managers.

I'll take a look to see if I can fix it.

In the meantime I suggest using a tiling window manager such as ratpoison for which the problem doesn't manifest itself.

John Darrington <jmd>
Project Administrator
Sat 05 Jan 2019 03:24:31 PM UTC, comment #4: 

This is odd.  For me this operation is almost instantaneous. (< 0.5 sec)

I wonder why for other people it takes so long ...

John Darrington <jmd>
Project Administrator
Wed 02 Jan 2019 09:56:48 AM UTC, comment #3: 

I can confirm this on MacOS. It takes a couple of minutes to delete 10 variables. To reproduce:

  • Open grid.sps and create the grid datasheet
  • Go to data view
  • Select variables 110 - 120
  • Delete these by right-clicking "variable löschen"

=> Takes ages.

I attached a screenshot from the XCode Instrumentation, showing that psppire hangs in the libspread-sheet-widget in "ensure_visible_widgets".

Friedrich Beckmann <beckmanf>
Project Member
Wed 02 Jan 2019 08:36:12 AM UTC, comment #2: 

Dear Ben,

About 200 Variables per about 120 cases. I delete about 10 variables per time.

I have installed both PSPP v1.2.0 and v1.0.1. I installed them from source.

The difference is between whole minutes and some seconds. Huge difference!

I know some coding e.g. python or debugging tips. If you tell me what to do, I can post more helpful information.

Sincerely,
Elias Tsolis

p.s. I use PSPP as statistician, so it is a handy tool for me.

p.s. Happy New Year

p.s. I would interest to be involved in developing PSPP. However, my knowledge of hardcore program coding is -at least- childish. I used python as statistical / graph package.

elias tsolis <estatistics>
Tue 01 Jan 2019 09:21:43 PM UTC, comment #1: 

Wow, that's really slow!

Approximately how many variables do you have?  (Ten, a hundred, a thousand?)

Approximately how many cases do you have?  (Ten, a hundred, a thousand, more?)

How many variables are you deleting at a time?

Ben Pfaff <blp>
Project Administrator
Tue 01 Jan 2019 09:19:56 PM UTC, original submission:  

In Lubuntu, in PSPP v.1.2.0, deleting variables, takes so much time.

Process:

Pressing down shift + left mouse click, in Variable View pspp window, then right mouse click on the selected "variable numbers", and pressing "clear" or through menu.

It is taking so much time... whole minutes for clear 10 variables!

This behaviour was not found in previous editions. I could upload video, if this can help.

Sincerely,
Elias Tsolis

Email: elias_0000_0000 at yahoo.com

elias tsolis <estatistics>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #45835:  pspp-variable-delete-instruments.JPG added by beckmanf (807KiB - image/jpeg - Instrumentation showing the hang on MacOS)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by beckmanf (Posted a comment)
  • -email is unavailable- added by blp (Posted a comment)
  • -email is unavailable- added by estatistics (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-06-05 beckmanf StatusReady for Test/Review => Fixed
        Open/ClosedOpen => Closed
    2020-05-10 beckmanf StatusConfirmed => Ready for Test/Review
    2019-01-02 beckmanf Attached File- => Added pspp-variable-delete-instruments.JPG, #45835
    2019-01-02 beckmanf CategoryNone => Sheet
        StatusNone => Confirmed

    Back to the top


    Powered by Savane 3.5