bugGNU Octave - Bugs: bug #51981, [octave forge] (image) Failing...


bug #51981: [octave forge] (image) Failing unit test for otf2psf

Submitted by:  Rafael Laboissiere <rlaboiss>
Submitted on:  Sun 10 Sep 2017 03:54:21 PM UTC  
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  other Operating System:  Any

Add a New Comment (Rich Markup)

You are not logged in

Please log in, so followups can be emailed to you.


Mon 15 Oct 2018 07:58:15 PM UTC, comment #4: 

test psf2otf did not fail.
Closing as fixed

Avinoam Kalma <avinoam>
Project Member
Thu 11 Oct 2018 08:19:32 PM UTC, comment #3: 

changeset pushed http://hg.code.sf.net/p/octave/image/rev/c348b4bd5856

I am not clising this bug, because I want to check also psf2otf (comment #1)

Avinoam Kalma <avinoam>
Project Member
Wed 10 Oct 2018 04:54:57 AM UTC, comment #2: 

Checking these failures, the solution is simple:
change the line

assert (otf2psf (otf), psf, 2*eps);


assert (otf2psf (otf), psf, 4*eps);

Changeset attached

(file #45175)

Avinoam Kalma <avinoam>
Project Member
Thu 28 Sep 2017 12:52:14 PM UTC, comment #1: 

Function psf2otf is affected by the same problem.

Rafael Laboissiere <rlaboiss>
Sun 10 Sep 2017 03:54:21 PM UTC, original submission:  

The following unit test for function otf2psf in package image is failing randomly:

%! psf = rand (16);
%! otf = psf2otf (psf);
%! assert (otf2psf (otf), psf, 2*eps);

This is a way of triggering the bug:

octave:1> pkg load image
octave:2> while 1
octave:3>   psf = rand (16);
octave:4>   otf = psf2otf (psf);
octave:5>   assert (otf2psf (otf), psf, 2*eps);
octave:6> endwhile
error: ASSERT errors for:  assert (otf2psf (otf),psf,2 * eps)

  Location  |  Observed  |  Expected  |  Reason
   (7,2)       0.89533      0.89533      Abs err 5.5511e-16 exceeds tol 4.4409e-16

Rafael Laboissiere <rlaboiss>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

Attached Files
file #45175:  bug_51981.cs added by avinoam (673B - text/plain)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by avinoam
  • -email is unavailable- added by avinoam
  • -email is unavailable- added by avinoam (Updated the item)
  • -email is unavailable- added by rlaboiss (Submitted the item)

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.




    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-10-15 avinoam StatusNone => Fixed
        Open/ClosedOpen => Closed
    2018-10-10 avinoam Attached File- => Added bug_51981.cs, #45175
        Carbon-Copy- => Added hardy
        Carbon-Copy- => Added carandraug

    Back to the top

    Powered by Savane 3.7