bugGNU Octave - Bugs: bug #51268, addpath fails for UNC paths on...

 
 

bug #51268: addpath fails for UNC paths on Windows

Submitted by:  None
Submitted on:  Mon 19 Jun 2017 04:26:59 PM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Regression
Status: FixedAssigned to: None
Originator Name: Andy BuckleOriginator Email: -unavailable-
Open/Closed: ClosedRelease: dev
Operating System: Microsoft Windows

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 18 Dec 2017 05:17:00 PM UTC, comment #6:

Probably not a bad idea since this is a true bug, rather than a new feature. I used 'hg graft' to backport the cset to stable here (http://hg.savannah.gnu.org/hgweb/octave/rev/ceae837bc9ea).

Rik <rik5>
Project Administrator
Mon 18 Dec 2017 04:36:40 AM UTC, comment #5:

What about pushing this fix to the stable branch also, so it will enter 4.2.2 release?

Avinoam Kalma <avinoam>
Project Member
Tue 29 Aug 2017 06:51:13 PM UTC, comment #4:

Markus: I pushed your changeset here:

http://hg.savannah.gnu.org/hgweb/octave/rev/37f3c4416f2e

Note that I used OCTAVE_HAVE_WINDOWS_FILESYSTEM instead of OCTAVE_USE_WINDOWS_API since this code is specific to the Windows filesystem but doesn't actually use any of Windows-specific functions.

John W. Eaton <jwe>
Project Administrator
Sun 25 Jun 2017 04:52:47 PM UTC, comment #3:

The attached patch fixes the issue with adding UNC paths on Windows for me.

(file #41042)

Markus Mützel <mmuetzel>
Project Member
Wed 21 Jun 2017 01:40:39 PM UTC, comment #2:

The problem is probably with the following lines in load-path.cc (around line 2420) introduces with http://hg.savannah.gnu.org/hgweb/octave/rev/d5a58720459d

How could that be adapted to allow the string to start with two directory separators (on Windows)?

For the time being you could map the network share to a drive letter and add the folder to the path from there.

Markus Mützel <mmuetzel>
Project Member
Tue 20 Jun 2017 09:22:07 AM UTC, comment #1:

This bug is still present in a recent dev build on Windows 10.

Markus Mützel <mmuetzel>
Project Member
Mon 19 Jun 2017 04:26:59 PM UTC, original submission:

fails with

(Note leading '\' stripped)

This used to work on Octave 3.6.4

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #41042:  bug51268_addpath_UNC.patch added by mmuetzel (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by avinoam (Posted a comment)
  • -unavailable- added by rik5 (Updated the item)
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by mmuetzel (Posted a comment)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 05 Sep 2017 04:23:01 AM UTCrik5StatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Tue 29 Aug 2017 06:51:13 PM UTCjweStatusPatch Submitted=>Ready For Test
    Sun 25 Jun 2017 04:52:47 PM UTCmmuetzelAttached File-=>Added bug51268_addpath_UNC.patch, #41042
      StatusConfirmed=>Patch Submitted
    Tue 20 Jun 2017 09:22:07 AM UTCmmuetzelStatusNone=>Confirmed
      Release4.2.1=>dev
      Summaryaddpath fails for UNC paths on Win 7=>addpath fails for UNC paths on Windows

    Back to the top


    Powered by Savane 3.1-cleanup1