bugGNU Octave - Bugs: bug #48151, pkg update - error if packages are...

 
 

bug #48151: pkg update - error if packages are specified

Submitted by:  Nicholas Jankowski <nrjank>
Submitted on:  Mon 06 Jun 2016 05:57:14 PM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Other
Status: Patch SubmittedAssigned to: None
Originator Name: Nicholas JankowskiOpen/Closed: Open
Release: devOperating System: Microsoft Windows

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 18 Dec 2017 04:44:35 AM UTC, comment #3:

@Maintainers: please review the attached patch

Avinoam Kalma <avinoam>
Project Member
Wed 15 Nov 2017 05:59:55 AM UTC, comment #2:

I ran into the same problem, trying to update a specific package on octave 4.2.1. The changes specified here fixed the problem for me. I hope they can be integrated in to the next octave version.

Marshall <marsian>
Mon 06 Jun 2016 06:19:45 PM UTC, comment #1:

Also had to tweak one of the following lines:

to:

otherwise it would concatenate the empty cell, which would break the later .name call on line 548 since it still looked like a cell not a struct.

patch attached

(file #37412)

Nicholas Jankowski <nrjank>
Mon 06 Jun 2016 05:57:14 PM UTC, original submission:

first noticed using Octave 4.0.2, Windows 32bit, zip-file install.

"pkg update pkgname1 _pkgname2_ ..." produced an error because of 'installed_pkgs_list' not being defined. Saw that the dev branch had a fix for this and a following line defining update_lst, but searching failed to find me a bug/patch tracker related to these fixes. The dev version still gives the following error:

the line of interest is:
but installed_pkgs_lst is a cell array of structs, so .name errors out. the following line does work:

With this running the pkg command above works. Will upload a patch for review to implement this fix.

Nicholas Jankowski <nrjank>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #37412:  pkgupdatefix.diff added by nrjank (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by avinoam (Posted a comment)
  • -unavailable- added by marsian (Posted a comment)
  • -unavailable- added by nrjank (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 18 Dec 2017 04:46:16 AM UTCavinoamStatusNone=>Patch Submitted
    Mon 06 Jun 2016 06:19:45 PM UTCnrjankAttached File-=>Added pkgupdatefix.diff, #37412

    Back to the top


    Powered by Savane 3.1-cleanup1