bugGNU Octave - Bugs: bug #46521, [octave forge] (communications)...

 
 

bug #46521: [octave forge] (communications) fails to build with latest stable octave

Submitted by:  John Donoghue <lostbard>
Submitted on:  Tue 24 Nov 2015 09:41:14 PM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Postponed Assigned to:  None
Originator Name:  JohnD Open/Closed:  Open
Release:  dev Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Mon 23 Dec 2019 03:00:06 PM UTC, comment #56: 

OK, fiboenco is fine now (I added more tests to make sure). Anyone have insight into huffmandeco or comms("test", "galois")?

Nir Krakauer <nir_krakauer>
Mon 23 Dec 2019 05:12:55 AM UTC, comment #55: 

I believe Octave's behaviour for that syntax is implicitly chosing the first element in the array as the one used for the colon operator.
The only difference between versions is that it now warns about it.
Maybe something like this would be easier to understand:

for i = find (f <= N, 1, "first"):LEN_F

Markus Mützel <mmuetzel>
Project Member
Mon 23 Dec 2019 04:47:11 AM UTC, comment #54: 

OK, I added that modification.

Nir Krakauer <nir_krakauer>
Mon 23 Dec 2019 12:16:43 AM UTC, comment #53: 

Or, what passes tests:

for i = unique([find(f <= N) LEN_F])

John Donoghue <lostbard>
Project Member
Sun 22 Dec 2019 11:57:25 PM UTC, comment #52: 

I mean should be:

for i = [find (f <= N) LEN_F]

John Donoghue <lostbard>
Project Member
Sun 22 Dec 2019 11:50:24 PM UTC, comment #51: 

For:

fiboenco.m ..................................................warning: colon arguments should be scalars

The code is:

f = [233 144 89 55 34 21 13 8 5 3 2 1];
for i = find (f <= N):LEN_F

Which produces the warning in Octave 6 as find returns somethign like

[11 12]:13, which I dont think makes sense.

Octave 5.1.1 returns an 11 12 13

It should probally be

for i = [find (f <= N):LEN_F]

John Donoghue <lostbard>
Project Member
Sun 22 Dec 2019 10:12:43 PM UTC, comment #50: 

Done - and I pushed them directly to the repo

John Donoghue <lostbard>
Project Member
Sun 22 Dec 2019 09:06:36 PM UTC, comment #49: 

Thanks for these additional fixes. John, would you mind making a patch relative to the current repo that has them all?

`make check` with the repo version also shows the following warnings for me on Dev Octave -- any help with them would be appreciated:

<< Galois Fields Package >>
  Polynomial manipulation:                  polyval: P must be a numeric floating point vector


fiboenco.m ..................................................warning: colon arguments should be scalars
warning: called from
    fiboenco at line 77 column 5


  huffmandeco.m ...............................................warning: huffmandeco: could not decode last symbol
warning: called from
    huffmandeco at line 70 column 5

Nir Krakauer <nir_krakauer>
Sun 22 Dec 2019 01:54:40 PM UTC, comment #48: 

It would be nice to get rid of all the error_state warnings as well :)

But for the isnumeric, isreal:

diff -r a49be0b5345f src/configure.ac
--- a/src/configure.ac  Sun Dec 22 08:46:53 2019 -0500
+++ b/src/configure.ac  Sun Dec 22 08:53:28 2019 -0500
@@ -105,6 +105,15 @@
 ],

 [dnl
+  [is_numeric_type],
+  [isnumeric],
+  [[octave_value ().isnumeric ();]],
+  [OV_ISNUMERIC],
+  [],
+  []
+],
+
+[dnl
   [is_empty],
   [isempty],
   [[octave_value ().isempty ();]],

diff -r a49be0b5345f src/ov-galois.h
--- a/src/ov-galois.h   Sun Dec 22 08:46:53 2019 -0500
+++ b/src/ov-galois.h   Sun Dec 22 08:53:28 2019 -0500
@@ -103,7 +103,7 @@

   bool is_defined (void) const { return true; }

-  bool is_numeric_type (void) const { return true; }
+  bool OV_ISNUMERIC (void) const { return true; }

   bool is_constant (void) const { return true; }

@@ -127,7 +127,7 @@

   bool is_real_matrix (void) const { return false; }

-  bool is_real_type (void) const { return false; }
+  bool OV_ISREAL (void) const { return false; }

John Donoghue <lostbard>
Project Member
Sun 22 Dec 2019 01:42:56 PM UTC, comment #47: 

I have a hd5 one I need in order to commpile in fedra 31 at least - I cant remember now if it was posted eslewhere that does a fall back if hdf5 isnt found by pkg config

--- a/src/configure.ac  Fri Dec 20 18:39:25 2019 -0500
+++ b/src/configure.ac  Sun Dec 22 08:40:10 2019 -0500
@@ -142,11 +142,29 @@
 LDFLAGS=$save_altsyms_LDFLAGS
 LIBS=$save_altsyms_LIBS

-# check for HDF5
+have_hdf5=no
+# check for HDF5 using pkg-config
 PKG_CHECK_MODULES([HDF5],[hdf5],
- [],
- [AC_MSG_ERROR([hdf5 not found])]
+ [have_hdf5=yes ],
+ []
 )
+if test $have_hdf5 = no; then
+  save_CPPFLAGS="$CPPFLAGS"
+  save_LIBS="$LIBS"
+  AC_CHECK_LIB(hdf5,H5Fopen,
+    [
+     have_hdf5=yes
+     AC_CHECK_HEADERS([hdf5.h])
+     HDF5_LIBS=-lhdf5
+    ],
+    [],
+  )
+  CPPFLAGS="$save_CPPFLAGS"
+  LIBS="$save_LIBS"
+fi
+if test $have_hdf5 = no; then
+  AC_MSG_ERROR([hdf5 not found])
+fi

John Donoghue <lostbard>
Project Member
Sun 22 Dec 2019 01:10:34 PM UTC, comment #46: 

After merging the changes from the remote repository (hg id ), I still have the following local changes:

diff -r 47e4a4bdb477 src/gf.cc
--- a/src/gf.cc        Fri Dec 20 18:39:25 2019 -0500
+++ b/src/gf.cc        Sun Dec 22 14:06:51 2019 +0100
@@ -622,7 +621,7 @@
     }
   if (si.numel () != ab_len - 1)
     {
-      error ("gfilter: si must be a vector of length max(length(a), length(b)) - 1");
+      error ("gfilter: si must be a vector of length max(numel(a), numel(b)) - 1");
       return galois ();
     }
   if (norm != 1)
@@ -752,7 +751,7 @@
@smallexample\n\
@group\n\
    N                   M\n\
-  SUM a(k+1) y(n-k) = SUM b(k+1) x(n-k)      for 1<=n<=length(x)\n\
+  SUM a(k+1) y(n-k) = SUM b(k+1) x(n-k)      for 1<=n<=numel(x)\n\
   k=0                 k=0\n\
@end group\n\
@end smallexample\n\
@@ -764,7 +763,7 @@
  $a \\in \\Re^{N-1}$, $b \\in \\Re^{M-1}$, and $x \\in \\Re^P$.\n\
@end tex\n\
@ifnottex\n\
- N=length(a)-1 and M=length(b)-1.\n\
+ N=numel(a)-1 and M=numel(b)-1.\n\
@end ifnottex\n\
An equivalent form of this equation is:\n\
@tex\n\
@@ -778,7 +777,7 @@
@smallexample\n\
@group\n\
             N                   M\n\
-  y(n) = - SUM c(k+1) y(n-k) + SUM d(k+1) x(n-k)  for 1<=n<=length(x)\n\
+  y(n) = - SUM c(k+1) y(n-k) + SUM d(k+1) x(n-k)  for 1<=n<=numel(x)\n\
            k=1                 k=0\n\
@end group\n\
@end smallexample\n\
diff -r 47e4a4bdb477 src/ov-galois.h
--- a/src/ov-galois.h        Fri Dec 20 18:39:25 2019 -0500
+++ b/src/ov-galois.h        Sun Dec 22 14:06:51 2019 +0100
@@ -103,7 +103,7 @@

   bool is_defined (void) const { return true; }

-  bool is_numeric_type (void) const { return true; }
+  bool isnumeric (void) const { return true; }

   bool is_constant (void) const { return true; }

@@ -127,7 +127,7 @@

   bool is_real_matrix (void) const { return false; }

-  bool is_real_type (void) const { return false; }
+  bool isreal (void) const { return false; }

   // FIXME
   bool valid_as_scalar_index (void) const { return false; }

I think at least the changes in ov-galois.h still need to be handled. Maybe with the OV_ISNUMERIC and OV_ISREAL macros.

Markus Mützel <mmuetzel>
Project Member
Tue 10 Dec 2019 09:45:17 PM UTC, comment #45: 

Thanks, now `make dist` works and the warning is gone. I pushed this patch to the repo.

Nir Krakauer <nir_krakauer>
Tue 10 Dec 2019 09:22:25 PM UTC, comment #44: 

Attached again with --git export so that x permissions should hopefully come with the bootstrap file

(file #48042)

John Donoghue <lostbard>
Project Member
Tue 10 Dec 2019 09:17:02 PM UTC, comment #43: 

whats teh permissions on bootstrap ?

John Donoghue <lostbard>
Project Member
Tue 10 Dec 2019 09:08:50 PM UTC, comment #42: 

Thanks! The new octave-6.0-all.patch works for me if, after applying it, I install the package manually, namely

cd ~/Desktop
tar czf communications-1.2.1.tar.gz -C $HOME'/Documents/octave-hg' octave-communications
octave:1> cd ~/Desktop; pkg prefix ~/octave ~/octave;
octave:2> pkg install '~/Desktop/communications-1.2.1.tar.gz'

I do get a warning when loading it:

warning: autoload: 'gf.oct' is not an absolute filename
warning: called from
    /home/nir/octave/communications-1.2.1/PKG_ADD at line 2 column 1
    load_packages_and_dependencies at line 48 column 5
    load_packages at line 47 column 3
    pkg at line 495 column 7

However, `make dist` fails:

Creating package version 1.2.1 release ...
rm -rf communications-1.2.1
hg archive --exclude ".hg*" --exclude Makefile --type files communications-1.2.1
cd communications-1.2.1/doc && make all
make[1]: Entering directory '~/Documents/octave-hg/octave-communications/communications-1.2.1/doc'
/bin/sh images.sh > images.mk
Making texinfo comms.texi
Function gf, does not contain texinfo help
Function commsimages, does not contain texinfo help
makeinfo --no-split -o comms.info comms.texi
make[1]: Leaving directory '~/Documents/octave-hg/octave-communications/communications-1.2.1/doc'
cd communications-1.2.1/src && ./bootstrap
/bin/sh: 1: ./bootstrap: Permission denied
make: *** [Makefile:42: communications-1.2.1] Error 126

Nir Krakauer <nir_krakauer>
Tue 10 Dec 2019 08:37:05 PM UTC, comment #41: 

It looks like the 6.0 patch will also work backwards for octave 5.1

John Donoghue <lostbard>
Project Member
Tue 10 Dec 2019 08:29:15 PM UTC, comment #40: 

The issue with the mxe patches is sometimes they dont apply cleanly as they are based on the released comms tarball, vs the dev code in the repo

John Donoghue <lostbard>
Project Member
Tue 10 Dec 2019 08:27:20 PM UTC, comment #39: 

Adding all in one patch that should work for octave 6 using the current comms repo code.

You should just need to apply that single patch

(file #48041)

John Donoghue <lostbard>
Project Member
Tue 10 Dec 2019 08:10:22 PM UTC, comment #38: 

Are there instructions for what to do with these patches? I tried and they didn't all apply cleanly.

Nir Krakauer <nir_krakauer>
Tue 10 Dec 2019 07:33:53 PM UTC, comment #37: 

Looks like of-communications-6-deprecated.patch isnt in the all in one patch

John Donoghue <lostbard>
Project Member
Tue 10 Dec 2019 07:29:37 PM UTC, comment #36: 
Markus Mützel <mmuetzel>
Project Member
Tue 10 Dec 2019 07:13:47 PM UTC, comment #35: 

After patching as per Kai's latest instructions, I still get some compilation errors.

My system info is

GNU Octave Version: 6.0.0 (hg id: 7b68c080723d)
Operating System: Linux 5.3.0-24-generic #26-Ubuntu SMP Thu Nov 14 01:33:18 UTC 2019 x86_64

The error messages are

In file included from op-m-gm.cc:29:
ov-galois.h:163:21: error: ‘oct_mach_info’ has not been declared
  163 |                     oct_mach_info::float_format fmt);
      |                     ^~~~~~~~~~~~~
ov-galois.h:163:49: error: expected ‘,’ or ‘...’ before ‘fmt’
  163 |                     oct_mach_info::float_format fmt);
      |                                                 ^~~
op-m-gm.cc: In function ‘void install_m_gm_ops()’:
op-m-gm.cc:85:39: error: expected primary-expression before ‘,’ token
   85 |   INSTALL_BINOP (op_add, octave_matrix, octave_galois, add);
      |                                       ^
op-m-gm.cc:85:54: error: expected primary-expression before ‘,’ token
   85 |   INSTALL_BINOP (op_add, octave_matrix, octave_galois, add);
      |                                                      ^
op-m-gm.cc:85:56: error: ‘add’ was not declared in this scope; did you mean ‘fadd’?
   85 |   INSTALL_BINOP (op_add, octave_matrix, octave_galois, add);
      |                                                        ^~~
      |                                                        fadd
op-m-gm.cc:85:3: error: ‘INSTALL_BINOP’ was not declared in this scope; did you mean ‘INSTALL_BINOP_TI’?
   85 |   INSTALL_BINOP (op_add, octave_matrix, octave_galois, add);
      |   ^~~~~~~~~~~~~
      |   INSTALL_BINOP_TI
op-m-gm.cc:86:39: error: expected primary-expression before ‘,’ token
   86 |   INSTALL_BINOP (op_sub, octave_matrix, octave_galois, sub);
      |                                       ^
op-m-gm.cc:86:54: error: expected primary-expression before ‘,’ token
   86 |   INSTALL_BINOP (op_sub, octave_matrix, octave_galois, sub);
      |                                                      ^
op-m-gm.cc:86:56: error: ‘sub’ was not declared in this scope; did you mean ‘fsub’?
   86 |   INSTALL_BINOP (op_sub, octave_matrix, octave_galois, sub);
      |                                                        ^~~
      |                                                        fsub
op-m-gm.cc:87:39: error: expected primary-expression before ‘,’ token
   87 |   INSTALL_BINOP (op_mul, octave_matrix, octave_galois, mul);
      |                                       ^
op-m-gm.cc:87:54: error: expected primary-expression before ‘,’ token
   87 |   INSTALL_BINOP (op_mul, octave_matrix, octave_galois, mul);
      |                                                      ^
op-m-gm.cc:87:56: error: ‘mul’ was not declared in this scope; did you mean ‘fmul’?
   87 |   INSTALL_BINOP (op_mul, octave_matrix, octave_galois, mul);
      |                                                        ^~~
      |                                                        fmul
op-m-gm.cc:88:39: error: expected primary-expression before ‘,’ token
   88 |   INSTALL_BINOP (op_div, octave_matrix, octave_galois, div);
      |                                       ^
op-m-gm.cc:88:54: error: expected primary-expression before ‘,’ token
   88 |   INSTALL_BINOP (op_div, octave_matrix, octave_galois, div);
      |                                                      ^
op-m-gm.cc:89:39: error: expected primary-expression before ‘,’ token
   89 |   INSTALL_BINOP (op_pow, octave_matrix, octave_galois, pow);
      |                                       ^
op-m-gm.cc:89:54: error: expected primary-expression before ‘,’ token
   89 |   INSTALL_BINOP (op_pow, octave_matrix, octave_galois, pow);
      |                                                      ^
op-m-gm.cc:90:40: error: expected primary-expression before ‘,’ token
   90 |   INSTALL_BINOP (op_ldiv, octave_matrix, octave_galois, ldiv);
      |                                        ^
op-m-gm.cc:90:55: error: expected primary-expression before ‘,’ token
   90 |   INSTALL_BINOP (op_ldiv, octave_matrix, octave_galois, ldiv);
      |                                                       ^
op-m-gm.cc:91:38: error: expected primary-expression before ‘,’ token
   91 |   INSTALL_BINOP (op_lt, octave_matrix, octave_galois, lt);
      |                                      ^
op-m-gm.cc:91:53: error: expected primary-expression before ‘,’ token
   91 |   INSTALL_BINOP (op_lt, octave_matrix, octave_galois, lt);
      |                                                     ^
op-m-gm.cc:91:55: error: ‘lt’ was not declared in this scope; did you mean ‘lu’?
   91 |   INSTALL_BINOP (op_lt, octave_matrix, octave_galois, lt);
      |                                                       ^~
      |                                                       lu
op-m-gm.cc:92:38: error: expected primary-expression before ‘,’ token
   92 |   INSTALL_BINOP (op_le, octave_matrix, octave_galois, le);
      |                                      ^
op-m-gm.cc:92:53: error: expected primary-expression before ‘,’ token
   92 |   INSTALL_BINOP (op_le, octave_matrix, octave_galois, le);
      |                                                     ^
op-m-gm.cc:92:55: error: ‘le’ was not declared in this scope; did you mean ‘lu’?
   92 |   INSTALL_BINOP (op_le, octave_matrix, octave_galois, le);
      |                                                       ^~
      |                                                       lu
op-m-gm.cc:93:38: error: expected primary-expression before ‘,’ token
   93 |   INSTALL_BINOP (op_eq, octave_matrix, octave_galois, eq);
      |                                      ^
op-m-gm.cc:93:53: error: expected primary-expression before ‘,’ token
   93 |   INSTALL_BINOP (op_eq, octave_matrix, octave_galois, eq);
      |                                                     ^
op-m-gm.cc:93:55: error: ‘eq’ was not declared in this scope
   93 |   INSTALL_BINOP (op_eq, octave_matrix, octave_galois, eq);
      |                                                       ^~
op-m-gm.cc:94:38: error: expected primary-expression before ‘,’ token
   94 |   INSTALL_BINOP (op_ge, octave_matrix, octave_galois, ge);
      |                                      ^
op-m-gm.cc:94:53: error: expected primary-expression before ‘,’ token
   94 |   INSTALL_BINOP (op_ge, octave_matrix, octave_galois, ge);
      |                                                     ^
op-m-gm.cc:94:55: error: ‘ge’ was not declared in this scope
   94 |   INSTALL_BINOP (op_ge, octave_matrix, octave_galois, ge);
      |                                                       ^~
op-m-gm.cc:95:38: error: expected primary-expression before ‘,’ token
   95 |   INSTALL_BINOP (op_gt, octave_matrix, octave_galois, gt);
      |                                      ^
op-m-gm.cc:95:53: error: expected primary-expression before ‘,’ token
   95 |   INSTALL_BINOP (op_gt, octave_matrix, octave_galois, gt);
      |                                                     ^
op-m-gm.cc:95:55: error: ‘gt’ was not declared in this scope
   95 |   INSTALL_BINOP (op_gt, octave_matrix, octave_galois, gt);
      |                                                       ^~
op-m-gm.cc:96:38: error: expected primary-expression before ‘,’ token
   96 |   INSTALL_BINOP (op_ne, octave_matrix, octave_galois, ne);
      |                                      ^
op-m-gm.cc:96:53: error: expected primary-expression before ‘,’ token
   96 |   INSTALL_BINOP (op_ne, octave_matrix, octave_galois, ne);
      |                                                     ^
op-m-gm.cc:96:55: error: ‘ne’ was not declared in this scope
   96 |   INSTALL_BINOP (op_ne, octave_matrix, octave_galois, ne);
      |                                                       ^~
op-m-gm.cc:97:42: error: expected primary-expression before ‘,’ token
   97 |   INSTALL_BINOP (op_el_mul, octave_matrix, octave_galois, el_mul);
      |                                          ^
op-m-gm.cc:97:57: error: expected primary-expression before ‘,’ token
   97 |   INSTALL_BINOP (op_el_mul, octave_matrix, octave_galois, el_mul);
      |                                                         ^
op-m-gm.cc:97:59: error: ‘el_mul’ was not declared in this scope; did you mean ‘op_mul’?
   97 |   INSTALL_BINOP (op_el_mul, octave_matrix, octave_galois, el_mul);
      |                                                           ^~~~~~
      |                                                           op_mul
op-m-gm.cc:98:42: error: expected primary-expression before ‘,’ token
   98 |   INSTALL_BINOP (op_el_div, octave_matrix, octave_galois, el_div);
      |                                          ^
op-m-gm.cc:98:57: error: expected primary-expression before ‘,’ token
   98 |   INSTALL_BINOP (op_el_div, octave_matrix, octave_galois, el_div);
      |                                                         ^
op-m-gm.cc:98:59: error: ‘el_div’ was not declared in this scope; did you mean ‘op_div’?
   98 |   INSTALL_BINOP (op_el_div, octave_matrix, octave_galois, el_div);
      |                                                           ^~~~~~
      |                                                           op_div
op-m-gm.cc:99:42: error: expected primary-expression before ‘,’ token
   99 |   INSTALL_BINOP (op_el_pow, octave_matrix, octave_galois, el_pow);
      |                                          ^
op-m-gm.cc:99:57: error: expected primary-expression before ‘,’ token
   99 |   INSTALL_BINOP (op_el_pow, octave_matrix, octave_galois, el_pow);
      |                                                         ^
op-m-gm.cc:99:59: error: ‘el_pow’ was not declared in this scope; did you mean ‘elem_pow’?
   99 |   INSTALL_BINOP (op_el_pow, octave_matrix, octave_galois, el_pow);
      |                                                           ^~~~~~
      |                                                           elem_pow
op-m-gm.cc:100:43: error: expected primary-expression before ‘,’ token
  100 |   INSTALL_BINOP (op_el_ldiv, octave_matrix, octave_galois, el_ldiv);
      |                                           ^
op-m-gm.cc:100:58: error: expected primary-expression before ‘,’ token
  100 |   INSTALL_BINOP (op_el_ldiv, octave_matrix, octave_galois, el_ldiv);
      |                                                          ^
op-m-gm.cc:100:60: error: ‘el_ldiv’ was not declared in this scope; did you mean ‘op_ldiv’?
  100 |   INSTALL_BINOP (op_el_ldiv, octave_matrix, octave_galois, el_ldiv);
      |                                                            ^~~~~~~
      |                                                            op_ldiv
op-m-gm.cc:101:42: error: expected primary-expression before ‘,’ token
  101 |   INSTALL_BINOP (op_el_and, octave_matrix, octave_galois, el_and);
      |                                          ^
op-m-gm.cc:101:57: error: expected primary-expression before ‘,’ token
  101 |   INSTALL_BINOP (op_el_and, octave_matrix, octave_galois, el_and);
      |                                                         ^
op-m-gm.cc:101:59: error: ‘el_and’ was not declared in this scope; did you mean ‘mx_el_and’?
  101 |   INSTALL_BINOP (op_el_and, octave_matrix, octave_galois, el_and);
      |                                                           ^~~~~~
      |                                                           mx_el_and
op-m-gm.cc:102:41: error: expected primary-expression before ‘,’ token
  102 |   INSTALL_BINOP (op_el_or, octave_matrix, octave_galois, el_or);
      |                                         ^
op-m-gm.cc:102:56: error: expected primary-expression before ‘,’ token
  102 |   INSTALL_BINOP (op_el_or, octave_matrix, octave_galois, el_or);
      |                                                        ^
op-m-gm.cc:102:58: error: ‘el_or’ was not declared in this scope
  102 |   INSTALL_BINOP (op_el_or, octave_matrix, octave_galois, el_or);
      |                                                          ^~~~~
In file included from op-m-gm.cc:30:
galois-ops.h:143:53: error: expected primary-expression before ‘,’ token
  143 | #define INSTALL_G_CATOP(t1, t2, f) INSTALL_CATOP (t1, t2, f)
      |                                                     ^
op-m-gm.cc:104:3: note: in expansion of macro ‘INSTALL_G_CATOP’
  104 |   INSTALL_G_CATOP (octave_matrix, octave_galois, m_gm);
      |   ^~~~~~~~~~~~~~~
galois-ops.h:143:57: error: expected primary-expression before ‘,’ token
  143 | #define INSTALL_G_CATOP(t1, t2, f) INSTALL_CATOP (t1, t2, f)
      |                                                         ^
op-m-gm.cc:104:3: note: in expansion of macro ‘INSTALL_G_CATOP’
  104 |   INSTALL_G_CATOP (octave_matrix, octave_galois, m_gm);
      |   ^~~~~~~~~~~~~~~
op-m-gm.cc:104:50: error: ‘m_gm’ was not declared in this scope
  104 |   INSTALL_G_CATOP (octave_matrix, octave_galois, m_gm);
      |                                                  ^~~~
galois-ops.h:143:59: note: in definition of macro ‘INSTALL_G_CATOP’
  143 | #define INSTALL_G_CATOP(t1, t2, f) INSTALL_CATOP (t1, t2, f)
      |                                                           ^
galois-ops.h:143:36: error: ‘INSTALL_CATOP’ was not declared in this scope; did you mean ‘INSTALL_G_CATOP’?
  143 | #define INSTALL_G_CATOP(t1, t2, f) INSTALL_CATOP (t1, t2, f)
      |                                    ^~~~~~~~~~~~~
op-m-gm.cc:104:3: note: in expansion of macro ‘INSTALL_G_CATOP’
  104 |   INSTALL_G_CATOP (octave_matrix, octave_galois, m_gm);
      |   ^~~~~~~~~~~~~~~
op-m-gm.cc:106:21: error: ‘op_asn_eq’ was not declared in this scope
  106 |   INSTALL_ASSIGNOP (op_asn_eq, octave_matrix, octave_galois, assign);
      |                     ^~~~~~~~~
op-m-gm.cc:106:45: error: expected primary-expression before ‘,’ token
  106 |   INSTALL_ASSIGNOP (op_asn_eq, octave_matrix, octave_galois, assign);
      |                                             ^
op-m-gm.cc:106:60: error: expected primary-expression before ‘,’ token
  106 |   INSTALL_ASSIGNOP (op_asn_eq, octave_matrix, octave_galois, assign);
      |                                                            ^
op-m-gm.cc:106:62: error: ‘assign’ was not declared in this scope; did you mean ‘asin’?
  106 |   INSTALL_ASSIGNOP (op_asn_eq, octave_matrix, octave_galois, assign);
      |                                                              ^~~~~~
      |                                                              asin
op-m-gm.cc:106:3: error: ‘INSTALL_ASSIGNOP’ was not declared in this scope; did you mean ‘INSTALL_ASSIGNOP_TI’?
  106 |   INSTALL_ASSIGNOP (op_asn_eq, octave_matrix, octave_galois, assign);
      |   ^~~~~~~~~~~~~~~~
      |   INSTALL_ASSIGNOP_TI
make: *** [Makefile:44: op-gm-s.o] Error 1
In file included from ov-galois.cc:53:
ov-galois.h:163:21: error: ‘oct_mach_info’ has not been declared
  163 |                     oct_mach_info::float_format fmt);
      |                     ^~~~~~~~~~~~~
ov-galois.h:163:49: error: expected ‘,’ or ‘...’ before ‘fmt’
  163 |                     oct_mach_info::float_format fmt);
      |                                                 ^~~
ov-galois.cc: In member function ‘virtual octave_value octave_galois::subsref(const string&, const std::__cxx11::list<octave_value_list>&)’:
ov-galois.cc:211:9: warning: ‘error_state’ is deprecated: [6]: this variable is obsolete and always has the value 0 [-Wdeprecated-declarations]
  211 |   if (! error_state)
      |         ^~~~~~~~~~~
In file included from /home/nir/my_octave/include/octave-6.0.0/octave/../octave/oct.h:33,
                 from ov-galois.cc:27:
/home/nir/my_octave/include/octave-6.0.0/octave/../octave/error.h:491:26: note: declared here
  491 | extern OCTINTERP_API int error_state;
      |                          ^~~~~~~~~~~
ov-galois.cc: In member function ‘void octave_galois::assign(const octave_value_list&, const galois&)’:
ov-galois.cc:431:15: warning: ‘error_state’ is deprecated: [6]: this variable is obsolete and always has the value 0 [-Wdeprecated-declarations]
  431 |         if (! error_state)
      |               ^~~~~~~~~~~
In file included from /home/nir/my_octave/include/octave-6.0.0/octave/../octave/oct.h:33,
                 from ov-galois.cc:27:
/home/nir/my_octave/include/octave-6.0.0/octave/../octave/error.h:491:26: note: declared here
  491 | extern OCTINTERP_API int error_state;
      |                          ^~~~~~~~~~~
ov-galois.cc:435:19: warning: ‘error_state’ is deprecated: [6]: this variable is obsolete and always has the value 0 [-Wdeprecated-declarations]
  435 |             if (! error_state)
      |                   ^~~~~~~~~~~
In file included from /home/nir/my_octave/include/octave-6.0.0/octave/../octave/oct.h:33,
                 from ov-galois.cc:27:
/home/nir/my_octave/include/octave-6.0.0/octave/../octave/error.h:491:26: note: declared here
  491 | extern OCTINTERP_API int error_state;
      |                          ^~~~~~~~~~~
ov-galois.cc:445:15: warning: ‘error_state’ is deprecated: [6]: this variable is obsolete and always has the value 0 [-Wdeprecated-declarations]
  445 |         if (! error_state)
      |               ^~~~~~~~~~~
In file included from /home/nir/my_octave/include/octave-6.0.0/octave/../octave/oct.h:33,
                 from ov-galois.cc:27:
/home/nir/my_octave/include/octave-6.0.0/octave/../octave/error.h:491:26: note: declared here
  491 | extern OCTINTERP_API int error_state;
      |                          ^~~~~~~~~~~
ov-galois.cc: At global scope:
ov-galois.cc:558:29: error: ‘oct_mach_info’ has not been declared
  558 |                             oct_mach_info::float_format fmt)
      |                             ^~~~~~~~~~~~~
ov-galois.cc:558:57: error: expected ‘,’ or ‘...’ before ‘fmt’
  558 |                             oct_mach_info::float_format fmt)
      |                                                         ^~~
ov-galois.cc: In member function ‘bool octave_galois::load_binary(std::istream&, bool, int)’:
ov-galois.cc:599:73: error: ‘fmt’ was not declared in this scope; did you mean ‘fma’?
  599 |       read_doubles (is, re, X_CAST (save_type, tmp), dv.numel (), swap, fmt);
      |                                                                         ^~~
      |                                                                         fma
ov-galois.cc:600:11: warning: ‘error_state’ is deprecated: [6]: this variable is obsolete and always has the value 0 [-Wdeprecated-declarations]
  600 |       if (error_state || ! is)
      |           ^~~~~~~~~~~
In file included from /home/nir/my_octave/include/octave-6.0.0/octave/../octave/oct.h:33,
                 from ov-galois.cc:27:
/home/nir/my_octave/include/octave-6.0.0/octave/../octave/error.h:491:26: note: declared here
  491 | extern OCTINTERP_API int error_state;
      |                          ^~~~~~~~~~~
In file included from op-s-gm.cc:29:
ov-galois.h:163:21: error: ‘oct_mach_info’ has not been declared
  163 |                     oct_mach_info::float_format fmt);
      |                     ^~~~~~~~~~~~~
ov-galois.h:163:49: error: expected ‘,’ or ‘...’ before ‘fmt’
  163 |                     oct_mach_info::float_format fmt);
      |                                                 ^~~
op-s-gm.cc: In function ‘void install_s_gm_ops()’:
op-s-gm.cc:92:39: error: expected primary-expression before ‘,’ token
   92 |   INSTALL_BINOP (op_add, octave_scalar, octave_galois, add);
      |                                       ^
op-s-gm.cc:92:54: error: expected primary-expression before ‘,’ token
   92 |   INSTALL_BINOP (op_add, octave_scalar, octave_galois, add);
      |                                                      ^
op-s-gm.cc:92:56: error: ‘add’ was not declared in this scope; did you mean ‘fadd’?
   92 |   INSTALL_BINOP (op_add, octave_scalar, octave_galois, add);
      |                                                        ^~~
      |                                                        fadd
op-s-gm.cc:92:3: error: ‘INSTALL_BINOP’ was not declared in this scope; did you mean ‘INSTALL_BINOP_TI’?
   92 |   INSTALL_BINOP (op_add, octave_scalar, octave_galois, add);
      |   ^~~~~~~~~~~~~
      |   INSTALL_BINOP_TI
op-s-gm.cc:93:39: error: expected primary-expression before ‘,’ token
   93 |   INSTALL_BINOP (op_sub, octave_scalar, octave_galois, sub);
      |                                       ^
op-s-gm.cc:93:54: error: expected primary-expression before ‘,’ token
   93 |   INSTALL_BINOP (op_sub, octave_scalar, octave_galois, sub);
      |                                                      ^
op-s-gm.cc:93:56: error: ‘sub’ was not declared in this scope; did you mean ‘fsub’?
   93 |   INSTALL_BINOP (op_sub, octave_scalar, octave_galois, sub);
      |                                                        ^~~
      |                                                        fsub
op-s-gm.cc:94:39: error: expected primary-expression before ‘,’ token
   94 |   INSTALL_BINOP (op_mul, octave_scalar, octave_galois, mul);
      |                                       ^
op-s-gm.cc:94:54: error: expected primary-expression before ‘,’ token
   94 |   INSTALL_BINOP (op_mul, octave_scalar, octave_galois, mul);
      |                                                      ^
op-s-gm.cc:94:56: error: ‘mul’ was not declared in this scope; did you mean ‘fmul’?
   94 |   INSTALL_BINOP (op_mul, octave_scalar, octave_galois, mul);
      |                                                        ^~~
      |                                                        fmul
op-s-gm.cc:95:39: error: expected primary-expression before ‘,’ token
   95 |   INSTALL_BINOP (op_div, octave_scalar, octave_galois, div);
      |                                       ^
op-s-gm.cc:95:54: error: expected primary-expression before ‘,’ token
   95 |   INSTALL_BINOP (op_div, octave_scalar, octave_galois, div);
      |                                                      ^
op-s-gm.cc:96:39: error: expected primary-expression before ‘,’ token
   96 |   INSTALL_BINOP (op_pow, octave_scalar, octave_galois, pow);
      |                                       ^
op-s-gm.cc:96:54: error: expected primary-expression before ‘,’ token
   96 |   INSTALL_BINOP (op_pow, octave_scalar, octave_galois, pow);
      |                                                      ^
op-s-gm.cc:97:40: error: expected primary-expression before ‘,’ token
   97 |   INSTALL_BINOP (op_ldiv, octave_scalar, octave_galois, ldiv);
      |                                        ^
op-s-gm.cc:97:55: error: expected primary-expression before ‘,’ token
   97 |   INSTALL_BINOP (op_ldiv, octave_scalar, octave_galois, ldiv);
      |                                                       ^
op-s-gm.cc:98:38: error: expected primary-expression before ‘,’ token
   98 |   INSTALL_BINOP (op_lt, octave_scalar, octave_galois, lt);
      |                                      ^
op-s-gm.cc:98:53: error: expected primary-expression before ‘,’ token
   98 |   INSTALL_BINOP (op_lt, octave_scalar, octave_galois, lt);
      |                                                     ^
op-s-gm.cc:98:55: error: ‘lt’ was not declared in this scope; did you mean ‘lu’?
   98 |   INSTALL_BINOP (op_lt, octave_scalar, octave_galois, lt);
      |                                                       ^~
      |                                                       lu
op-s-gm.cc:99:38: error: expected primary-expression before ‘,’ token
   99 |   INSTALL_BINOP (op_le, octave_scalar, octave_galois, le);
      |                                      ^
op-s-gm.cc:99:53: error: expected primary-expression before ‘,’ token
   99 |   INSTALL_BINOP (op_le, octave_scalar, octave_galois, le);
      |                                                     ^
op-s-gm.cc:99:55: error: ‘le’ was not declared in this scope; did you mean ‘lu’?
   99 |   INSTALL_BINOP (op_le, octave_scalar, octave_galois, le);
      |                                                       ^~
      |                                                       lu
op-s-gm.cc:100:38: error: expected primary-expression before ‘,’ token
  100 |   INSTALL_BINOP (op_eq, octave_scalar, octave_galois, eq);
      |                                      ^
op-s-gm.cc:100:53: error: expected primary-expression before ‘,’ token
  100 |   INSTALL_BINOP (op_eq, octave_scalar, octave_galois, eq);
      |                                                     ^
op-s-gm.cc:100:55: error: ‘eq’ was not declared in this scope
  100 |   INSTALL_BINOP (op_eq, octave_scalar, octave_galois, eq);
      |                                                       ^~
op-s-gm.cc:101:38: error: expected primary-expression before ‘,’ token
  101 |   INSTALL_BINOP (op_ge, octave_scalar, octave_galois, ge);
      |                                      ^
op-s-gm.cc:101:53: error: expected primary-expression before ‘,’ token
  101 |   INSTALL_BINOP (op_ge, octave_scalar, octave_galois, ge);
      |                                                     ^
op-s-gm.cc:101:55: error: ‘ge’ was not declared in this scope
  101 |   INSTALL_BINOP (op_ge, octave_scalar, octave_galois, ge);
      |                                                       ^~
op-s-gm.cc:102:38: error: expected primary-expression before ‘,’ token
  102 |   INSTALL_BINOP (op_gt, octave_scalar, octave_galois, gt);
      |                                      ^
op-s-gm.cc:102:53: error: expected primary-expression before ‘,’ token
  102 |   INSTALL_BINOP (op_gt, octave_scalar, octave_galois, gt);
      |                                                     ^
op-s-gm.cc:102:55: error: ‘gt’ was not declared in this scope
  102 |   INSTALL_BINOP (op_gt, octave_scalar, octave_galois, gt);
      |                                                       ^~
op-s-gm.cc:103:38: error: expected primary-expression before ‘,’ token
  103 |   INSTALL_BINOP (op_ne, octave_scalar, octave_galois, ne);
      |                                      ^
op-s-gm.cc:103:53: error: expected primary-expression before ‘,’ token
  103 |   INSTALL_BINOP (op_ne, octave_scalar, octave_galois, ne);
      |                                                     ^
op-s-gm.cc:103:55: error: ‘ne’ was not declared in this scope
  103 |   INSTALL_BINOP (op_ne, octave_scalar, octave_galois, ne);
      |                                                       ^~
op-s-gm.cc:104:42: error: expected primary-expression before ‘,’ token
  104 |   INSTALL_BINOP (op_el_mul, octave_scalar, octave_galois, el_mul);
      |                                          ^
op-s-gm.cc:104:57: error: expected primary-expression before ‘,’ token
  104 |   INSTALL_BINOP (op_el_mul, octave_scalar, octave_galois, el_mul);
      |                                                         ^
op-s-gm.cc:104:59: error: ‘el_mul’ was not declared in this scope; did you mean ‘op_mul’?
  104 |   INSTALL_BINOP (op_el_mul, octave_scalar, octave_galois, el_mul);
      |                                                           ^~~~~~
      |                                                           op_mul
op-s-gm.cc:105:42: error: expected primary-expression before ‘,’ token
  105 |   INSTALL_BINOP (op_el_div, octave_scalar, octave_galois, el_div);
      |                                          ^
op-s-gm.cc:105:57: error: expected primary-expression before ‘,’ token
  105 |   INSTALL_BINOP (op_el_div, octave_scalar, octave_galois, el_div);
      |                                                         ^
op-s-gm.cc:105:59: error: ‘el_div’ was not declared in this scope; did you mean ‘op_div’?
  105 |   INSTALL_BINOP (op_el_div, octave_scalar, octave_galois, el_div);
      |                                                           ^~~~~~
      |                                                           op_div
op-s-gm.cc:106:42: error: expected primary-expression before ‘,’ token
  106 |   INSTALL_BINOP (op_el_pow, octave_scalar, octave_galois, el_pow);
      |                                          ^
op-s-gm.cc:106:57: error: expected primary-expression before ‘,’ token
  106 |   INSTALL_BINOP (op_el_pow, octave_scalar, octave_galois, el_pow);
      |                                                         ^
op-s-gm.cc:106:59: error: ‘el_pow’ was not declared in this scope; did you mean ‘elem_pow’?
  106 |   INSTALL_BINOP (op_el_pow, octave_scalar, octave_galois, el_pow);
      |                                                           ^~~~~~
      |                                                           elem_pow
op-s-gm.cc:107:43: error: expected primary-expression before ‘,’ token
  107 |   INSTALL_BINOP (op_el_ldiv, octave_scalar, octave_galois, el_ldiv);
      |                                           ^
op-s-gm.cc:107:58: error: expected primary-expression before ‘,’ token
  107 |   INSTALL_BINOP (op_el_ldiv, octave_scalar, octave_galois, el_ldiv);
      |                                                          ^
op-s-gm.cc:107:60: error: ‘el_ldiv’ was not declared in this scope; did you mean ‘op_ldiv’?
  107 |   INSTALL_BINOP (op_el_ldiv, octave_scalar, octave_galois, el_ldiv);
      |                                                            ^~~~~~~
      |                                                            op_ldiv
op-s-gm.cc:108:42: error: expected primary-expression before ‘,’ token
  108 |   INSTALL_BINOP (op_el_and, octave_scalar, octave_galois, el_and);
      |                                          ^
op-s-gm.cc:108:57: error: expected primary-expression before ‘,’ token
  108 |   INSTALL_BINOP (op_el_and, octave_scalar, octave_galois, el_and);
      |                                                         ^
make: *** [Makefile:44: op-m-gm.o] Error 1
op-s-gm.cc:108:59: error: ‘el_and’ was not declared in this scope; did you mean ‘mx_el_and’?
  108 |   INSTALL_BINOP (op_el_and, octave_scalar, octave_galois, el_and);
      |                                                           ^~~~~~
      |                                                           mx_el_and
op-s-gm.cc:109:41: error: expected primary-expression before ‘,’ token
  109 |   INSTALL_BINOP (op_el_or, octave_scalar, octave_galois, el_or);
      |                                         ^
op-s-gm.cc:109:56: error: expected primary-expression before ‘,’ token
  109 |   INSTALL_BINOP (op_el_or, octave_scalar, octave_galois, el_or);
      |                                                        ^
op-s-gm.cc:109:58: error: ‘el_or’ was not declared in this scope
  109 |   INSTALL_BINOP (op_el_or, octave_scalar, octave_galois, el_or);
      |                                                          ^~~~~
In file included from op-s-gm.cc:30:
galois-ops.h:143:53: error: expected primary-expression before ‘,’ token
  143 | #define INSTALL_G_CATOP(t1, t2, f) INSTALL_CATOP (t1, t2, f)
      |                                                     ^
op-s-gm.cc:111:3: note: in expansion of macro ‘INSTALL_G_CATOP’
  111 |   INSTALL_G_CATOP (octave_scalar, octave_galois, s_gm);
      |   ^~~~~~~~~~~~~~~
galois-ops.h:143:57: error: expected primary-expression before ‘,’ token
  143 | #define INSTALL_G_CATOP(t1, t2, f) INSTALL_CATOP (t1, t2, f)
      |                                                         ^
op-s-gm.cc:111:3: note: in expansion of macro ‘INSTALL_G_CATOP’
  111 |   INSTALL_G_CATOP (octave_scalar, octave_galois, s_gm);
      |   ^~~~~~~~~~~~~~~
op-s-gm.cc:111:50: error: ‘s_gm’ was not declared in this scope
  111 |   INSTALL_G_CATOP (octave_scalar, octave_galois, s_gm);
      |                                                  ^~~~
galois-ops.h:143:59: note: in definition of macro ‘INSTALL_G_CATOP’
  143 | #define INSTALL_G_CATOP(t1, t2, f) INSTALL_CATOP (t1, t2, f)
      |                                                           ^
galois-ops.h:143:36: error: ‘INSTALL_CATOP’ was not declared in this scope; did you mean ‘INSTALL_G_CATOP’?
  143 | #define INSTALL_G_CATOP(t1, t2, f) INSTALL_CATOP (t1, t2, f)
      |                                    ^~~~~~~~~~~~~
op-s-gm.cc:111:3: note: in expansion of macro ‘INSTALL_G_CATOP’
  111 |   INSTALL_G_CATOP (octave_scalar, octave_galois, s_gm);
      |   ^~~~~~~~~~~~~~~
op-s-gm.cc:113:36: error: expected primary-expression before ‘,’ token
  113 |   INSTALL_ASSIGNCONV (octave_scalar, octave_galois, octave_galois);
      |                                    ^
op-s-gm.cc:113:51: error: expected primary-expression before ‘,’ token
  113 |   INSTALL_ASSIGNCONV (octave_scalar, octave_galois, octave_galois);
      |                                                   ^
op-s-gm.cc:113:66: error: expected primary-expression before ‘)’ token
  113 |   INSTALL_ASSIGNCONV (octave_scalar, octave_galois, octave_galois);
      |                                                                  ^
op-s-gm.cc:113:3: error: ‘INSTALL_ASSIGNCONV’ was not declared in this scope; did you mean ‘INSTALL_ASSIGNCONV_TI’?
  113 |   INSTALL_ASSIGNCONV (octave_scalar, octave_galois, octave_galois);
      |   ^~~~~~~~~~~~~~~~~~
      |   INSTALL_ASSIGNCONV_TI
make: *** [Makefile:44: ov-galois.o] Error 1
make: *** [Makefile:44: op-s-gm.o] Error 1
make: *** [Makefile:44: gf.o] Error 1

Nir Krakauer <nir_krakauer>
Thu 21 Nov 2019 12:42:22 AM UTC, comment #34: 

I have found my problem.  Sorry for bothering everyone.  I did not have pkg-config installed. 

Chris Gorman <chrisgorman>
Thu 21 Nov 2019 12:25:29 AM UTC, comment #33: 

I'm having a problem installing the communications package given John's instructions.

checking for octave/interpreter.h... yes
./configure: line 3570: syntax error near unexpected token `HDF5,hdf5,'
./configure: line 3570: `PKG_CHECK_MODULES(HDF5,hdf5,'

Any hints on what I may be missing?  I have libhdf5-dev installed.

Chris Gorman <chrisgorman>
Wed 13 Nov 2019 01:24:28 PM UTC, comment #32: 

The communications package is a good training for newcomers to become package maintainers ;-)

Due to new questions on the mailing list, here the updated "getting starting OF package building" with great thanks to John Donoghue for constantly providing new patches for this four years outdated package.

From some Linux terminal, inside some temporary directory, run:

hg clone http://hg.code.sf.net/p/octave/communications
wget -O octave-5.0-3-all.patch https://savannah.gnu.org/support/download.php?file_id=47414
wget -O comms-hdf3.patch https://savannah.gnu.org/support/download.php?file_id=47415
cd communications
hg patch ../octave-5.0-3-all.patch
hg patch ../comms-hdf3.patch
make dist

Within Octave 5.1.0, change to that build directory (cd ..) and run:

pkg install -forge control
pkg install -forge signal
pkg install communications-1.2.1.tar.gz

Kai Torben Ohlhus <siko1056>
Project Member
Mon 02 Sep 2019 05:22:08 PM UTC, comment #31: 

Yeah. It works! Compiled and installed fine, no warnings no errors.
file #47108 + #47415

octave:4> pkg list
Package Name    | Version | Installation directory
----------------+---------+-----------------------
communications *|   1.2.1 | /home/maykon/sandbox/octave/packages/communications-1.2.1

Thank you John Donoghue!

Maykon Chagas <mchagas>
Sat 31 Aug 2019 01:49:29 AM UTC, comment #30: 

Try this patch (with the other patch also installed) and see if it helps

(file #47415)

John Donoghue <lostbard>
Project Member
Sat 31 Aug 2019 12:13:39 AM UTC, comment #29: 

Even after install a bunch of package, nothing change, put includedir and libs in PATH and nothing at all. Same error.

Maykon Chagas <mchagas>
Fri 30 Aug 2019 08:10:11 PM UTC, comment #28: 

You need to install hdf5-dev so that the package can detect it - no rebuild of octave is required

John Donoghue <lostbard>
Project Member
Fri 30 Aug 2019 05:41:50 PM UTC, comment #27: 

So I will have to rebuild my Octave with this flags enabled? If not, how to correct this issue?

Maykon Chagas <mchagas>
Fri 30 Aug 2019 04:28:32 PM UTC, comment #26: 

It has always been a dependency

See hg.code.sf.net/p/octave/communications/file/e126cad113f0/src/Makefile.in

The issue is that newer versions of octave does not have the HDF5 flags available in octave_config variables and so is being queried using pkg-config - so now needs hdf5-dev installed

Also, remember that the info on the package page was released back in 2015. You are now  using the unreleased patched repo version,  so what it says in dependencies may or not be correct now :)

John Donoghue <lostbard>
Project Member
Fri 30 Aug 2019 01:57:17 PM UTC, comment #25: 

Now, at install I have this error

checking pkg-config is at least version 0.9.0... yes
checking for hdf5... no

pkg: error running the configure script for communications.
make: *** [Makefile:73: install] Error 1

hdf5 is a dependency for communications package? It is not listed on package site:
https://octave.sourceforge.io/communications/index.html

Maykon Chagas <mchagas>
Fri 30 Aug 2019 12:13:45 PM UTC, comment #24: 

$ hg clone http://hg.code.sf.net/p/octave/communications communications
$ cd communications
$ hg patch ../octave-5.0-2-all.patch
$ make clean
rm -rf communications-1.2.1 communications-1.2.1.tar.gz communications-html.tar.gz communications-html
cd src && make clean
make[1]: Entering directory '/home/maykon/Downloads/communications/src'
make[1]: *** No rule to make target 'clean'.  Stop.
make[1]: Leaving directory '/home/maykon/Downloads/communications/src'
make: *** [Makefile:99: clean] Error 2
$ make dist
Creating package version 1.2.1 release ...
rm -rf communications-1.2.1
hg archive --exclude ".hg*" --exclude Makefile --type files communications-1.2.1
cd communications-1.2.1/doc && make all
make[1]: Entering directory '/home/maykon/Downloads/communications/communications-1.2.1/doc'
/bin/sh images.sh > images.mk
Making texinfo comms.texi
Function gf, does not contain texinfo help
Function commsimages, does not contain texinfo help
makeinfo --no-split -o comms.info comms.texi
make[1]: Leaving directory '/home/maykon/Downloads/communications/communications-1.2.1/doc'
cd communications-1.2.1/src && ./bootstrap
/bin/sh: ./bootstrap: Permission denied
make: *** [Makefile:42: communications-1.2.1] Error 126

same error.

So I went to see what's happening.
Looks like when Makefile call bootstrap in communications-1.2.1/src/bootstrap just use ./bootstrap doesn't call /bin/sh or any other *sh.

What have I done?
Change de Makefile, in line 42.

cd $@/src && /bin/sh bootstrap

Running make clean && make dist again, the package was built without errors.

The output:

$ make dist
Creating package version 1.2.1 release ...
rm -rf communications-1.2.1
hg archive --exclude ".hg*" --exclude Makefile --type files communications-1.2.1
cd communications-1.2.1/doc && make all
make[1]: Entering directory '/home/maykon/Downloads/communications/communications-1.2.1/doc'
/bin/sh images.sh > images.mk
Making texinfo comms.texi
Function gf, does not contain texinfo help
Function commsimages, does not contain texinfo help
makeinfo --no-split -o comms.info comms.texi
make[1]: Leaving directory '/home/maykon/Downloads/communications/communications-1.2.1/doc'
cd communications-1.2.1/src && /bin/sh bootstrap
chmod -R a+rX,u+w,go-w communications-1.2.1
tar cf - --posix communications-1.2.1 | gzip -9n > communications-1.2.1.tar.gz
rm -rf communications-1.2.1

That's it. At least to build the package. Now I have to look if the install process goes smoothly

Maykon Chagas <mchagas>
Fri 30 Aug 2019 11:42:54 AM UTC, comment #23: 

make clean ; make dist to create the tarball

Updated patch attached

(file #47413)

John Donoghue <lostbard>
Project Member
Fri 30 Aug 2019 03:01:00 AM UTC, comment #22: 

I get it!

But, how could I build one week ago? And I used the same procedure described above.. nothing different than that..

I don't have the patch and the repo cloned used last time, but now, if I clone the repo and apply the patch, the bootstrap script is missing.

I will wait, when ready, notify me here, and I can test for you.

TY.

Maykon Chagas <mchagas>
Fri 30 Aug 2019 02:16:11 AM UTC, comment #21: 

'make all' is just for compiling the .oct files locally, and creates a PKG_ADD/DEL for running ocally which is where I think you are seeing the issue.

'make dist' should create a tarball that can then be installed.

However, it is missing the bootstrap script  - I guess I forgot to add that the patch - I'll update it when I get a chance

John Donoghue <lostbard>
Project Member
Thu 29 Aug 2019 09:53:50 PM UTC, comment #20: 

Yeah, for me this file was in /home/maykon/sandbox/octave/packages/communications-1.2.1/PKG_ADD which is folder installed packages for octave.

I'm trying to build again the communications packages just to see whats happens, but the build is popup an error, the patch for v5.0 was incompatible now with hg repo.

hg clone http://hg.code.sf.net/p/octave/communications communications
cd communications
make all

show up this error message:

cd src && ./bootstrap
/bin/sh: ./bootstrap: No such file or directory
make: *** [Makefile:76: all] Error 127

So, at least now, after remove PKG_ADD/DEL files from folder the octave start up wassn't show any warning message.

Maykon Chagas <mchagas>
Thu 29 Aug 2019 07:19:10 PM UTC, comment #19: 

was there PKG_ADD/DEL in the src directory ?

John Donoghue <lostbard>
Project Member
Thu 29 Aug 2019 06:57:03 PM UTC, comment #18: 

Just a tar zcvf command, as usual..
tar -zcf communications-1.2.1.tar.gz communications-1.2.1

Just this, and installing with pkg command inside octave.

Is there something special? Something about hg? I'm not a regular user of hg.

Maykon Chagas <mchagas>
Thu 29 Aug 2019 06:53:17 PM UTC, comment #17: 

How are you creating the tarball after applying the patch ?

I am guessing that perhaps you have extra 'stuff' in the tarball which you are then installing.

John Donoghue <lostbard>
Project Member
Thu 29 Aug 2019 04:46:43 PM UTC, comment #16: 

Sorry for flood, but I've found a "solution".
Just remove PKG_ADD and PKG_DEL from communications package folder. I don't know all the implications about this, but at least the warning message at startup goes out.

Maykon Chagas <mchagas>
Thu 29 Aug 2019 02:42:47 PM UTC, comment #15: 

comment #12:

> Updated patch for 5.0
>
> (file #47108)


Hi, I'm having warning messages after install communications package using patch for octave 5.1.0 using the procedure as described in comment #10.

All messages are like this:

 warning: autoload: 'gf.oct' is not an absolute filename
warning: called from
    /home/maykon/sandbox/octave/packages/communications-1.2.1/PKG_ADD at line 2 column 1
    load_packages_and_dependencies at line 48 column 5
    load_packages at line 47 column 3
    pkg at line 461 column 7
    /home/maykon/.octaverc at line 7 column 2

I'm using Slackware Linux. Other octave packages like signal, control, image, general was installed without issues.

Thanks,

Maykon Chagas <mchagas>
Wed 19 Jun 2019 02:43:55 PM UTC, comment #14: 

Whats the error ?

John Donoghue <lostbard>
Project Member
Wed 19 Jun 2019 02:43:53 AM UTC, comment #13: 

FWIW - build still fails for me with the updated patch.  It appears that it cannot find HDF5 1.10.5.  Haven't had a chance to poke at that yet.

Orion Poplawski <opoplawski>
Tue 18 Jun 2019 06:01:44 PM UTC, comment #12: 

Updated patch for 5.0

(file #47108)

John Donoghue <lostbard>
Project Member
Tue 09 Oct 2018 08:15:41 PM UTC, comment #11: 

> whats prevents from the patch application?


This patch is fine for mxe, but not appropriate to apply to the communications package itself. It inserts copies of the base_lu classes that have been removed from Octave. A better solution is to port to the new lu classes in Octave 4.2 and 4.4, see bug #47267. I have not seen anyone attempt to actually port to Octave 4.4 yet, therefore this remains open.

> I get one fail for "qfuncinv.m"


See bug #54156, that is a trivial fix.

Mike Miller <mtmiller>
Project Administrator
Tue 09 Oct 2018 07:54:55 PM UTC, comment #10: 

Regarding comment #9, you are right.  I applied this patch too naively as described on the mailing list helping two desperate users of the package:

https://lists.gnu.org/archive/html/help-octave/2018-10/msg00069.html

The "correct" procedure should be:

$ hg clone http://hg.code.sf.net/p/octave/communications octave-communications
$ cd octave-communications
$ hg patch ../octave-4.4-all.patch
$ make all
$ make install

This might involve the installation of some additional tools, which are not standard for non-developer (Mercurial, libtool, ...).

Running "make check" I get one fail for "qfuncinv.m".  Thus whats prevents from the patch application?

Sometimes I underestimate, how complicated forge packages are, sorry for the noise ;-)

Kai Torben Ohlhus <siko1056>
Project Member
Tue 09 Oct 2018 06:31:40 PM UTC, comment #9: 

The patch file #44095 should already be doing that. Not sure how you allpied it, but you then need to run autoconf in the src up update configure

John Donoghue <lostbard>
Project Member
Tue 09 Oct 2018 03:14:37 PM UTC, comment #8: 

For my 64-bit build, I see the following build error:

ov-galois.h:43:13: error: conflicting declaration ‘typedef int octave_hdf5_id’
typedef int octave_hdf5_id;
             ^~~~~~~~~~~~~~
In file included from

[skip long list]

/path/to/octave/include/octave-4.4.1/octave/oct-hdf5-types.h:35:17: note: previous declaration as ‘typedef int64_t octave_hdf5_id’
typedef int64_t octave_hdf5_id;

and

ov-galois.cc:35:12: fatal error: octave/ls-oct-ascii.h: No such file or directory
#  include <octave/ls-oct-ascii.h>

The patch (file #44095) can be extended to remove the redundant definition and the inclusion of the non-existing header ls-oct-ascii.h should be avoided too https://hg.savannah.gnu.org/hgweb/octave/rev/c6224b4e7774.

Kai Torben Ohlhus <siko1056>
Project Member
Fri 01 Jun 2018 08:45:14 PM UTC, comment #7: 

Patch (file #44095) tested on cygwin 64bit.
It builds fine and pass almost all

Summary:

  PASS                              456
  FAIL                                1

all the warnings seem obvious and if needed I volunteer to clean them for a 1.2.2 release.

marco atzeri <matzeri>
Fri 04 May 2018 08:19:43 PM UTC, comment #6: 

Updated all in one patch that should eplace all the others for 4.2 and 4.4

(file #44095)

John Donoghue <lostbard>
Project Member
Wed 19 Jul 2017 04:48:13 PM UTC, comment #5: 

For completeness, file #35540 is required for 4.2.X

In addition theses changes (pushed to mxe-octave from JWE) are also needed to the 4.4 dev octave.

(file #41245)

John Donoghue <lostbard>
Project Member
Wed 25 Nov 2015 02:09:17 PM UTC, comment #4: 

Yeah working on patch for octcdf

John Donoghue <lostbard>
Project Member
Wed 25 Nov 2015 01:45:06 PM UTC, comment #3: 

Confirmed, I noted this > 2 weeks ago but didn't pay much attention.

FYI, octcdf doesn't build either with recent dev versions (for me at least).

Philip Nienhuis <philipnienhuis>
Project Member
Tue 24 Nov 2015 10:11:37 PM UTC, comment #2: 

Updated patch attached

(file #35540)

John Donoghue <lostbard>
Project Member
Tue 24 Nov 2015 09:47:07 PM UTC, comment #1: 

Patch attached to check for define

(file #35539)

John Donoghue <lostbard>
Project Member
Tue 24 Nov 2015 09:41:14 PM UTC, original submission:  

communications package relies on OV_REP_TYPE which was removed from dev octave.

John Donoghue <lostbard>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #48042:  octave-6.0-all.patch added by lostbard (62KiB - application/octet-stream)
file #48041:  octave-6.0-all.patch added by lostbard (64KiB - application/octet-stream)
file #47415:  comms-hdf3.patch added by lostbard (1KiB - text/x-patch)
file #47414:  octave-5.0-3-all.patch added by lostbard (51KiB - application/octet-stream)
file #47413:  octave-5.0-2-all.patch added by lostbard (52KiB - application/octet-stream)
file #47108:  octave-5.0-all.patch added by lostbard (52KiB - application/octet-stream)
file #44095:  octave-4.4-all.patch added by lostbard (16KiB - application/octet-stream)
file #41245:  of-communications-2-fixes.patch added by lostbard (9KiB - application/octet-stream)
file #35540:  ov_rep2.patch added by lostbard (646B - application/octet-stream)
file #35539:  ov_rep.patch added by lostbard (726B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by nir_krakauer (Posted a comment)
  • -email is unavailable- added by chrisgorman (Posted a comment)
  • -email is unavailable- added by mchagas (Posted a comment)
  • -email is unavailable- added by opoplawski (Posted a comment)
  • -email is unavailable- added by cbalways (Waiting for the fix)
  • -email is unavailable- added by opoplawski
  • -email is unavailable- added by siko1056 (Posted a comment)
  • -email is unavailable- added by matzeri (Posted a comment)
  • -email is unavailable- added by jwe (Updated the item)
  • -email is unavailable- added by lostbard (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 20 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-02-28 mtmiller Assigned tomtmiller => None
    2019-12-10 lostbard Attached File- => Added octave-6.0-all.patch, #48042
    2019-12-10 lostbard Attached File- => Added octave-6.0-all.patch, #48041
    2019-11-13 siko1056 Summary[octave forge] (communications) fails to build with latest dev octave => [octave forge] (communications) fails to build with latest stable octave
    2019-08-31 lostbard Attached File- => Added comms-hdf3.patch, #47415
    2019-08-30 lostbard Attached File- => Added octave-5.0-3-all.patch, #47414
    2019-08-30 lostbard Attached File- => Added octave-5.0-2-all.patch, #47413
    2019-06-18 lostbard Attached File- => Added octave-5.0-all.patch, #47108
    2019-01-08 cbalways Carbon-Copy- => Added cbalways@gmail.com
    2018-11-15 opoplawski Carbon-Copy- => Added opoplawski
    2018-10-09 mtmiller Carbon-CopyRemoved 80942 => -
    2018-10-09 mtmiller StatusPatch Reviewed => Postponed
    2018-10-09 siko1056 StatusPatch Submitted => Patch Reviewed
    2018-05-04 lostbard StatusNone => Patch Submitted
    2018-05-04 lostbard Attached File- => Added octave-4.4-all.patch, #44095
    2017-08-13 jwe Summarycommunications fails to build with latest dev octave => [octave forge] (communications) fails to build with latest dev octave
    2017-07-19 lostbard Attached File- => Added of-communications-2-fixes.patch, #41245
    2016-03-29 mtmiller Assigned toNone => mtmiller
    2015-11-24 lostbard Attached File- => Added ov_rep2.patch, #35540
    2015-11-24 lostbard Attached File- => Added ov_rep.patch, #35539

    Back to the top


    Powered by Savane 3.5