bugGNU Octave - Bugs: bug #46521, [octave forge] (communications)...

 
 

bug #46521: [octave forge] (communications) fails to build with latest dev octave

Submitted by:  John Donoghue <lostbard>
Submitted on:  Tue 24 Nov 2015 09:41:14 PM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Postponed Assigned to:  Mike Miller <mtmiller>
Originator Name:  JohnD Open/Closed:  Open
Release:  dev Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Wed 19 Jun 2019 02:43:55 PM UTC, comment #14: 

Whats the error ?

John Donoghue <lostbard>
Project Member
Wed 19 Jun 2019 02:43:53 AM UTC, comment #13: 

FWIW - build still fails for me with the updated patch.  It appears that it cannot find HDF5 1.10.5.  Haven't had a chance to poke at that yet.

Orion Poplawski <opoplawski>
Tue 18 Jun 2019 06:01:44 PM UTC, comment #12: 

Updated patch for 5.0

(file #47108)

John Donoghue <lostbard>
Project Member
Tue 09 Oct 2018 08:15:41 PM UTC, comment #11: 

> whats prevents from the patch application?


This patch is fine for mxe, but not appropriate to apply to the communications package itself. It inserts copies of the base_lu classes that have been removed from Octave. A better solution is to port to the new lu classes in Octave 4.2 and 4.4, see bug #47267. I have not seen anyone attempt to actually port to Octave 4.4 yet, therefore this remains open.

> I get one fail for "qfuncinv.m"


See bug #54156, that is a trivial fix.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Tue 09 Oct 2018 07:54:55 PM UTC, comment #10: 

Regarding comment #9, you are right.  I applied this patch too naively as described on the mailing list helping two desperate users of the package:

https://lists.gnu.org/archive/html/help-octave/2018-10/msg00069.html

The "correct" procedure should be:

$ hg clone http://hg.code.sf.net/p/octave/communications octave-communications
$ cd octave-communications
$ hg patch ../octave-4.4-all.patch
$ make all
$ make install

This might involve the installation of some additional tools, which are not standard for non-developer (Mercurial, libtool, ...).

Running "make check" I get one fail for "qfuncinv.m".  Thus whats prevents from the patch application?

Sometimes I underestimate, how complicated forge packages are, sorry for the noise ;-)

Kai Torben Ohlhus <siko1056>
Project Member
Tue 09 Oct 2018 06:31:40 PM UTC, comment #9: 

The patch file #44095 should already be doing that. Not sure how you allpied it, but you then need to run autoconf in the src up update configure

John Donoghue <lostbard>
Project Member
Tue 09 Oct 2018 03:14:37 PM UTC, comment #8: 

For my 64-bit build, I see the following build error:

ov-galois.h:43:13: error: conflicting declaration ‘typedef int octave_hdf5_id’
typedef int octave_hdf5_id;
             ^~~~~~~~~~~~~~
In file included from

[skip long list]

/path/to/octave/include/octave-4.4.1/octave/oct-hdf5-types.h:35:17: note: previous declaration as ‘typedef int64_t octave_hdf5_id’
typedef int64_t octave_hdf5_id;

and

ov-galois.cc:35:12: fatal error: octave/ls-oct-ascii.h: No such file or directory
#  include <octave/ls-oct-ascii.h>

The patch (file #44095) can be extended to remove the redundant definition and the inclusion of the non-existing header ls-oct-ascii.h should be avoided too https://hg.savannah.gnu.org/hgweb/octave/rev/c6224b4e7774.

Kai Torben Ohlhus <siko1056>
Project Member
Fri 01 Jun 2018 08:45:14 PM UTC, comment #7: 

Patch (file #44095) tested on cygwin 64bit.
It builds fine and pass almost all

Summary:

  PASS                              456
  FAIL                                1

all the warnings seem obvious and if needed I volunteer to clean them for a 1.2.2 release.

marco atzeri <matzeri>
Fri 04 May 2018 08:19:43 PM UTC, comment #6: 

Updated all in one patch that should eplace all the others for 4.2 and 4.4

(file #44095)

John Donoghue <lostbard>
Project Member
Wed 19 Jul 2017 04:48:13 PM UTC, comment #5: 

For completeness, file #35540 is required for 4.2.X

In addition theses changes (pushed to mxe-octave from JWE) are also needed to the 4.4 dev octave.

(file #41245)

John Donoghue <lostbard>
Project Member
Wed 25 Nov 2015 02:09:17 PM UTC, comment #4: 

Yeah working on patch for octcdf

John Donoghue <lostbard>
Project Member
Wed 25 Nov 2015 01:45:06 PM UTC, comment #3: 

Confirmed, I noted this > 2 weeks ago but didn't pay much attention.

FYI, octcdf doesn't build either with recent dev versions (for me at least).

Philip Nienhuis <philipnienhuis>
Project Member
Tue 24 Nov 2015 10:11:37 PM UTC, comment #2: 

Updated patch attached

(file #35540)

John Donoghue <lostbard>
Project Member
Tue 24 Nov 2015 09:47:07 PM UTC, comment #1: 

Patch attached to check for define

(file #35539)

John Donoghue <lostbard>
Project Member
Tue 24 Nov 2015 09:41:14 PM UTC, original submission:  

communications package relies on OV_REP_TYPE which was removed from dev octave.

John Donoghue <lostbard>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #47108:  octave-5.0-all.patch added by lostbard (52KiB - application/octet-stream)
file #44095:  octave-4.4-all.patch added by lostbard (16KiB - application/octet-stream)
file #41245:  of-communications-2-fixes.patch added by lostbard (9KiB - application/octet-stream)
file #35540:  ov_rep2.patch added by lostbard (646B - application/octet-stream)
file #35539:  ov_rep.patch added by lostbard (726B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by opoplawski (Posted a comment)
  • -email is unavailable- added by cbalways (Waiting for the fix)
  • -email is unavailable- added by opoplawski
  • -email is unavailable- added by siko1056 (Posted a comment)
  • -email is unavailable- added by matzeri (Posted a comment)
  • -email is unavailable- added by jwe (Updated the item)
  • -email is unavailable- added by lostbard (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 13 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-06-18 lostbard Attached File- => Added octave-5.0-all.patch, #47108
    2019-01-08 cbalways Carbon-Copy- => Added cbalways@gmail.com
    2018-11-15 opoplawski Carbon-Copy- => Added opoplawski
    2018-10-09 mtmiller Carbon-CopyRemoved 80942 => -
    2018-10-09 mtmiller StatusPatch Reviewed => Postponed
    2018-10-09 siko1056 StatusPatch Submitted => Patch Reviewed
    2018-05-04 lostbard StatusNone => Patch Submitted
    2018-05-04 lostbard Attached File- => Added octave-4.4-all.patch, #44095
    2017-08-13 jwe Summarycommunications fails to build with latest dev octave => [octave forge] (communications) fails to build with latest dev octave
    2017-07-19 lostbard Attached File- => Added of-communications-2-fixes.patch, #41245
    2016-03-29 mtmiller Assigned toNone => mtmiller
    2015-11-24 lostbard Attached File- => Added ov_rep2.patch, #35540
    2015-11-24 lostbard Attached File- => Added ov_rep.patch, #35539

    Back to the top


    Powered by Savane 3.5