bugGNU Octave - Bugs: bug #47267, [octave forge] (communications)...

 
 

bug #47267: [octave forge] (communications) port to lu<T> refactoring in 4.1 branch

Submitted by:  Philip Nienhuis <philipnienhuis>
Submitted on:  Thu 25 Feb 2016 09:50:38 PM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Confirmed Assigned to:  Mike Miller <mtmiller>
Originator Name:  Philip Nienhuis Open/Closed:  Open
Release:  dev Operating System:  Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Thu 02 Aug 2018 10:22:13 AM UTC, comment #15:

Not yet, for fyi, bug #46521 has an all in one patch for the package

John Donoghue <lostbard>
Project Member
Thu 02 Aug 2018 05:47:23 AM UTC, comment #14:

Any updates? This would have been a really cool package to use.

Anonymous
Wed 28 Mar 2018 06:00:34 PM UTC, comment #13:

Any update on this?

Tom Olin <tom_olin>
Wed 03 Jan 2018 10:53:31 AM UTC, comment #12:

When run on Linux with Octave 4.2, the communications package continues to throw this error when installing directly from Octave-Forge.

I needed a quick and dirty solution so that I can install the communications package. Here's what I came up with.

I made a version of this package with JWE's patch included, as well as two other patches posted on bug #46521. At this point, I discovered that the package had two other build errors: the configure.ac check for octave_md5_id was no longer working, and a file was attempting to include the no-longer-existing file ls-oct-ascii.h. I removed the octave_md5_id typedef logic and copied 4.0.3's ls-oct-ascii.h into my octave-communications fork.

Here is a way to install my fork:

There are also many other warnings when attempting to build the octave-communications package as well. I still hope to see an official release of this package with the build failures fixed.

Setup: CentOS 7 with Octave built from source on the tip of the "stable" branch.

Shane <sffc>
Tue 05 Sep 2017 04:00:11 PM UTC, comment #11:

Rik - John is saying that the of-communications target in mxe-octave applies a patch to fix this. It's fixed in that you can build of-communications in mxe-octave. But the original pkg does not build against Octave 4.2 unpatched.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Tue 05 Sep 2017 03:49:58 PM UTC, comment #10:

@John: For testing, I used

Does this not correctly test compilation?

Rik <rik5>
Project Administrator
Tue 05 Sep 2017 12:05:03 PM UTC, comment #9:

Doesn't work for me with dev octave in linux:

galois.h:25:10: fatal error: octave/base-lu.h: No such file or directory
#include <octave/base-lu.h>

The mxe version works as it was patched from comment #5

John Donoghue <lostbard>
Project Member
Tue 05 Sep 2017 03:45:40 AM UTC, comment #8:

Just checked and

completes just fine with MXE Octave.

Marking as fixed and closing report.

Rik <rik5>
Project Administrator
Thu 04 May 2017 04:09:26 AM UTC, comment #7:

Any update on this?

I tripped over this attempting to do a "pkg install communications" on OS X.

Andrew P. Lentvorski Jr. <bsder>
Sat 28 Jan 2017 06:43:29 AM UTC, comment #6:

Mike,
any plan to updated the package with John's patch or another to allow build on any 4.2 ?

marco atzeri <matzeri>
Wed 31 Aug 2016 08:36:48 PM UTC, comment #5:

I checked in this temporary fix for mxe-octave:

http://hg.octave.org/mxe-octave/rev/f7fce04ebafa

I'm not claiming this patch is complete or the best fix, but it does allow me to build the communications package with mxe-octave now.

John W. Eaton <jwe>
Project Administrator
Thu 07 Jul 2016 04:24:35 AM UTC, comment #4:

I haven't looked at this very closely, figured it's best to wait for the 4.2 changes to settle down before figuring out how best to adapt this package.

If it matters, in the long run I'm considering whether it would be better to get rid of the octave_value type and rewrite as an m-file class with stateless C++ functions to do the heavy lifting. Not sure at the moment how the lu stuff would fit into that though.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Thu 07 Jul 2016 04:12:05 AM UTC, comment #3:

Hmm, lu is not compatible with base_lu, primarily because of the addition of the column_vector_type typedef and the updating functions, so a simple template alias won't work. It would be possible to reinstate the base_lu class and mark it as deprecated. I'm not sure whether that would be better than just modifying the galois classes to use the new lu class. It's also not clear to me what to do about the column_vector_type typedef for the galois class.

John W. Eaton <jwe>
Project Administrator
Wed 06 Jul 2016 10:40:39 PM UTC, comment #2:

Or, would it be reasonably easy to provide a backward-compatible base_lu class? I think I just removed the base-lu files because I didn't find a package that used them.

John W. Eaton <jwe>
Project Administrator
Thu 25 Feb 2016 10:08:17 PM UTC, comment #1:

Confirmed on Linux. The lu classes have been redone in the Octave 4.1 development branch:

http://hg.savannah.gnu.org/hgweb/octave/rev/7e67c7f82fc1

Needs changes to communications to support lu factorization of the galois array class.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Thu 25 Feb 2016 09:50:38 PM UTC, original submission:

Cross-building Octave-4.1.0+:

log attached

Philip Nienhuis <philipnienhuis>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #36465:  of-communications.zip added by philipnienhuis (3KiB - application/force-download)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -email is unavailable- added by tom_olin (Posted a comment)
  • -email is unavailable- added by sffc (Posted a comment)
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by bsder (Posted a comment)
  • -email is unavailable- added by matzeri (Posted a comment)
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by philipnienhuis (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-03-28 rik5 Carbon-CopyRemoved 72865 => -
    2017-09-05 mtmiller Open/ClosedClosed => Open
    2017-09-05 rik5 Open/ClosedOpen => Closed
    2017-08-24 mtmiller Dependencies- => bugs #51837 is dependent
    2017-08-13 jwe Summarycommunications package: port to lu<T> refactoring in 4.1 branch => [octave forge] (communications) port to lu refactoring in 4.1 branch
    2016-02-25 mtmiller StatusNone => Confirmed
        Assigned toNone => mtmiller
        Operating SystemOther => Any
        Summary[MXE] building of-communication fails => communications package: port to lu refactoring in 4.1 branch
    2016-02-25 philipnienhuis Attached File- => Added of-communications.zip, #36465

    Back to the top


    Powered by Savane 3.3