bugGNU Octave - Bugs: bug #46444, [octave forge] (signal) buttord,...

 
 

bug #46444: [octave forge] (signal) buttord, cheb1ord, cheb2ord : different errors

Submitted by:  Charles Praplan <charprap>
Submitted on:  Sat 14 Nov 2015 01:49:29 PM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: Patch SubmittedAssigned to: Mike Miller <mtmiller>
Originator Name: Charles PraplanOpen/Closed: Open
Release: otherOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 22 Dec 2015 05:46:00 PM UTC, comment #2:

Thanks for your contribution to the signal package functions. I am definitely interested in taking a look at these changes.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Sat 05 Dec 2015 08:35:57 AM UTC, comment #1:

Hi,

I made a few corrections (and improvements) in the comments (and only in the comments) of the m-files I posted some time ago.

I attached the new diff files (diff from the official version of signal package 1.3.2): (file #35643 to 35645).

Please, let me know if this contribution is of interest.
Charles

Charles Praplan <charprap>
Sat 14 Nov 2015 01:49:29 PM UTC, original submission:

The functions buttord, cheb1ord, cheb2ord had different problems
and missing functionalities on which I worked to propose
here corrections. As the corrections are partially the same for
all 3 function, I decided to post only one error report.

I append a zip file with all the necessary files and testcases,
and the diff files.

Below the detailed description of all corrections, each time with
the corresponding test case.

buttord:
=======

1) Error corrected

The known problem of overdesigning bandpass and bandreject filters
(displayed as warning by the function) has been solved.

Test cases: buttord_test_dig_BP.m
buttord_test_dig_notch.m

2)Improvements

2.1) Analog filters are now supported as in Matlab.
(this includes a new 'validate_filter_bandss.m'
function for analog filters that I already submitted
in the case of the ellipord function).

Test cases: buttord_test_ana_LP.m
buttord_test_ana_HP.m
buttord_test_ana_BP.m
buttord_test_ana_notch.m

2.2) New output argument allows to make the filter caracteristic
touch the passband or stopband corner.

Test cases: buttord_test_ana_LP.m
buttord_test_ana_HP.m
buttord_test_ana_BP.m
buttord_test_ana_notch.m

buttord_test_dig_LP.m
buttord_test_dig_HP.m
buttord_test_dig_BP.m
buttord_test_dig_notch.m

cheb1ord and cheb2ord:
=====================

1) Error corrected

Solved problem in cheb2ord for band pass filter:
filter did not satisfy requirements in case of
NOT symmetrical requirements

Test cases: buttord_test_dig_BP.m (fig 5 to 8)

2) Missing functionaly

Notch filters are now supported

Test cases: cheb12ord_test_ana_notch.m
cheb12ord_test_dig_notch.m

Test cases: cheb12ord_test_ana_LP.m
cheb12ord_test_ana_HP.m
cheb12ord_test_ana_BP.m
cheb12ord_test_ana_notch.m

cheb12ord_test_dig_LP.m
cheb12ord_test_dig_HP.m
cheb12ord_test_dig_BP.m
cheb12ord_test_dig_notch.m

3)Improvements

3.1) Analog filters are now supported as in Matlab.
(this includes a new 'validate_filter_bandss.m'
function for analog filters that I already submitted
in the case of the ellipord function).

Test cases: cheb12ord_test_ana_LP.m
cheb12ord_test_ana_HP.m
cheb12ord_test_ana_BP.m
cheb12ord_test_ana_notch.m

3.2) New output argument allowing to make the filter caracteristic
touch the passband or stopband corner.

Test cases: cheb12ord_test_ana_LP.m
cheb12ord_test_ana_HP.m
cheb12ord_test_ana_BP.m
cheb12ord_test_ana_notch.m

cheb12ord_test_dig_LP.m
cheb12ord_test_dig_HP.m
cheb12ord_test_dig_BP.m
cheb12ord_test_dig_notch.m

Charles Praplan <charprap>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #35643:  buttord.diff added by charprap (7KiB - application/octet-stream - Comments improved.)
file #35644:  cheb1ord.diff added by charprap (6KiB - application/octet-stream - Comments improved.)
file #35645:  cheb2ord.diff added by charprap (7KiB - application/octet-stream - Comments improved.)
file #35457:  buttord_cheb1ord_cheb2ord.zip added by charprap (26KiB - application/x-zip)
file #35458:  buttord.diff added by charprap (7KiB - application/octet-stream)
file #35459:  cheb1ord.diff added by charprap (6KiB - application/octet-stream)
file #35460:  cheb2ord.diff added by charprap (6KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by charprap (Submitted the item)
  • -unavailable- added by charprap
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 14 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 14 Aug 2017 04:20:57 PM UTCmtmillerSummarysignal package: buttord, cheb1ord, cheb2ord : different errors=>[octave forge] (signal) buttord, cheb1ord, cheb2ord : different errors
    Tue 22 Dec 2015 05:46:00 PM UTCmtmillerStatusNone=>Patch Submitted
      Assigned toNone=>mtmiller
      Release4.0.0=>other
      Operating SystemMicrosoft Windows=>Any
      Summarybuttord, cheb1ord, cheb2ord : different errors=>signal package: buttord, cheb1ord, cheb2ord : different errors
    Sat 05 Dec 2015 08:33:13 AM UTCcharprapAttached File-=>Added buttord.diff, #35643
      Attached File-=>Added cheb1ord.diff, #35644
      Attached File-=>Added cheb2ord.diff, #35645
    Sat 14 Nov 2015 01:49:29 PM UTCcharprapAttached File-=>Added buttord_cheb1ord_cheb2ord.zip, #35457
      Attached File-=>Added buttord.diff, #35458
      Attached File-=>Added cheb1ord.diff, #35459
      Attached File-=>Added cheb2ord.diff, #35460
      Carbon-Copy-=>Added charprap

    Back to the top


    Powered by Savane 3.1-cleanup1