bugGNU Octave - Bugs: bug #45811, [octave-forge] (signal) ellipord...

 
 

bug #45811: [octave-forge] (signal) ellipord returns complex for band-stop filter

Submitted by:  Charles Praplan <charprap>
Submitted on:  Sun 23 Aug 2015 10:55:34 AM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: Patch SubmittedAssigned to: Mike Miller <mtmiller>
Originator Name: Open/Closed: Open
Release: otherOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 15 Oct 2015 04:04:25 PM UTC, comment #2:

Hi,

I worked a little bit on the ellipord function and found some
corrections and improvements that I have implemented and tested:

1) Correction for complex order for notch filter

2) Correction for minimum order in case of not symetrical
requirements (notch)

In case of not symmetrical requirements, the symmetry was
always done by preserving the passband and modifying the
stopband. This could lead to non minimum order for notch
filters. Note that Matlab also has this problem.

3) Implementation of functionality for analog filters as in
Matlab (this includes a new 'validate_filter_bandss.m'
function for analog filters).

I append the file ellipord_case_2015_10_15.zip containing
the corrected files, 8 test cases and 2 plots to compare
matlab to octave:

- ellipord.m
- validate_filter_bandss.m

- ellipord_test_ana_LP.m
- ellipord_test_ana_HP.m
- ellipord_test_ana_BP.m
- ellipord_test_ana_notch.m
- ellipord_test_dig_LP.m
- ellipord_test_dig_HP.m
- ellipord_test_dig_BP.m
- ellipord_test_dig_notch.m

- result_ellipord_test_ana_notch_with_matlab.png
- result_ellipord_test_ana_notch_with_new_ellipord_octave.pdf

One can run the two notch test cases on matlab to see non
optimal order.

If you find this contribution usefull, please integrate them
into the next release.

Ch. Praplan

(file #35202)

Charles Praplan <charprap>
Sun 23 Aug 2015 07:26:09 PM UTC, comment #1:

Confirmed, thanks for reporting.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Sun 23 Aug 2015 10:55:34 AM UTC, original submission:

Hi,

The function ellipord used for the bandstop filter below delivers a complex order. The same kind of bug (38528) has already been submitted and corrected, but the fix does not help in this case.

Thank you

Charles Praplan <charprap>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #35202:  ellipord_case_2015_10_15.zip added by charprap (51KiB - application/x-zip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jwe (Updated the item)
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by charprap (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 11 Aug 2017 05:41:58 PM UTCjweSummarysignal package: ellipord returns complex for band-stop filter=>[octave-forge] (signal) ellipord returns complex for band-stop filter
    Tue 22 Dec 2015 05:46:52 PM UTCmtmillerStatusConfirmed=>Patch Submitted
    Thu 15 Oct 2015 04:04:25 PM UTCcharprapAttached File-=>Added ellipord_case_2015_10_15.zip, #35202
    Thu 15 Oct 2015 04:03:30 PM UTCcharprapCarbon-CopyRemoved ch=>-
    Sun 23 Aug 2015 07:26:09 PM UTCmtmillerStatusNone=>Confirmed
      Assigned toNone=>mtmiller
      Release4.0.0=>other
      Operating SystemMicrosoft Windows=>Any
      Summaryellipord: complex result=>signal package: ellipord returns complex for band-stop filter
    Sun 23 Aug 2015 10:55:34 AM UTCcharprapCarbon-Copy-=>Added ch

    Back to the top


    Powered by Savane 3.1-cleanup1