patchThe GNU Hurd - Patches: patch #2507, Patch to update autoconf files

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #2507: Patch to update autoconf files

Submitter:  Marco Gerards <marco_g>
Submitted:  Tue 20 Jan 2004 07:45:01 PM UTC
 
Category:  GNU Mach Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  marcus Open/Closed:  Closed
Planned Release:  None
Wiki-like text discussion box: 

( Jump to the original submission )

Tue 12 Jul 2005 11:06:33 PM UTC, comment #9: 

Applied an only very slightly modified version (added more output to the alias option).

Change committed.  The mig change was already committed by Alfred.

2005-07-12  Guillem Jover  <guillem@hadrons.org>

        * configure: Regenerated.
        * i386/configure: Regenerated.

        * Drivers.macros (AC_DRIVER_CLASS): Use AH_TEMPLATE.
        (AC_DRIVER): Set the value for the AC_DEFINE and AC_DEFINE_UNQUOTED
        to 1.

        * aclocal.m4 (AC_PROG_CC_LOCAL, AC_PROG_CC_WORKS_LOCAL): Removed.
        * version.m4: New file.
        * Makefile.in: Use PACKAGE_VERSION, not VERSION.
        * doc/Makefile.in: Likewise.
        * version.c.in: Likewise. Use PACKAGE_NAME, not "GNUmach".
        * i386/linux/Makefile.in (configure): Change its source to
        configure.ac.

        * aclocal.m4: Add missing quotations.
        * Drivers.macros: Likewise.
        * configure.in: Likewise. Include version.m4 and use PACKAGE and
        VERSION m4 macros from it.
        * i386/configure.in: Likewise.
        (AC_INIT): Use new syntax and move source check to AC_CONFIG_SRCDIR.
        * i386/linux/configure.ac: Likewise. Use m4_sinclude, not sinclude.
        * linux/configure.in: Likewise.

        * i386/configure.in: Update AC_DEFINE to the new three argument form.
        * i386/linux/configure.ac: Move AC_DEFINE inside AC_ARG_ENABLE.

        * configure.in: Use AC_CONFIG_LINKS, not AC_LINK_FILES.
        * linux/configure.in: Likewise.

        * i386/configure.in: Call AC_CONFIG_FILES and use the new form of
        AC_OUTPUT.
        * i386/linux/configure.ac: Likewise.
        * linux/configure.in: Likewise

        * configure.in: Use AS_HELP_STRING in AC_ARG_ENABLE help strings.
        * Drivers.macros: Likewise.
        * i386/configure.in: Likewise.
        * i386/linux/configure.ac: Likewise.

2005-07-12  Neal H. Walfield  <neal@cs.uml.edu>

        * configure.in: Update to use autoconf 2.57.
        Do not error out if host_os is not GNU.
        Update AC_DEFINEs to the required three argument form.
        Don't call AC_CHECK_TOOL(CC, gcc) and AC_PROG_CC_LOCAL, just use
        AC_PROG_CC.
        AC_SUBST(LDFLAGS).
        Refactor AC_CONFIG_SUBDIRS to not do variable substitution.
        Call AC_CONFIG_FILES and use the new form of AC_OUTPUT.
        * i386/configure.in: Require autoconf 2.57.
        * linux/configure.in: Likewise.
        * i386/linux/Drivers.in: Move from here...
        * i386/linux/configure.ac: ... to here to conform to the
        environment autoreconf expects.
        (hurd_host_CPU): New macro.
        Call AC_PROG_CC, not AC_PROG_CC_LOCAL.
        AC_SUBST(LD_FLAGS).
        (flashpoint): Update AC_DEFINE to the new three argument form.
        * Drivers.macros (AC_DRIVER): Update AC_DEFINE to the new three
        argument form.

Marcus Brinkmann <marcus>
Project Administrator
Sun 29 May 2005 09:52:23 AM UTC, comment #8: 

This is an example of the error message, Alfred is speaking about:
#v+
mig -nostdinc -DMACH -DCMU -DMACH_KERNEL -DKERNEL -DPACKAGE_NAME=\"GNU\ Mach\" -DPACKAGE_TARNAME=\"gnumach\" -DPACKAGE_VERSION=\"1.3\" -DPACKAGE_STRING=\"GNU\ Mach\ 1.3\" -DPACKAGE_BUGREPORT=\"bug-hurd@gnu.org\" -DMACH_KMSG=  -DCONTINUATIONS -D__ELF__ -Di386 -DLINUX_DEV -I/home/ams/gsc/devel/gnumach/src/i386/i386at -I/home/ams/gsc/devel/gnumach/src/i386/i386 -I/home/ams/gsc/devel/gnumach/src/i386/include -I/home/ams/gsc/devel/gnumach/src/i386/include/mach/sa -I/home/ams/gsc/devel/gnumach/src/i386/bogus -I/home/ams/gsc/devel/gnumach/src/i386 -I. -I/home/ams/gsc/devel/gnumach/src -I/home/ams/gsc/devel/gnumach/src/include -I/home/ams/gsc/devel/gnumach/src/bogus -I/home/ams/gsc/devel/gnumach/src/util -I/home/ams/gsc/devel/gnumach/src/kern -I/home/ams/gsc/devel/gnumach/src/device -header memory_object_user.h -user memory_object_user_user.c -server /dev/null /home/ams/gsc/devel/gnumach/src/vm/memory_object_user.cli
gcc: Mach": No such file or directory
gcc: Mach: No such file or directory
gcc: 1.3": No such file or directory
<command line>:8:14: missing terminating " character
<command line>:11:16: missing terminating " character
#v-

I created the attached mig.in.patch to fix this issue.
Please apply.

2005-05-27  Thomas Schwinge  <schwinge@nic-nac-project.de>

  • mig.in (prj_quote_sh): New shell funcion; copied from Paul Jarc's

prjlibs.  Use that function to properly quote strings in $cppflags
that contain whitespace.

Thomas Schwinge <tschwinge>
Project Administrator
Thu 19 May 2005 07:08:16 AM UTC, comment #7: 

To be able to define PACKAGE_NAME as "GNU Mach", we need to fix MiG to parse arguments that contain whitespaces.  From [mig]/mig.in:

# If an argument to this shell script contains whitespace,
# then we will screw up.  migcom will see it as multiple arguments.

Alfred M. Szmidt <ams>
Wed 27 Oct 2004 05:28:43 AM UTC, comment #6: 

This is another update to my last patch.
The driver classes were not enabled.

Guillem Jover <guillem>
Project Member
Mon 20 Sep 2004 11:18:40 AM UTC, comment #5: 

This is an update to my last patch fixinf some minor
stuff.

I've used @PACKAGE_NAME@ instead of "GNUmach" as suggested
by Alfred. I've found some stuff missing, an AC_DEFINE not
using the three argument form, and added help strings to
all configure arguments.

Guillem Jover <guillem>
Project Member
Wed 15 Sep 2004 11:37:09 AM UTC, comment #4: 

This is an update of Neal's patch and fixes all issues left. The two disabled drivers are now enabled.

The only thing I've not changed is "GNUmach" to @PACKAGE_NAME@ in version.c.in, beacuse it's used for example in "uname -v" and I'm not sure if it will break programs parsing that if the token is split in multiple words.

Just apply in the same way as Neal pointed (except "patch -p1" :).

Guillem Jover <guillem>
Project Member
Tue 07 Sep 2004 09:41:15 AM UTC, comment #3: 

This is an update to marco's patch and represents a complete update
of all of the autoconf files.  It also lets autoreconf work.

http://sources.redhat.com/ml/libc-alpha/2001-07/msg00340.html suggests
that getting rid of AC_PROG_CC_LOCAL and replacing it with
AC_PROG_CC is
correct.

We must use the three argument form of AC_DEFINE at least once or
autoheader emits messages similar to:

    autoheader2.50: warning: missing template: CONFIG_SCSI_OMIT_FLASHPOINT
    autoheader2.50: Use AC_DEFINE([CONFIG_SCSI_OMIT_FLASHPOINT], [], [Description])
    autoreconf2.50: /usr/bin/autoheader failed with exit status: 1

The autoheader documentation says:

     In order to do its job, `autoheader' needs you to document all of
    the symbols that you might use; i.e., there must be at least one
    `AC_DEFINE' or one `AC_DEFINE_UNQUOTED' call with a third argument for
    each symbol (*note Defining Symbols::).

The only issue that this patch has is that I have had to disable the
options for the u1434f and viarhine drivers (in i386/linux/configure.ac)
as there is chokage on the dash in their linux name.  I don't know
what the correct fix is and defer to an autoconf guru.

Apply the patch by running:

$ cd gnumach-1-branch
$ mv i386/linux/{Drivers.in,configure.ac}
$ patch -p0 < autoconf.diff
$ autoreconf -f -i -s

Neal H. Walfield <neal>
Project Administrator
Thu 08 Apr 2004 07:28:35 PM UTC, comment #2: 

Besides the patch from Marco, I had to do following to get gnumach cleanly configured.

--- linux/configure.in.~1.2.~   Sat May 22 01:22:33 1999
+++ linux/configure.in  Thu Apr  8 19:14:13 2004
@@ -14,7 +14,7 @@ dnl USE OF THIS SOFTWARE.

 AC_INIT(src/include/linux/version.h)
 AC_PREREQ(2.12)
-sinclude([../aclocal.m4])
+#sinclude([../aclocal.m4])

 hurd_SYSTYPE

Daniel Wagner <wagi>
Project Member
Sun 29 Feb 2004 01:47:13 PM UTC, comment #1: 

I did make the changes Alfred proposed in his mail:
http://mail.gnu.org/archive/html/bug-hurd/2004-02/msg00237.html

Jeff had some comments on my previous patch:
http://mail.gnu.org/archive/html/bug-hurd/2004-01/msg00090.html

I did not change this because I do not have enough knowledge
about autoconf.  Is the patch ok like it is now or should the
patch be changed like Jeff said?  I need a bit more help in
that case.

The NEWS entry was removed and so was the keyboard patch
because it is already in CVS.

Marco Gerards <marco_g>
Project Member
Tue 20 Jan 2004 07:45:01 PM UTC, original submission:  
Marco Gerards <marco_g>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #8891:  mig.in.patch added by tschwinge (2KiB - application/octet-stream - mig.in.patch)
file #7860:  gnumach-1.3_autoconf_update.patch added by guillem (29KiB - text/x-diff - Full autoconf update to 2.57.)
file #7840:  autoconf.diff added by neal (8KiB - text/x-patch - Update all configure files to 2.57&#729; Make autoreconf work.)
file #7005:  acupdate2.diffcl added by marco_g (8KiB - application/octet-stream)
file #6728:  acupdate.diff added by marco_g (9KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

 

 

Follow 11 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-07-12 marcus StatusNone Done
    Open/ClosedOpen Closed
2005-05-29 tschwinge Attached File- Added mig.in.patch, #4661
2004-10-27 guillem Attached File- Added gnumach-1.3_autoconf_update-3.patch, #3806
2004-09-20 guillem Attached File- Added gnumach-1.3_autoconf_update-2.patch, #3674
2004-09-15 guillem Attached File- Added gnumach-1.3_autoconf_update.patch, #3665
2004-09-07 neal Attached File- Added autoconf.diff, #3645
2004-02-29 marco_g Assigned toroland marcus
    SummaryPatch to update autoconf files, fix a bug in the keyboard driver and NEWS update Patch to update autoconf files
    Attached File- Added acupdate2.diffcl, #2821
2004-01-20 marco_g Attached File- Added acupdate.diff, #2559

Back to the top


Powered by Savane 3.9