patchPSPP - Patches: patch #8527, Adding GRAPH command with simple...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8527: Adding GRAPH command with simple scatterplot and histogram (incl tests and doc)

Submitted by:  Friedrich Beckmann <beckmanf>
Submitted on:  Tue 09 Sep 2014 08:30:11 PM UTC  
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

( Jump to the original submission)

Mon 25 May 2015 08:51:41 AM UTC, comment #9: 
Friedrich Beckmann <beckmanf>
Project Member
Sun 02 Nov 2014 09:17:45 PM UTC, comment #8: 

In that case, I agree that just "2014" is probably appropriate.

John Darrington <jmd>
Project Administrator
Sun 02 Nov 2014 05:23:25 PM UTC, comment #7: 

Hi John,

yes, could be done that way also. However, I considered the file more
new than derived. I derived it from examine.c but it is quite different now.

Friedrich

Friedrich Beckmann <beckmanf>
Project Member
Sun 02 Nov 2014 02:52:35 PM UTC, comment #6: 

Hi Friedrich,

Your patch seems fine, except, that you have removed the "2012, 2013" on the copyright notice.

The GNU legal instructions tell us that we should leave them.  See

http://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html

John Darrington <jmd>
Project Administrator
Sun 02 Nov 2014 11:00:22 AM UTC, comment #5: 

Hi, I modified the code for the graph command according to Johns code review. So this are minor modifications as John has already changed the internationalization issues. John, thanks for the review! The patch is attached in the bug tracker.

https://savannah.gnu.org/patch/index.php?8527

Friedrich

Friedrich Beckmann <beckmanf>
Project Member
Sun 28 Sep 2014 04:37:57 AM UTC, comment #4: 

This was a very nice patch.  Thank you, I committed it.  I only changed it to add updates to AUTHORS and NEWS.

Ben Pfaff <blp>
Project Administrator
Wed 10 Sep 2014 03:09:20 PM UTC, comment #3: 

> I can do that.


Thanks.

> I guess somebody at FSF has figured out a solution that is compliant with german copyright law.


I guess so, since FSF has German contributors.

Here is the form that I suggest using: http://git.savannah.gnu.org/cgit/gnulib.git/plain/doc/Copyright/request-assign.future

If you prefer to assign only the present changes, and not any changes that you might make in the future, this is an alternative: http://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.changes

Thanks again,

Ben.

Ben Pfaff <blp>
Project Administrator
Wed 10 Sep 2014 02:58:59 PM UTC, comment #2: 

Hi Ben,

I can do that. I guess somebody at FSF has figured out a solution that is compliant with german copyright law.

Friedrich

Friedrich Beckmann <beckmanf>
Project Member
Wed 10 Sep 2014 01:58:04 PM UTC, comment #1: 

Thanks for the patch!

We usually require copyright assignment to the FSF for PSPP contributions.  Are you able to do this?  I can send you an email with details.

The reason that GNU does this is described at: http://www.gnu.org/licenses/why-assign.html
Background on the process is described at: http://www.gnu.org/prep/maintain/html_node/Copyright-Papers.html

Thanks,

Ben.

Ben Pfaff <blp>
Project Administrator
Tue 09 Sep 2014 08:30:11 PM UTC, original submission:  

The current version of pspp does not support the GRAPH command. The attached patch adds the GRAPH command with the following charts

  * SCATTERPLOT(BIVARIATE)
  * HISTOGRAM

Other charts are not implemented. The scatterplot x with y by z plot is possible, but only bivariate plots. 
The patch includes

  * source code changes
  * tests (although only no crash tests as the output is graphic...)
  * documentation changes

The patch is based on the current master branch (u8-istream: Fix handling of partial reads). Attached is also a png with a produced scatterplot.

Friedrich Beckmann <beckmanf>
Project Member

 

Attached Files
file #32354:  johns-review-comments-to-graph.patch added by beckmanf (11KiB - application/octet-stream - Code changes from Johns review of the original graph patch)
file #32049:  graph.patch added by beckmanf (33KiB - application/octet-stream - git patch to add GRAPH command)
file #32050:  scatterplot.png added by beckmanf (36KiB - image/png - git patch to add GRAPH command)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by blp (Posted a comment)
  • -email is unavailable- added by beckmanf (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-05-25 beckmanf Open/ClosedOpen => Closed
    2014-11-02 beckmanf Attached File- => Added johns-review-comments-to-graph.patch, #32354
    2014-09-28 blp StatusNone => Done
    2014-09-09 beckmanf Attached File- => Added graph.patch, #32049
        Attached File- => Added scatterplot.png, #32050

    Back to the top


    Powered by Savane 3.5