PSPP - Patches: patch #8527, Adding GRAPH command with simple...
You are not allowed to post comments on this tracker with your current authentication level.
patch #8527: Adding GRAPH command with simple scatterplot and histogram (incl tests and doc)
Submitter: | Friedrich Beckmann <beckmanf> | ||
Submitted: | Tue 09 Sep 2014 08:30:11 PM UTC | ||
Category: | None | Item Group: | None |
Status: | Done | Assigned to: | None |
Open/Closed: | Closed |
( Jump to the original submission )
Mon 25 May 2015 08:51:41 AM UTC, comment #9: |
Friedrich Beckmann <beckmanf>![]() |
Sun 02 Nov 2014 09:17:45 PM UTC, comment #8: In that case, I agree that just "2014" is probably appropriate. |
John Darrington <jmd>![]() |
Sun 02 Nov 2014 05:23:25 PM UTC, comment #7: Hi John,
yes, could be done that way also. However, I considered the file more
Friedrich |
Friedrich Beckmann <beckmanf>![]() |
Sun 02 Nov 2014 02:52:35 PM UTC, comment #6: Hi Friedrich,
Your patch seems fine, except, that you have removed the "2012, 2013" on the copyright notice.
The GNU legal instructions tell us that we should leave them. See
http://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html |
John Darrington <jmd>![]() |
Sun 02 Nov 2014 11:00:22 AM UTC, comment #5: Hi, I modified the code for the graph command according to Johns code review. So this are minor modifications as John has already changed the internationalization issues. John, thanks for the review! The patch is attached in the bug tracker.
https://savannah.gnu.org/patch/index.php?8527
Friedrich |
Friedrich Beckmann <beckmanf>![]() |
Sun 28 Sep 2014 04:37:57 AM UTC, comment #4: This was a very nice patch. Thank you, I committed it. I only changed it to add updates to AUTHORS and NEWS. |
Ben Pfaff <blp>![]() |
Wed 10 Sep 2014 03:09:20 PM UTC, comment #3:
Here is the form that I suggest using: http://git.savannah.gnu.org/cgit/gnulib.git/plain/doc/Copyright/request-assign.future
If you prefer to assign only the present changes, and not any changes that you might make in the future, this is an alternative: http://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.changes
Thanks again,
Ben. |
Ben Pfaff <blp>![]() |
Wed 10 Sep 2014 02:58:59 PM UTC, comment #2: Hi Ben,
I can do that. I guess somebody at FSF has figured out a solution that is compliant with german copyright law.
Friedrich |
Friedrich Beckmann <beckmanf>![]() |
Wed 10 Sep 2014 01:58:04 PM UTC, comment #1: Thanks for the patch!
We usually require copyright assignment to the FSF for PSPP contributions. Are you able to do this? I can send you an email with details.
The reason that GNU does this is described at: http://www.gnu.org/licenses/why-assign.html
Thanks,
Ben. |
Ben Pfaff <blp>![]() |
Tue 09 Sep 2014 08:30:11 PM UTC, original submission:
The current version of pspp does not support the GRAPH command. The attached patch adds the GRAPH command with the following charts
* SCATTERPLOT(BIVARIATE)
Other charts are not implemented. The scatterplot x with y by z plot is possible, but only bivariate plots.
* source code changes
The patch is based on the current master branch (u8-istream: Fix handling of partial reads). Attached is also a png with a produced scatterplot. |
Friedrich Beckmann <beckmanf>![]() |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2015-05-25 | beckmanf | Open/Closed | Open | ![]() |
Closed |
2014-11-02 | beckmanf | Attached File | - | ![]() |
Added johns-review-comments-to-graph.patch, #32354 |
2014-09-28 | blp | Status | None | ![]() |
Done |
2014-09-09 | beckmanf | Attached File | - | ![]() |
Added graph.patch, #32049 |
Attached File | - | ![]() |
Added scatterplot.png, #32050 |
The commit is:
http://git.savannah.gnu.org/cgit/pspp.git/commit/?id=80595f6de2ea8f0b64756d76c7ac3c89a1abbbb8