patchGNUstep - Patches: patch #6677, 64bit windows support (also gcc...

Group
 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6677: 64bit windows support (also gcc 4.4 support in general) for gnustep base

Submitter:  Roland Schwingel <rosch>
Submitted:  Mon 17 Nov 2008 01:16:48 PM UTC
   
 
Category:  Foundation Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Mon 17 Nov 2008 01:54:59 PM UTC, comment #1: 

I applied this patch almost without modification, though I noted that the vast majority of it was cosmetic changes which have no effect on the compiled code and are not necessary for 64bit support (though avoiding useless compiler warnings and declaring pointers as constant if they aren't going to be used to modify things are good changes).
The one thing I did alter was the change to make socket lengths be 'int' as this is wrong on unix.  So I declared them as socklen_t and defined that as int on windows.

Richard Frith-Macdonald <CaS>
Group Member
Mon 17 Nov 2008 01:16:48 PM UTC, original submission:  

Hi...

As already announced on the GNUstep Mailinglist some days ago here is the first patch to allow GNUstep base/libobjc to be 64bit windows compatible.

This patch covers gnustep-base. Most of the stuff is to be gcc 4.4 compliant in matters of warnings. This should cover any platform not only windows.

Some details:

Fix gcc4.4 warnings:
(includes possible usage of unitialized variables)
Additions/GSXML.m
GSSocketStream.m
GSString.m
NSDecimalNumber.m
NSKeyValueMutableArray.m
NSMessagePort.m
NSNumberFormatter.m
NSPredicate.m
NSPropertyList.m
NSRunLoop.m
NSSet.m
NSSocketPort.m
NSString.m
NSURL.m
cifframe.m
mframe.m
win32/GSFileHandle.m
win32/GSRunLoopCtxt.m
win32/NSMessagePort.m
win32/NSMessagePortNameServer.m
win32/NSUserDefaults.m

Correct storage sizes:
GSFormat.m
GSSocketStream.m
NSArray.m
NSCharacterSet.m
NSConnection.m
NSDistributedNotificationCenter.m
NSProxy.m
NSRunLoop.m
NSSocketPort.m
NSTask.m

Take care about import of symbols marked as extern for win64:
GSHTTPURLHandle.m
GSSocketStream.m
win32/NSMessagePort.m
win32/NSMessagePortNameServer.m

Misc:
GSFFCallInvocation.m: mark function as unused
GSFFIInvocation.m: mark function as unused
NSDebug.m: with new windows crt SIGBUS is defined
NSObject.m: with new windows crt Interlocked(In|De)crement are defined
inet_ntop.c: mark function as unused

These aren't dramatic changes and could IMHO be applied easily.

Roland

Roland Schwingel <rosch>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #16860:  base.patch added by rosch (26KiB - application/octet-stream - Patch for 64bit/gcc 4.4 compatibility)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by CaS (Posted a comment)
  • -email is unavailable- added by rosch (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-11-17 CaS StatusNone Done
        Open/ClosedOpen Closed
    2008-11-17 rosch Attached File- Added base.patch, #16860

    Back to the top

    Powered by Savane 3.13-bb6a.
    Corresponding source code