GNUstep - Patches: patch #6630, Patch to always check -isFlipped...
You are not allowed to post comments on this tracker with your current authentication level.
patch #6630: Patch to always check -isFlipped as Cocoa does rather than accessing the flag directly
Submitter: | Quentin Mathé <qmathe> | ||
Submitted: | Wed 03 Sep 2008 05:53:02 PM UTC | ||
Category: | AppKit | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | None | Open/Closed: | Closed |
Sun 07 Sep 2008 12:13:28 PM UTC, comment #3: |
Fred Kiefer <FredKiefer> |
Sun 07 Sep 2008 09:34:46 AM UTC, comment #2: Well ... I don't remember much about this, so I can only state the obvious ...
|
Nicola Pero <nico> |
Sat 06 Sep 2008 10:07:20 PM UTC, comment #1: Your patch removes only two usages of this flag from the code. I am not sure, whether this approach would create even more problems in the long run. Shouldn't we remove this optimisation completely?
|
Fred Kiefer <FredKiefer> |
Wed 03 Sep 2008 05:53:02 PM UTC, original submission:
Here is a patch to ensure the flipping is always determined by calling -isFlipped as Cocoa does instead of accessing _rFlags.flipped_view.
|
Quentin Mathé <qmathe> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2010-12-27 | FredKiefer | Status | None | Done | |
Open/Closed | Open | Closed | |||
2008-09-03 | qmathe | Attached File | - | Added NSView-flipping.m.patch, #16424 |
Powered by Savane 3.13-02a9.
Corresponding source code
Good point. I would expect that the optimisation is used less then five times per drawing request on each view. But it will be hard to count.
A grep on flipped_view shows that this mostly is used for NSScrollView and there is another hack in place for NSClipView.
(Apart from the usage in NSView and one marginal case in NSSplitView) Only the usage in NSView could be performance critical, as far as I can tell.
My current idea is to set this variable in _rebuildCoordinates, that way we have the correct value and as long as nothing changes the method wont get called.
Still, if the ivar only gets used as little as we all expect, we might as well remove it.