GNUstep - Patches: patch #6286, NSBezierPath encode/decode...
You are not allowed to post comments on this tracker with your current authentication level.
patch #6286: NSBezierPath encode/decode improperly implemented
Submitter: | Christopher Wojno <wojno> | ||
Submitted: | Tue 27 Nov 2007 06:43:28 AM UTC | ||
Category: | AppKit | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | FredKiefer | Open/Closed: | Closed |
Jump to the original submission
Tue 22 Jan 2008 09:37:04 PM UTC, comment #6: |
Fred Kiefer <FredKiefer> |
Thu 29 Nov 2007 07:37:49 PM UTC, comment #5: Ah, now I see what you were doing. You wanted it to fall through so you didn't have to write the encode again. That does not work, however, with the decoder as you saw. The encoder case is correct then. It's still broken without @encode(enum NSBezierPathElement) however.
|
Christopher Wojno <wojno> |
Thu 29 Nov 2007 09:53:24 AM UTC, comment #4: First I have to apologize as I didn't find the time to test keyed encoding of NSBezierPath on the Apple. If we really try to support keyed encoding here, it should be compatible.
|
Fred Kiefer <FredKiefer> |
Thu 29 Nov 2007 09:37:22 AM UTC, comment #3: While we're at it: Here's more problems with this code. I've actually experienced corrupt archives because of it. I'm shocked I missed it the first round.
|
Christopher Wojno <wojno> |
Tue 27 Nov 2007 06:07:25 PM UTC, comment #2:
|
Christopher Wojno <wojno> |
Tue 27 Nov 2007 05:43:40 PM UTC, comment #1: Thank you for the nice patch, but before applying it I would like to understand some details.
|
Fred Kiefer <FredKiefer> |
Tue 27 Nov 2007 06:43:28 AM UTC, original submission:
NSBezierPath, as implemnted, will yield the following error message on archive/unarchive:
|
Christopher Wojno <wojno> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 8 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2008-01-22 | FredKiefer | Open/Closed | Open | Closed | |
2008-01-22 | FredKiefer | Status | None | Done | |
2007-11-29 | wojno | Attached File | - | Added gnustep-gui-nsbezierpath-encode-missing-move-to-fix-and-point-order.patch, #14509 | |
2007-11-29 | wojno | Attached File | - | Added gnustep-gui-nsbezierpath-encode-missing-move-to-fix.patch, #14506 | |
2007-11-27 | FredKiefer | Priority | 7 - High | 5 - Normal | |
Assigned to | None | FredKiefer | |||
2007-11-27 | wojno | Attached File | - | Added gnustep-gui-nsbezierpath-encode-fix.patch, #14490 | |
Carbon-Copy | - | Added -email is unavailable- |
Powered by Savane 3.13-02a9.
Corresponding source code
Most of this should be resolved in SVN for some time now. The remaining difference @encode(enum NSBezierPathElement) should be down to a compiler bug, as discussed on the mailing list.