bugGNU Octave - Bugs: bug #54334, GUI Network Preferences don't...

 
 

bug #54334: GUI Network Preferences don't appear to do anything

Submitter:  Rik <rik5>
Submitted:  Wed 18 Jul 2018 04:41:51 PM UTC
   
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 11 Jun 2020 11:55:41 AM UTC, comment #15: 

And another minor change that hopefully fixes the compilation error with clang on Mac that Andrew mentioned in bug #52840:
https://savannah.gnu.org/bugs/?52840#comment26

https://hg.savannah.gnu.org/hgweb/octave/rev/7de12a40e87b

Markus Mützel <mmuetzel>
Group administrator
Tue 09 Jun 2020 08:48:17 PM UTC, comment #14: 

One last small modification here: https://hg.savannah.gnu.org/hgweb/octave/rev/02a5da73a157.

I changed the list of environment variable strings from std::vector (which can change at runtime) to std::array (which has fixed size at compile time).  Since the list is fixed, we might as well use the smallest, lightest weight container that is available in C++ which still does the job.

Rik <rik5>
Group administrator
Tue 09 Jun 2020 07:13:05 PM UTC, comment #13: 

From my testing, your patch did not break anything. Thanks for the fix and the code upgrade.

Closing as fixed.


Torsten Lilge <ttl>
Group Member
Tue 09 Jun 2020 08:48:27 AM UTC, comment #12: 

I can't test if I broke the proxy settings.
But I can cross build for Windows with these changes. And the Windows buildbots seem to be happy again, too.

Markus Mützel <mmuetzel>
Group administrator
Mon 08 Jun 2020 08:56:29 PM UTC, comment #11: 

No problem, Markus.

Torsten Lilge <ttl>
Group Member
Mon 08 Jun 2020 08:01:35 PM UTC, comment #10: 

@Torsten: Sorry. Didn't realize you wrote that. (I still don't receive notifications.)

I pushed a change here:
http://hg.savannah.gnu.org/hgweb/octave/rev/c648cca864db

Marking as ready for test.

Markus Mützel <mmuetzel>
Group administrator
Mon 08 Jun 2020 07:07:20 PM UTC, comment #9: 

I am going to fix the getenv/setenv issue.

Torsten Lilge <ttl>
Group Member
Mon 08 Jun 2020 05:04:29 PM UTC, comment #8: 

Markus: Yes, and we should probably also be using getenv from there as well so that it will use the portability wrapper from lo-sysdep.cc.

John W. Eaton <jwe>
Group administrator
Mon 08 Jun 2020 04:21:29 PM UTC, comment #7: 

"setenv" is not available cross platform:
https://www.gnu.org/software/gnulib/manual/html_node/setenv.html

Could we use octave::sys::env::putenv from oct-env.h instead?

Markus Mützel <mmuetzel>
Group administrator
Mon 08 Jun 2020 03:49:44 PM UTC, comment #6: 

Tested, and seems to work well.  Marking as fixed and closing report.

Rik <rik5>
Group administrator
Sun 07 Jun 2020 08:42:44 AM UTC, comment #5: 

I have pushed changeset http://hg.savannah.gnu.org/hgweb/octave/rev/e2e615821ef5 for setting environment variables with manually configures proxy settings. Hope that the proxy settings are now doing what is expected.

Torsten Lilge <ttl>
Group Member
Wed 03 Jun 2020 10:39:05 PM UTC, comment #4: 

It looks to me like the first option in the dropdown menu is HTTP_PROXY.  Therefore, I think we should just set HTTP_PROXY and HTTPS_PROXY.  Using a proxy for ftp is pretty rare anyways, and if someone wants to do it they can set the environment variable themselves.

Rik <rik5>
Group administrator
Wed 03 Jun 2020 07:52:44 PM UTC, comment #3: 

Sure, that should be no problem.

I have no experience in proxies. Should the
ALL_PROXY variable be set or HTTP_PROXY, HTTPS_PROXY, and FTP_PROXY? And should we include user:password into the environment variables?

Torsten Lilge <ttl>
Group Member
Wed 03 Jun 2020 04:32:57 PM UTC, comment #2: 

What it we changed it so the GUI code called the Octave function setenv() with the correct variable(s), such as HTTP_PROXY, so that the curl library would honor the user's choice?

Rik <rik5>
Group administrator
Wed 03 Jun 2020 06:50:30 AM UTC, comment #1: 

The network settings are only used within the qt framework. Most (all?) of the network access of octave is implemented without using this framework, like, e.g., reading the community news.

Should we drop the network (proxy) settings?

Torsten Lilge <ttl>
Group Member
Wed 18 Jul 2018 04:41:51 PM UTC, original submission:  

I have a local proxy which I can use at 127.0.0.1 and port 5000.  However, if I use the GUI's Edit/Preferences menu and then set the Network Preferences to use an HttpProxy of 127.0.0.1, port 5001 everything still works.  I test by using News/Community News.

On the other hand, if I set an https proxy directly by using


setenv ('https_proxy', '127.0.0.1:5001')


then the Community News fails to load.

Incidentally, because Community News seems to be cached, you need to quit Octave between any changes to these network variables.

Is it possible that the GUI is setting an HTTP proxy when it needs to be setting an HTTPS proxy?  Or are the Network Preferences simply not used at all?



Rik <rik5>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-06-09 ttl StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2020-06-08 mmuetzel StatusIn Progress Ready For Test
    2020-06-08 mmuetzel StatusFixed In Progress
        Open/ClosedClosed Open
    2020-06-08 rik5 StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2020-06-07 ttl StatusNone Ready For Test
        Release4.4.0 dev

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code